{"id":3472,"url":"https://patchwork.libcamera.org/api/patches/3472/?format=json","web_url":"https://patchwork.libcamera.org/patch/3472/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200416115740.6732-1-laurent.pinchart@ideasonboard.com>","date":"2020-04-16T11:57:40","name":"[libcamera-devel] libcamera: Make IPA module signing mandatory for the meantime","commit_ref":"b382f67c833de08717cfec19273b95f5819cab27","pull_url":null,"state":"accepted","archived":false,"hash":"e3b715aa1af319a9eeca186b934be320173a4a43","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3472/mbox/","series":[{"id":813,"url":"https://patchwork.libcamera.org/api/series/813/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=813","date":"2020-04-16T11:57:40","name":"[libcamera-devel] libcamera: Make IPA module signing mandatory for the meantime","version":1,"mbox":"https://patchwork.libcamera.org/series/813/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3472/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3472/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 676FD60403\n\tfor ;\n\tThu, 16 Apr 2020 13:57:55 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBB6B97D\n\tfor ;\n\tThu, 16 Apr 2020 13:57:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jOM/axDG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587038275;\n\tbh=Dhl6QKAjTcv0iC1aNMMj4SBM2Xr4N0Lui9vsodVgWoU=;\n\th=From:To:Subject:Date:From;\n\tb=jOM/axDGVY2+t7sfaUq+UUp5hWFwRVo3dmuT05bZ6/5jXFx65quoYMR0qVAUSz4gL\n\tQXHo+IElcIC7GUHV9E/Pz+X18bo2/tnp61OIV20c0AFI2QpEvT+L1nkXKuhmIf9L5V\n\tlrk1wqo19VgTh2y591IZ8xGcBMReMiLz389xAMss=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 16 Apr 2020 14:57:40 +0300","Message-Id":"<20200416115740.6732-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: Make IPA module signing\n\tmandatory for the meantime","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 16 Apr 2020 11:57:55 -0000"},"content":"IPA module signing is optional, but when not available due to missing\ndependencies, we hit failures due to a not fully implemented IPA\nisolation. Make module signing mandatory until isolation is functional.\n\nSigned-off-by: Laurent Pinchart \n---\n README.rst | 2 +-\n src/libcamera/meson.build | 2 +-\n src/meson.build | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/README.rst b/README.rst\nindex da3cc64966b0..40d45196c7d6 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -66,7 +66,7 @@ for documentation: [optional]\n for gstreamer: [optional]\n \tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n \n-for IPA module signing: [optional]\n+for IPA module signing: [required]\n libgnutls28-dev openssl\n \n for qcam: [optional]\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex dcd2fb4900e6..874d25904693 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -62,7 +62,7 @@ subdir('proxy')\n \n libatomic = cc.find_library('atomic', required : false)\n libdl = cc.find_library('dl')\n-libgnutls = cc.find_library('gnutls', required : false)\n+libgnutls = cc.find_library('gnutls', required : true)\n libudev = dependency('libudev', required : false)\n \n if libgnutls.found()\ndiff --git a/src/meson.build b/src/meson.build\nindex 296682758613..f605a420c3ee 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -2,7 +2,7 @@ if get_option('android')\n subdir('android')\n endif\n \n-openssl = find_program('openssl', required : false)\n+openssl = find_program('openssl', required : true)\n if openssl.found()\n ipa_gen_priv_key = find_program('ipa/gen-ipa-priv-key.sh')\n ipa_priv_key = custom_target('ipa-priv-key',\n","prefixes":["libcamera-devel"]}