{"id":3469,"url":"https://patchwork.libcamera.org/api/patches/3469/?format=json","web_url":"https://patchwork.libcamera.org/patch/3469/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200415150409.27938-3-email@uajain.com>","date":"2020-04-15T15:04:15","name":"[libcamera-devel,v2,2/2] test: log: log_api: Close open fds on error paths","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a7742046f325e27c7fe2b0cdee8964a0864b027d","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3469/mbox/","series":[{"id":811,"url":"https://patchwork.libcamera.org/api/series/811/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=811","date":"2020-04-15T15:04:13","name":"Coverity scans fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/811/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3469/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3469/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0193762E7D\n\tfor ;\n\tWed, 15 Apr 2020 17:04:16 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-xm5rk with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-xm5rk-18-5E97226F-55\n\t2020-04-15 15:04:15.66506489 +0000 UTC m=+1701644.644798356","from mail.uajain.com (unknown)\n\tby ismtpd0002p1maa1.sendgrid.net (SG) with ESMTP\n\tid YohL4mBUR4mpvsSu3QMkQw Wed, 15 Apr 2020 15:04:15.244 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"RiHcbE2A\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=yLO2Ckgnl1QQ8BefJTWsMy9vFKnYm1mlGdBdB3rsQ48=;\n\tb=RiHcbE2AMCX/4J2GX4MeG6KOQtvwol0l/LndUb7fpa4syevG98MoqSpqkWukXT9DTFzW\n\t0vk5jcHrTJss8mndB/wBiNl149rnKDgyuL0/azuPUxI/j8bxNwdj1Ysnd6lkjTorXqB1jr\n\tuoDi8XN9kLFJO9UtZwF1188/pCDUyPTfI=","From":"Umang Jain ","Date":"Wed, 15 Apr 2020 15:04:15 +0000 (UTC)","Message-Id":"<20200415150409.27938-3-email@uajain.com>","In-Reply-To":"<20200415150409.27938-1-email@uajain.com>","References":"<20200415150409.27938-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc0FyoEBOIv1fDR+9klxGaYh30+uRN54fa80X9vZwKmOrF4YaSczosUgd99f4wth7bxJ0TDP4k68merFctph844TY+q+MFM3Fqgfb1oSlZBOrwVVB8uR47xlDupPacc4k2ErWDx1QXJWcJ8a8Gk0A3+yojLQi0aSGpAR6YSIH5DxET63dCxo7Terr32gieXvvROsWiCmP9eD0bqVbgSQ8BsQ==","To":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH v2 2/2] test: log: log_api: Close open fds\n\ton error paths","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 15 Apr 2020 15:04:18 -0000"},"content":"Pointed out by Coverity DefectId=279091\n\nSigned-off-by: Umang Jain \n---\n test/log/log_api.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/test/log/log_api.cpp b/test/log/log_api.cpp\nindex 33622f8..4d2c8db 100644\n--- a/test/log/log_api.cpp\n+++ b/test/log/log_api.cpp\n@@ -86,6 +86,7 @@ protected:\n \n \t\tif (logSetFile(path) < 0) {\n \t\t\tcerr << \"Failed to set log file\" << endl;\n+\t\t\tclose(fd);\n \t\t\treturn TestFail;\n \t\t}\n \n@@ -96,6 +97,7 @@ protected:\n \t\tlseek(fd, 0, SEEK_SET);\n \t\tif (read(fd, buf, sizeof(buf)) < 0) {\n \t\t\tcerr << \"Failed to read tmp log file\" << endl;\n+\t\t\tclose(fd);\n \t\t\treturn TestFail;\n \t\t}\n \t\tclose(fd);\n","prefixes":["libcamera-devel","v2","2/2"]}