[{"id":4448,"web_url":"https://patchwork.libcamera.org/comment/4448/","msgid":"<20200414221007.GR19819@pendragon.ideasonboard.com>","date":"2020-04-14T22:10:07","subject":"Re: [libcamera-devel] [PATCH 1/3] test: list-camera: Handle error\n\ton starting the CameraManager","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Tue, Apr 14, 2020 at 07:06:57AM +0000, Umang Jain wrote:\n> Pointed out by Coverity DefectId=297074\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\nand applied to my tree. After running tests I'll push it to master.\n\n> ---\n> test/list-cameras.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/list-cameras.cpp b/test/list-cameras.cpp\n> index 55551d7..e6a407a 100644\n> --- a/test/list-cameras.cpp\n> +++ b/test/list-cameras.cpp\n> @@ -21,7 +21,10 @@ protected:\n> \tint init()\n> \t{\n> \t\tcm_ = new CameraManager();\n> -\t\tcm_->start();\n> +\t\tif (cm_->start()) {\n> +\t\t\tstd::cout << \"Failed to start camera\" << std::endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> \n> \t\treturn 0;\n> \t}","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD17D60406\n\tfor ;\n\tWed, 15 Apr 2020 00:10:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F787521;\n\tWed, 15 Apr 2020 00:10:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FvA2jg7U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1586902219;\n\tbh=AODyHRN/759KMbgQY6H9juL84Uh3pxWZqlcwmDC+4KQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FvA2jg7Up+QJ6BcGKdVIRIDIywpEuOGe9R/KJijUAmrMESun6NF0KLbTX7KzW4kQw\n\tZApZ90f/sgcyx+wPpeaDOr3P/emqKr2PcBppnsdaSOusunDAw2brp7MfIFlHJTCWyg\n\toIgBW+poRqKoRVADDfoRvJ/uGwVLgwxUz8NtMy34=","Date":"Wed, 15 Apr 2020 01:10:07 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200414221007.GR19819@pendragon.ideasonboard.com>","References":"<20200414070642.22366-1-email@uajain.com>\n\t<20200414070642.22366-2-email@uajain.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200414070642.22366-2-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] test: list-camera: Handle error\n\ton starting the CameraManager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 14 Apr 2020 22:10:20 -0000"}}]