[{"id":521,"web_url":"https://patchwork.libcamera.org/comment/521/","msgid":"<90a225c4-cb33-b70a-2321-eb9a37b7ee1e@ideasonboard.com>","date":"2019-01-23T11:13:55","subject":"Re: [libcamera-devel] [PATCH 1/4] tests: Test event dispatcher\n\tinterruption by signal","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/01/2019 08:59, Laurent Pinchart wrote:\n> Add a test to verify that the event dispatcher correctly restarts event\n> processing when interrupted by a signal. The test currently fails as\n> this feature isn't implemented.\n\nA test which fails! Yay :)\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/event-dispatcher.cpp | 73 +++++++++++++++++++++++++++++++++++++++\n> test/meson.build | 9 ++---\n> 2 files changed, 78 insertions(+), 4 deletions(-)\n> create mode 100644 test/event-dispatcher.cpp\n> \n> diff --git a/test/event-dispatcher.cpp b/test/event-dispatcher.cpp\n> new file mode 100644\n> index 000000000000..06c2657f09d6\n> --- /dev/null\n> +++ b/test/event-dispatcher.cpp\n> @@ -0,0 +1,73 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * event-dispatcher.cpp - Event dispatcher test\n> + */\n> +\n> +#include \n> +#include \n> +#include \n> +\n> +#include \n> +#include \n> +#include \n> +\n> +#include \"test.h\"\n> +\n> +using namespace std;\n> +using namespace libcamera;\n> +\n> +class EventDispatcherTest : public Test\n> +{\n> +protected:\n> +\tstatic void sigAlarmHandler(int)\n> +\t{\n> +\t\tcout << \"SIGALARM received\" << endl;\n> +\t}\n> +\n> +\tint init()\n> +\t{\n> +\t\tstruct sigaction sa = {};\n> +\t\tsa.sa_handler = &sigAlarmHandler;\n> +\t\tsigaction(SIGALRM, &sa, nullptr);\n> +\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tint run()\n> +\t{\n> +\t\tEventDispatcher *dispatcher = CameraManager::instance()->eventDispatcher();\n> +\t\tTimer timer;\n> +\n> +\t\t/* Event processing interruption by signal. */\n> +\t\tstruct timespec start;\n> +\t\tclock_gettime(CLOCK_MONOTONIC, &start);\n> +\n> +\t\ttimer.start(1000);\n> +\n> +\t\tstruct itimerval itimer = {};\n> +\t\titimer.it_value.tv_usec = 500000;\n\nI would have suggested reducing these timers but I don't think it matters.\n\nThe meson test suite executes these tests in parallel, and the longest\ntest is the timer test already.\n\ntime ninja test:\n...\n6/9 libcamera / event-dispatcher OK 1.52 s\n...\n9/9 libcamera / timer OK 8.12 s\n...\nreal 0m8.488s\n\nThe full duration of running the tests is not much longer than the\nlongest test, so we're good.\n\n\n> +\t\tsetitimer(ITIMER_REAL, &itimer, nullptr);\n> +\n> +\t\tdispatcher->processEvents();\n> +\n> +\t\tstruct timespec stop;\n> +\t\tclock_gettime(CLOCK_MONOTONIC, &stop);\n> +\t\tint duration = (stop.tv_sec - start.tv_sec) * 1000;\n> +\t\tduration += (stop.tv_nsec - start.tv_nsec) / 1000000;\n> +\n> +\t\tif (abs(duration - 1000) > 50) {\n> +\t\t\tcout << \"Event processing restart test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\treturn TestPass;\n> +\t}\n> +\n> +\tvoid cleanup()\n> +\t{\n> +\t}\n> +};\n> +\n> +TEST_REGISTER(EventDispatcherTest)\n> diff --git a/test/meson.build b/test/meson.build\n> index 8cdcae2c9e87..d515a716207e 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -5,10 +5,11 @@ subdir('pipeline')\n> subdir('v4l2_device')\n> \n> public_tests = [\n> - ['event', 'event.cpp'],\n> - ['list-cameras', 'list-cameras.cpp'],\n> - ['signal', 'signal.cpp'],\n> - ['timer', 'timer.cpp'],\n> + ['event', 'event.cpp'],\n> + ['event-dispatcher', 'event-dispatcher.cpp'],\n> + ['list-cameras', 'list-cameras.cpp'],\n> + ['signal', 'signal.cpp'],\n> + ['timer', 'timer.cpp'],\n\nAhh - my pre-allocation of tables was not enough ...\n\nThis should last a bit longer...\n\n\n> ]\n> \n> internal_tests = [\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B6E660C7D\n\tfor ;\n\tWed, 23 Jan 2019 12:13:59 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA28723D;\n\tWed, 23 Jan 2019 12:13:58 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548242038;\n\tbh=mSDk0U7lPXIxF9hiQD37LYKDRKXAigvBjkn9xl1W6l8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=QT6otCQ0J6alneWUOFezRl0IO9lBJublM7eGjBUOc96EDTtXrpC7HSnCUKNa/RrSI\n\thbiLVm6dlEIP/ytjsiNN6joMmMpqOOqi1+0n2ESdsS41kPNWIADugRL/zJkp/qr8yy\n\t+S9acr8WvhRBX+G5LFHMIsAstC1gOX5oGTOrtFCg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190123085923.12524-1-laurent.pinchart@ideasonboard.com>\n\t<20190123085923.12524-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<90a225c4-cb33-b70a-2321-eb9a37b7ee1e@ideasonboard.com>","Date":"Wed, 23 Jan 2019 11:13:55 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190123085923.12524-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 1/4] tests: Test event dispatcher\n\tinterruption by signal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 23 Jan 2019 11:13:59 -0000"}}]