{"id":3432,"url":"https://patchwork.libcamera.org/api/patches/3432/?format=json","web_url":"https://patchwork.libcamera.org/patch/3432/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200413104631.12276-4-email@uajain.com>","date":"2020-04-13T10:46:53","name":"[libcamera-devel,3/4] test: log: log_api: Close open fds on error paths","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bf500aabdf2051eb446bb62d2626cc451141d096","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3432/mbox/","series":[{"id":803,"url":"https://patchwork.libcamera.org/api/series/803/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=803","date":"2020-04-13T10:46:34","name":"Fix resource leaks pointed out by coverity scans","version":1,"mbox":"https://patchwork.libcamera.org/series/803/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3432/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3432/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4055A62826\n\tfor ;\n\tMon, 13 Apr 2020 12:46:55 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-xn4j7 with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-xn4j7-19-5E94431D-4E\n\t2020-04-13 10:46:53.970656372 +0000 UTC m=+1589960.232487496","from mail.uajain.com (unknown)\n\tby ismtpd0003p1maa1.sendgrid.net (SG) with ESMTP\n\tid pBCBNRobS1WWPUlJ5XCRAQ Mon, 13 Apr 2020 10:46:53.546 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"sOylzT+u\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=lN5t0qg8HDzYt647wu399qU8mdOYbLlm40/6lHf9K4M=;\n\tb=sOylzT+uQ8DzJXoOXDewWwkkLEbDRQmHP6dxwlVYC6Ib61sPq04JRyQZWdz7RoI7h47D\n\tFpXYCkMdpFiMRWzhsLnW8tTShIKdhPnY//TiRRtKST9CitFl28BxjOQrt6SIDXxFwt6vHF\n\tj7hmxtDsZJdAz4sZ0GHRJ1oQ5QSUnp7Bs=","From":"Umang Jain ","Date":"Mon, 13 Apr 2020 10:46:53 +0000 (UTC)","Message-Id":"<20200413104631.12276-4-email@uajain.com>","In-Reply-To":"<20200413104631.12276-1-email@uajain.com>","References":"<20200413104631.12276-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc/mSirh79xX0l6HRHZb2eYA0RzoWaZc/nZ9Udko5MldTi0ZsdsFe5G+ye+/UjefY0wCezfshHodjSd9PWgoKnbrFFFjQtb8Bm8oTEbA1lVfl04A9DeEThI8P04m+SDVdK9RH1x+gGuI+HjwSAO3CUOV6+y4pMN1TEls+C7pevfKRutLTuMGuO1D5zWsJcn9j/dYQztw8mVrqMyoqdNJ1DTA==","To":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH 3/4] test: log: log_api: Close open fds on\n\terror paths","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 13 Apr 2020 10:46:55 -0000"},"content":"Pointed out by Coverity DefectId=279091\n\nSigned-off-by: Umang Jain \n---\n test/log/log_api.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/test/log/log_api.cpp b/test/log/log_api.cpp\nindex 33622f8..aeedbf9 100644\n--- a/test/log/log_api.cpp\n+++ b/test/log/log_api.cpp\n@@ -96,6 +96,7 @@ protected:\n \t\tlseek(fd, 0, SEEK_SET);\n \t\tif (read(fd, buf, sizeof(buf)) < 0) {\n \t\t\tcerr << \"Failed to read tmp log file\" << endl;\n+\t\t\tclose(fd);\n \t\t\treturn TestFail;\n \t\t}\n \t\tclose(fd);\n","prefixes":["libcamera-devel","3/4"]}