{"id":3430,"url":"https://patchwork.libcamera.org/api/patches/3430/?format=json","web_url":"https://patchwork.libcamera.org/patch/3430/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200413104631.12276-2-email@uajain.com>","date":"2020-04-13T10:46:51","name":"[libcamera-devel,1/4] test: ipc: unixsocket: Close open fds on error paths","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a265df6225f0e386036420a0c212c554000a1dc9","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3430/mbox/","series":[{"id":803,"url":"https://patchwork.libcamera.org/api/series/803/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=803","date":"2020-04-13T10:46:34","name":"Fix resource leaks pointed out by coverity scans","version":1,"mbox":"https://patchwork.libcamera.org/series/803/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3430/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3430/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A0CED6279B\n\tfor ;\n\tMon, 13 Apr 2020 12:46:52 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-w5zgs with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-w5zgs-17-5E94431A-43\n\t2020-04-13 10:46:51.137941207 +0000 UTC m=+1589965.432268828","from mail.uajain.com (unknown)\n\tby ismtpd0008p1maa1.sendgrid.net (SG) with ESMTP\n\tid rXvBFzRsR9qGz3Ae-Nr7xw Mon, 13 Apr 2020 10:46:50.374 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"yjb5j75B\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=Y03Ll6yzLr1iyJPFMtkLojTteG6/i02TnsXQjRnuus8=;\n\tb=yjb5j75BBJbv5cQpnEAk/TLQ9J1jQa+Z27gISA2gwBRkLGKnAMByyoo+YHYAK3+ihVUq\n\t1dHeI+f/ZHWlzIN9k6jJe1SNqP4sfo+F4LQvMXOman+5OEm8HpSIR1zxVy6vzxySvBZPn1\n\t8wWU6+E1Fyyk/KeirvEmdxn4Uae4/WSFc=","From":"Umang Jain ","Date":"Mon, 13 Apr 2020 10:46:51 +0000 (UTC)","Message-Id":"<20200413104631.12276-2-email@uajain.com>","In-Reply-To":"<20200413104631.12276-1-email@uajain.com>","References":"<20200413104631.12276-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcIgOyDPOiX995eQdp4XFd3IZu5+c97D8x47w6im9u3eJmzXBdYWObWYD7xrkJRveqCVzi+AY+njAWbDzk+QB8hB1LzWzudFaQ2wEm7/UDmyxHMrmX5lW9n/OeuLDxxnyEqQ/LsPSE9XmZhklGKPC06avxeWc/2vXXY92VUHEhDyxAuUCAX1H16e5XY2Ys21ik6KW7dZwv1P2X9G83Chlprw==","To":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH 1/4] test: ipc: unixsocket: Close open fds\n\ton error paths","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 13 Apr 2020 10:46:53 -0000"},"content":"Pointed out by Coverity DefectId=279099\n\nSigned-off-by: Umang Jain \n---\n test/ipc/unixsocket.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp\nindex f53042b..5348f35 100644\n--- a/test/ipc/unixsocket.cpp\n+++ b/test/ipc/unixsocket.cpp\n@@ -145,6 +145,7 @@ private:\n \n \t\t\t\t\tif (num < 0) {\n \t\t\t\t\t\tcerr << \"Read failed\" << endl;\n+\t\t\t\t\t\tclose(outfd);\n \t\t\t\t\t\tstop(-EIO);\n \t\t\t\t\t\treturn;\n \t\t\t\t\t} else if (!num)\n@@ -152,6 +153,7 @@ private:\n \n \t\t\t\t\tif (write(outfd, buf, num) < 0) {\n \t\t\t\t\t\tcerr << \"Write failed\" << endl;\n+\t\t\t\t\t\tclose(outfd);\n \t\t\t\t\t\tstop(-EIO);\n \t\t\t\t\t\treturn;\n \t\t\t\t\t}\n","prefixes":["libcamera-devel","1/4"]}