{"id":3426,"url":"https://patchwork.libcamera.org/api/patches/3426/?format=json","web_url":"https://patchwork.libcamera.org/patch/3426/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200411001911.1143155-6-niklas.soderlund@ragnatech.se>","date":"2020-04-11T00:19:09","name":"[libcamera-devel,v3,5/7] libcamera: pipeline: rkisp1: Call IPA start() and stop()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6ee4a79ed38d70c74f1d44d88b1bf2042e58fbc3","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3426/mbox/","series":[{"id":802,"url":"https://patchwork.libcamera.org/api/series/802/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=802","date":"2020-04-11T00:19:04","name":"libcamera: ipa_manager: Proxy open-source IPAs to a thread","version":3,"mbox":"https://patchwork.libcamera.org/series/802/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3426/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3426/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEDAC62D33\n\tfor ;\n\tSat, 11 Apr 2020 02:19:23 +0200 (CEST)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 145bbb19-7b8a-11ea-aeed-005056917f90;\n\tSat, 11 Apr 2020 02:19:16 +0200 (CEST)"],"X-Halon-ID":"145bbb19-7b8a-11ea-aeed-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 11 Apr 2020 02:19:09 +0200","Message-Id":"<20200411001911.1143155-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.26.0","In-Reply-To":"<20200411001911.1143155-1-niklas.soderlund@ragnatech.se>","References":"<20200411001911.1143155-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 5/7] libcamera: pipeline: rkisp1: Call\n\tIPA start() and stop()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 Apr 2020 00:19:24 -0000"},"content":"Call the IPA start()/stop() functions before/after the camera is\nstarted. This makes sure the IPA functions properly once thread\nmanagement is moved into the start/stop interface.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex daf84b5ac129efc8..118b29f0df64a003 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -764,10 +764,19 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \tif (ret)\n \t\treturn ret;\n \n+\tret = data->ipa_->start();\n+\tif (ret) {\n+\t\tfreeBuffers(camera);\n+\t\tLOG(RkISP1, Error)\n+\t\t\t<< \"Failed to start IPA \" << camera->name();\n+\t\treturn ret;\n+\t}\n+\n \tdata->frame_ = 0;\n \n \tret = param_->streamOn();\n \tif (ret) {\n+\t\tdata->ipa_->stop();\n \t\tfreeBuffers(camera);\n \t\tLOG(RkISP1, Error)\n \t\t\t<< \"Failed to start parameters \" << camera->name();\n@@ -777,6 +786,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \tret = stat_->streamOn();\n \tif (ret) {\n \t\tparam_->streamOff();\n+\t\tdata->ipa_->stop();\n \t\tfreeBuffers(camera);\n \t\tLOG(RkISP1, Error)\n \t\t\t<< \"Failed to start statistics \" << camera->name();\n@@ -787,6 +797,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n \tif (ret) {\n \t\tparam_->streamOff();\n \t\tstat_->streamOff();\n+\t\tdata->ipa_->stop();\n \t\tfreeBuffers(camera);\n \n \t\tLOG(RkISP1, Error)\n@@ -830,6 +841,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera)\n \t\tLOG(RkISP1, Warning)\n \t\t\t<< \"Failed to stop parameters \" << camera->name();\n \n+\tdata->ipa_->stop();\n+\n \tdata->timeline_.reset();\n \n \tfreeBuffers(camera);\n","prefixes":["libcamera-devel","v3","5/7"]}