{"id":3424,"url":"https://patchwork.libcamera.org/api/patches/3424/?format=json","web_url":"https://patchwork.libcamera.org/patch/3424/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200411001911.1143155-4-niklas.soderlund@ragnatech.se>","date":"2020-04-11T00:19:07","name":"[libcamera-devel,v3,3/7] libcamera: pipeline: rkisp1: Initialize IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b7a1769b5fadf46145e1d8faaec30d43a0a67de5","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3424/mbox/","series":[{"id":802,"url":"https://patchwork.libcamera.org/api/series/802/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=802","date":"2020-04-11T00:19:04","name":"libcamera: ipa_manager: Proxy open-source IPAs to a thread","version":3,"mbox":"https://patchwork.libcamera.org/series/802/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3424/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3424/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5A5C6277E\n\tfor ;\n\tSat, 11 Apr 2020 02:19:22 +0200 (CEST)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 13bbb5d0-7b8a-11ea-aeed-005056917f90;\n\tSat, 11 Apr 2020 02:19:15 +0200 (CEST)"],"X-Halon-ID":"13bbb5d0-7b8a-11ea-aeed-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 11 Apr 2020 02:19:07 +0200","Message-Id":"<20200411001911.1143155-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.26.0","In-Reply-To":"<20200411001911.1143155-1-niklas.soderlund@ragnatech.se>","References":"<20200411001911.1143155-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 3/7] libcamera: pipeline: rkisp1:\n\tInitialize IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 Apr 2020 00:19:23 -0000"},"content":"The IPA init() call is a no-op in the current IPA, but it's part of the\nIPA API and it should be called.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 3d37677fb433833a..de90615edf217cca 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -386,6 +386,8 @@ int RkISP1CameraData::loadIPA()\n \tipa_->queueFrameAction.connect(this,\n \t\t\t\t &RkISP1CameraData::queueFrameAction);\n \n+\tipa_->init();\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","v3","3/7"]}