[{"id":4401,"web_url":"https://patchwork.libcamera.org/comment/4401/","msgid":"<20200407203957.GQ1716317@oden.dyn.berto.se>","date":"2020-04-07T20:39:57","subject":"Re: [libcamera-devel] [PATCH 11/11] libcamera: ipa: Remove\n\tIPAModuleInfo license field","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-04-04 04:56:24 +0300, Laurent Pinchart wrote:\n> The IPAModuleInfo license field isn't needed anymore now that modules\n> are cryptographically signed. Remove it.\n> \n> Signed-off-by: Laurent Pinchart \n\nI like how this saves us from keeping an up-to-date list with licences \nthat are open enough to be trusted to run without isolation.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/ipa/ipa_module_info.h | 1 -\n> src/ipa/rkisp1/rkisp1.cpp | 1 -\n> src/ipa/vimc/meson.build | 3 +--\n> src/ipa/vimc/vimc.cpp | 1 -\n> src/libcamera/ipa_module.cpp | 21 ---------------------\n> test/ipa/ipa_module_test.cpp | 1 -\n> 6 files changed, 1 insertion(+), 27 deletions(-)\n> \n> diff --git a/include/ipa/ipa_module_info.h b/include/ipa/ipa_module_info.h\n> index 7ecd149566be..3b1c37d2a7f1 100644\n> --- a/include/ipa/ipa_module_info.h\n> +++ b/include/ipa/ipa_module_info.h\n> @@ -18,7 +18,6 @@ struct IPAModuleInfo {\n> \tuint32_t pipelineVersion;\n> \tchar pipelineName[256];\n> \tchar name[256];\n> -\tchar license[64];\n> } __attribute__((packed));\n> \n> extern \"C\" {\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 438b3c66f77a..ffa7191ba21e 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -273,7 +273,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n> \t1,\n> \t\"PipelineHandlerRkISP1\",\n> \t\"RkISP1 IPA\",\n> -\t\"LGPL-2.1-or-later\",\n> };\n> \n> struct ipa_context *ipaCreate()\n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index 3097a12f964a..3c932aa7aaad 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -7,8 +7,7 @@ mod = shared_module(ipa_name,\n> dependencies : libcamera_dep,\n> link_with : libipa,\n> install : true,\n> - install_dir : ipa_install_dir,\n> - cpp_args : '-DLICENSE=\"LGPL-2.1-or-later\"')\n> + install_dir : ipa_install_dir)\n> \n> custom_target(ipa_name + '.so.sign',\n> input : mod,\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 6e2095b56bbc..b11d42c57696 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -107,7 +107,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n> \t0,\n> \t\"PipelineHandlerVimc\",\n> \t\"Dummy IPA for Vimc\",\n> -\tLICENSE,\n> };\n> \n> struct ipa_context *ipaCreate()\n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 96b44f13192c..958ede74688e 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -216,27 +216,6 @@ Span elfLoadSymbol(Span elf, const char *symbol)\n> * \\var IPAModuleInfo::name\n> * \\brief The name of the IPA module\n> *\n> - * \\var IPAModuleInfo::license\n> - * \\brief License of the IPA module\n> - *\n> - * This license is used to determine whether to force isolation of the IPA in\n> - * a separate process. If the license is \"Proprietary\", then the IPA will\n> - * be isolated. If the license is open-source, then the IPA will be allowed to\n> - * run without isolation if the user enables it. The license should be an\n> - * SPDX license string. The following licenses are currently available to\n> - * allow the IPA to run unisolated:\n> - *\n> - * - GPL-2.0-only\n> - * - GPL-2.0-or-later\n> - * - GPL-3.0-only\n> - * - GPL-3.0-or-later\n> - * - LGPL-2.1-only\n> - * - LGPL-2.1-or-later\n> - * - LGPL-3.0-only\n> - * - LGPL-3.0-or-later\n> - *\n> - * Any other license will cause the IPA to be run isolated.\n> - *\n> * \\todo Allow user to choose to isolate open source IPAs\n> */\n> \n> diff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp\n> index 287e53fdaa8e..d22c302fa726 100644\n> --- a/test/ipa/ipa_module_test.cpp\n> +++ b/test/ipa/ipa_module_test.cpp\n> @@ -59,7 +59,6 @@ protected:\n> \t\t\t0,\n> \t\t\t\"PipelineHandlerVimc\",\n> \t\t\t\"Dummy IPA for Vimc\",\n> -\t\t\t\"GPL-2.0-or-later\",\n> \t\t};\n> \n> \t\tcount += runTest(\"src/ipa/vimc/ipa_vimc.so\", testInfo);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x229.google.com (mail-lj1-x229.google.com\n\t[IPv6:2a00:1450:4864:20::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6473600F0\n\tfor ;\n\tTue, 7 Apr 2020 22:39:58 +0200 (CEST)","by mail-lj1-x229.google.com with SMTP id k21so5305917ljh.2\n\tfor ;\n\tTue, 07 Apr 2020 13:39:58 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tv3sm1491859lfo.62.2020.04.07.13.39.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Apr 2020 13:39:57 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"hRq4UKJ0\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=J35u3f1TFfXGlNRNUWrRr770nrtPBCBXmNENZS5nFA0=;\n\tb=hRq4UKJ0Wyay61xwFg8TTbNuUSIpoy+NiA863UW9kpXdEjqUrtQJgwYXpLkysbG6nW\n\tlgeQ7QV6O+TzAAwCGdQUx1+mQojyEhaKIm+9cO/qpt0FKnw1LwqqGPkmh16RwL4s+aqP\n\tY9n1+LmZOLp6Z+/JvhWE5USopI01adHO9Lm8FY/Qjg3Dtx6mmqaMQrrMyHQohk+IDKmX\n\tI2VE0zRlHcMqxQvl/4Qs/inV8zbEvRF/XpHXHFItjyfgP9PRRz7FJpCMrytTe9DHc3PY\n\t2PBeWhPFlN1qYZj/Mqbu85/vxo0MlwyYIMCQmrrNMA1e/YzR76fO6otjB8Y1fxu7UM7Q\n\tVDzQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=J35u3f1TFfXGlNRNUWrRr770nrtPBCBXmNENZS5nFA0=;\n\tb=S8TDyNe6tRoATFfb602u9/Py4hbokqzIrDtS5JcksHEedXWsSHNV3gNGNnvDc2+2Fh\n\t8+7TVBpvbYk5PoweGB+wRBFwjJGwQw2ass9ioUXiu0Y3kG0XNDs81vguhWmGs7eqNa3X\n\tJVxWFLfnKlBg8l9yvHCnGep9nXRUWmVQsS/qW2+SPbE8M/m2JaywZI2V1QavZLddgh9R\n\ttb0N2RXcrd+iInugUYO+QkkTYV6a+cFr1JCCaPtbQq8r/+6Sp8s/uCrG4pmia28vZWC6\n\tjM4xJ9CIiNeP8hjd1Y5uDGPSpBY2JlVtvBXiz+hFJ1vRl6z+IRk1mOVTlJyd9H5VcRqo\n\tdZrg==","X-Gm-Message-State":"AGi0Pualv/4MRZ8c+EYXCxIdSSm5pAHXOZY6GEO4Lqw60LA0z3UHx6IB\n\tKVPHPJ36OjT4njaBhCPk5m2G3KTlvkk=","X-Google-Smtp-Source":"APiQypLCXGtRbTL2uZ7iQcjUCvEIXZFpoTSIVCvsh81V+boYhQX6t08g2pBC1Plr4s6rw8XsQQ63oQ==","X-Received":"by 2002:a2e:a310:: with SMTP id\n\tl16mr2908099lje.255.1586291998253; \n\tTue, 07 Apr 2020 13:39:58 -0700 (PDT)","Date":"Tue, 7 Apr 2020 22:39:57 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200407203957.GQ1716317@oden.dyn.berto.se>","References":"<20200404015624.30440-1-laurent.pinchart@ideasonboard.com>\n\t<20200404015624.30440-12-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200404015624.30440-12-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 11/11] libcamera: ipa: Remove\n\tIPAModuleInfo license field","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Apr 2020 20:39:59 -0000"}}]