[{"id":4391,"web_url":"https://patchwork.libcamera.org/comment/4391/","msgid":"<20200407124640.GD1716317@oden.dyn.berto.se>","date":"2020-04-07T12:46:40","subject":"Re: [libcamera-devel] [PATCH 01/11] ipa: vimc: Remove isolated VIMC\n\tIPA module","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-04-04 04:56:14 +0300, Laurent Pinchart wrote:\n> The isolated VIMC module isn't used in any test. Remove it to prepare\n> for the rework of IPA module isolation. The feature can be added back\n> later alongside corresponding tests if needed.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/ipa/vimc/meson.build | 23 ++++++++---------------\n> 1 file changed, 8 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index 435c7d3160be..e827e75f9f91 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -1,15 +1,8 @@\n> -ipa_vimc_sources = [\n> - ['ipa_vimc', 'LGPL-2.1-or-later'],\n> - ['ipa_vimc_isolate', 'Proprietary'],\n> -]\n> -\n> -foreach t : ipa_vimc_sources\n> - ipa = shared_module(t[0], 'vimc.cpp',\n> - name_prefix : '',\n> - include_directories : [ipa_includes, libipa_includes],\n> - dependencies : libcamera_dep,\n> - link_with : libipa,\n> - install : true,\n> - install_dir : ipa_install_dir,\n> - cpp_args : '-DLICENSE=\"' + t[1] + '\"')\n> -endforeach\n> +ipa = shared_module('ipa_vimc', 'vimc.cpp',\n> + name_prefix : '',\n> + include_directories : [ipa_includes, libipa_includes],\n> + dependencies : libcamera_dep,\n> + link_with : libipa,\n> + install : true,\n> + install_dir : ipa_install_dir,\n> + cpp_args : '-DLICENSE=\"LGPL-2.1-or-later\"')\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29036600F0\n\tfor ;\n\tTue, 7 Apr 2020 14:46:43 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id f8so2217969lfe.12\n\tfor ;\n\tTue, 07 Apr 2020 05:46:43 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tw72sm12958870lff.56.2020.04.07.05.46.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Apr 2020 05:46:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"PGSWluNm\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=HFUxX1gFacfLA2Z2VpQcQyQ1boLWpgxyunj31Tb/sy4=;\n\tb=PGSWluNmE79rSmx/3vqXBTcemS9vRrLHYVdXZYKQVbSIzKD0EE4WjC/n/PBG5zBcLd\n\tv0v310kJDwBiKYXaJ5Vau2IgEu2/XLQwzuwgHZ/5qrijBPJsSBJTKWnmyKp5T29P5Myb\n\ttkecBkxRQGNehdo0Rox3HllWt2NXpLMVwW8wki14VyWwrELp5GfTpbQ4dbTB9idwghnX\n\tUS75PRxGlc6YBZWtmhMJsOo02B7M6mbyBfvscU7Tjz4Jd96RgaX+xrt7b8MFGmenI5En\n\t5uR9Gz27WGTxApNHwQq4Zdqitti4zsCWMLafB7yy46uKiKjrkMlv3cbbJ70OivH0edqj\n\tWB3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=HFUxX1gFacfLA2Z2VpQcQyQ1boLWpgxyunj31Tb/sy4=;\n\tb=liluMczoeXoEbFych/1zHI39eJuLUz+LXdoNPwehJRBnFl6uRwGCqEqQ8MfzByq2Nm\n\t3pVjkonAJM1OAA4Yt7xAozyZGO9ZSgTLxJh1XpirXJ/Adu/jP4+6AJJyj0JwA4HhoYHX\n\twMlSILsFXOJEm5sfPYZlWdxEHxkaWFKAiwXxPfHNaXEqqA16B7L0Pc6s/wQlPhrTNOca\n\tjRNxY4Er0yk6/FBhr+Xu6AujGHylaF+I8DYhVAOQoTXCOZ5zbeLeL/mO5+4s6SJUQuYP\n\tScCOm5z4hB4qrQnloaf6+OENBB5fA2UeV/qEBTQ87MQcinUxHyQtwEdzIu8eRwLN+swk\n\tk3Ig==","X-Gm-Message-State":"AGi0PubjQ2VnRTYvOxCuMblgWc1U810dQoMeICDX4/+c00UdAMOB6tAb\n\tispGwAU/yHOHQkX+yInK5KppPCPS8v8=","X-Google-Smtp-Source":"APiQypLpsG73MpwGK5fDiOl9v5+skkWlVPWj7NkQ0gSQ6C6bGj59uHirOWkVK+o8i7mCM3aMFuyArA==","X-Received":"by 2002:a19:4843:: with SMTP id\n\tv64mr1428796lfa.155.1586263602432; \n\tTue, 07 Apr 2020 05:46:42 -0700 (PDT)","Date":"Tue, 7 Apr 2020 14:46:40 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200407124640.GD1716317@oden.dyn.berto.se>","References":"<20200404015624.30440-1-laurent.pinchart@ideasonboard.com>\n\t<20200404015624.30440-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200404015624.30440-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 01/11] ipa: vimc: Remove isolated VIMC\n\tIPA module","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Apr 2020 12:46:43 -0000"}}]