[{"id":4417,"web_url":"https://patchwork.libcamera.org/comment/4417/","msgid":"<20200407234022.GG1716317@oden.dyn.berto.se>","date":"2020-04-07T23:40:22","subject":"Re: [libcamera-devel] [PATCH v4 08/11] libcamera: v4l2_videodevice:\n\tMap V4L2_PIX_FMT_GREY to DRM FourCC","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-04-04 03:44:35 +0300, Laurent Pinchart wrote:\n> DRM has a format for 8-bit greyscale data, DRM_FORMAT_R8. Despite the\n> 'R' name, which comes from GL/Vulkan to mean single-channel data, the\n> format maps to greyscale for display. We can thus map it to\n> V4L2_PIX_FMT_GREY.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Changes since v2:\n> \n> - Rebase on top of PixelFormat class\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 5208e5a47148..437e771d7fe4 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1699,12 +1699,15 @@ PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n> \tcase V4L2_PIX_FMT_NV21M:\n> \t\treturn PixelFormat(DRM_FORMAT_NV21);\n> \n> +\t/* Greyscale formats. */\n> +\tcase V4L2_PIX_FMT_GREY:\n> +\t\treturn PixelFormat(DRM_FORMAT_R8);\n> +\n> \t/* Compressed formats. */\n> \tcase V4L2_PIX_FMT_MJPEG:\n> \t\treturn PixelFormat(DRM_FORMAT_MJPEG);\n> \n> \t/* V4L2 formats not yet supported by DRM. */\n> -\tcase V4L2_PIX_FMT_GREY:\n> \tdefault:\n> \t\t/*\n> \t\t * \\todo We can't use LOG() in a static method of a Loggable\n> @@ -1790,6 +1793,10 @@ V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelForma\n> \tcase DRM_FORMAT_NV21:\n> \t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV21);\n> \n> +\t/* Greyscale formats. */\n> +\tcase DRM_FORMAT_R8:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_GREY);\n> +\n> \t/* Compressed formats. */\n> \tcase DRM_FORMAT_MJPEG:\n> \t\treturn V4L2PixelFormat(V4L2_PIX_FMT_MJPEG);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2EE0E600F3\n\tfor ;\n\tWed, 8 Apr 2020 01:40:24 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id p10so5688009ljn.1\n\tfor ;\n\tTue, 07 Apr 2020 16:40:24 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tr206sm6941994lff.65.2020.04.07.16.40.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Apr 2020 16:40:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"oO4TWG6+\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=bX6qC0Pz4rXgFYGPQx4xedGsjeswsbfDv4Dp06NLTjk=;\n\tb=oO4TWG6+Gust4NkJ9+GKyr5FAGwU+/Mduz+dn5S7EcLT1GTB5QZLlDZtB8V93c06XL\n\tN5vevT2tgsG8tMn6lgh5TjIXXfozMo5H8u8iTirBt7HOhHu0QISoQMfBu6sGEman1l4u\n\tdk1Jungzbz1SqZ1FRYTVgE5c5vurbOzrRJesLWy67GEk+vwcusvCkPK5N07BvqPFcSqQ\n\tDRtqedHA+8aRbV471D6JvWSnaSeL56wNOv46e9s7YWlGaQTICNVPmWKtYSIHI9FN0mMO\n\tH3WNZyAp0pTUjkE2uF2zF5pV9YBv0fBmsQQjKZwl9neILNoePZebjskjRqucx2GUjLFt\n\tsabA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=bX6qC0Pz4rXgFYGPQx4xedGsjeswsbfDv4Dp06NLTjk=;\n\tb=E/CL4GkLlVBiVxDdq1cCc43D9WFaSKS0Lt1xGwlxeszDcf+8QwDeWNyjoq3P7Zik+c\n\tDPF46C9tgtzEGpc0H/AJBqYSdNnVdvRhePUihUOP1p0uZZ68lHcn7KU7eDyVAEe6CoTp\n\t6hZuGFnQIf0SKXiEIQWjoAf7TPvtXQWLB5HKqUjl+OU4Xe1DcMJlWd7TK8I+NLJZwZfA\n\t6s3Ut1z66y2Hq5PeAOW+DRnldowxUbnRYk1hFtwPKv1OBZKtVJcvy4rgMZCVR9Q7LL3+\n\tEGbptdZbij+C56Waj71ecYRg1Lf1Z3lRFfI43JLyTNBwI4wJfKJ7XWVEogT6yK3mOx94\n\t3rNg==","X-Gm-Message-State":"AGi0PuaWiwZAMC9GkJapgtM+5R7zamTv0c2E4qZ2q7HY5FB3AcntBCOi\n\t+bmiBxOAbjQv//Cj5/nJUv4jfA==","X-Google-Smtp-Source":"APiQypJjgwUcXUyZTMpD+lEtGvmbqSSbLubvGbnq0INN7LVNqrt+XkNqq2ryimI9qWfwBfe0t2rI9w==","X-Received":"by 2002:a2e:b80d:: with SMTP id\n\tu13mr3158264ljo.166.1586302823537; \n\tTue, 07 Apr 2020 16:40:23 -0700 (PDT)","Date":"Wed, 8 Apr 2020 01:40:22 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Martijn Braam , \n\tBenjamin GAIGNARD ","Message-ID":"<20200407234022.GG1716317@oden.dyn.berto.se>","References":"<20200404004438.17992-1-laurent.pinchart@ideasonboard.com>\n\t<20200404004438.17992-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200404004438.17992-9-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 08/11] libcamera: v4l2_videodevice:\n\tMap V4L2_PIX_FMT_GREY to DRM FourCC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Apr 2020 23:40:24 -0000"}}]