[{"id":4416,"web_url":"https://patchwork.libcamera.org/comment/4416/","msgid":"<20200407233937.GF1716317@oden.dyn.berto.se>","date":"2020-04-07T23:39:37","subject":"Re: [libcamera-devel] [PATCH v4 07/11] libcamera: v4l2_videodevice:\n\tDowngrade 4CC conversion errors to warnings","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-04-04 03:44:34 +0300, Laurent Pinchart wrote:\n> Failing to convert between V4L2 and DRM 4CCs indicates something is\n> likely wrong, but doesn't necessarily prevent the camera from being\n> usable. It may for instance only limit the number of supported formats.\n> Downgrade the related log messages from LogError to LogWarning.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 42b6c1ed1ef8..5208e5a47148 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1711,7 +1711,7 @@ PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n> \t\t * class. Until we fix the logger, work around it.\n> \t\t */\n> \t\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n> -\t\t\t\tLogError).stream()\n> +\t\t\t\tLogWarning).stream()\n> \t\t\t<< \"Unsupported V4L2 pixel format \"\n> \t\t\t<< v4l2Fourcc.toString();\n> \t\treturn PixelFormat();\n> @@ -1799,7 +1799,8 @@ V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelForma\n> \t * \\todo We can't use LOG() in a static method of a Loggable\n> \t * class. Until we fix the logger, work around it.\n> \t */\n> -\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(), LogError).stream()\n> +\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n> +\t\t\tLogWarning).stream()\n> \t\t<< \"Unsupported V4L2 pixel format \" << pixelFormat.toString();\n> \treturn {};\n> }\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F3A5600F3\n\tfor ;\n\tWed, 8 Apr 2020 01:39:39 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id z26so1533987ljz.11\n\tfor ;\n\tTue, 07 Apr 2020 16:39:39 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\ta22sm12394366ljm.28.2020.04.07.16.39.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Apr 2020 16:39:37 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"JnaaBsZo\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=KzUus7puIJKppwDV3SBNOcscS9/gIiaGwmjxlFM3IvM=;\n\tb=JnaaBsZoRRpQFSG2mq11yg9LymHoy5G6We6trVTa8J6Upu5lHjnPg1zFnqEBKXalhn\n\t6/g8/bJ1RDZ8YMLBa6BqsoCuudekNtvSTBBrXy4symCAZWk+VvqBGUDx97a+/4SDndiP\n\tIhgznNbIF91UWriv6IxdVoTqjMcocD6SMQnxjupmwpBttqGsLyQ6oGb6tyc185nZMsjn\n\t4RxRUBZv1jISTFFrWXvAjHrGUwgr5G9xgkAcsU/LunOWMvl4COSfcoWYz4BQOgXRCrzh\n\txD4XCLfaPQ+uPspbz7+FReGvh0H64jxYX5QAkqa4ASPZbnXTOLa4g5Bpq1GOoJC3eZoD\n\tGDaA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=KzUus7puIJKppwDV3SBNOcscS9/gIiaGwmjxlFM3IvM=;\n\tb=RqmCERG4/FcxWTCidQ8iGLV0g/ag6f8K2AI8K1D/dMyW30IRCZbPgS+4IAuID0Jaky\n\tUL+P+D03lJtUi7LLRy/YIT/bEaw3yYq0UBxdKiTZc93XTZ+Q51H/KGLUQGCaWEjOPnez\n\tA+JuR/xPETDYi3K4BXRfzP93/yn4ytORxaz4eeM/4WNwW7BiOzssrkwx88Nd8uuM2hTs\n\tyNKAeu/xiSDtghTV9EKVCsGmAUHnE7EUyMlPkOBXpG2+ZuVLU31SRWnncBzL+bZgmnPT\n\trE+PYybM1vyxiA1kDvKArgHHEHSYdOF+4MBBdndfscMgx5QvEczqq4OGUztOI4qeamSx\n\toUXA==","X-Gm-Message-State":"AGi0PuZK1iKVLhBQqNEwMzCkwxk2cXmwhyUi/RgTpwJsVrvEmoOBOKup\n\tvAVuG8OfepQht1GwHhs4j0fDnQ==","X-Google-Smtp-Source":"APiQypJ3CTrRiow/TJI2dAtbgZAKmJsRN5xNxIJm7mWDKYdHMRWhtanrXS7BzilCEEpmUJ4o0NhSkw==","X-Received":"by 2002:a2e:b4cb:: with SMTP id\n\tr11mr3220432ljm.201.1586302778770; \n\tTue, 07 Apr 2020 16:39:38 -0700 (PDT)","Date":"Wed, 8 Apr 2020 01:39:37 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Martijn Braam , \n\tBenjamin GAIGNARD ","Message-ID":"<20200407233937.GF1716317@oden.dyn.berto.se>","References":"<20200404004438.17992-1-laurent.pinchart@ideasonboard.com>\n\t<20200404004438.17992-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200404004438.17992-8-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 07/11] libcamera: v4l2_videodevice:\n\tDowngrade 4CC conversion errors to warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Apr 2020 23:39:39 -0000"}}]