{"id":3381,"url":"https://patchwork.libcamera.org/api/patches/3381/?format=json","web_url":"https://patchwork.libcamera.org/patch/3381/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200404004438.17992-5-laurent.pinchart@ideasonboard.com>","date":"2020-04-04T00:44:31","name":"[libcamera-devel,v4,04/11] libcamera: v4l2_subdevice: Don't use doxygen \\ref needlessly","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"504cc1f9d601cb8f4e5ae6eba4ddd6b6633933a1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3381/mbox/","series":[{"id":796,"url":"https://patchwork.libcamera.org/api/series/796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=796","date":"2020-04-04T00:44:27","name":"Simple pipeline handler","version":4,"mbox":"https://patchwork.libcamera.org/series/796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3381/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3381/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC95262DA4\n\tfor ;\n\tSat, 4 Apr 2020 02:44:53 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 215DE1265;\n\tSat, 4 Apr 2020 02:44:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EI9pPPzh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585961093;\n\tbh=n6kBxFpep6vevtnx3jm8XuuWOteokWZ6wvu3GXl/GzI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EI9pPPzh1t1lwGXEQXg2kK4urMyK4DS7oN/QNwCOrQ1Tv8lbvawpM+V1CFdn/sJfk\n\thRNcZn9yQd7Ar8RSYe+5dly84gxF+2iQZ9i7IAwzgpKVmRqvNJE3txYk82NQ8nNFxj\n\teSMLKbFNouzYScTcYMOJLfttXCRzYnCTYb3z07Fw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Martijn Braam ,\n\tBenjamin GAIGNARD ,\n\tAndrey Konovalov ","Date":"Sat, 4 Apr 2020 03:44:31 +0300","Message-Id":"<20200404004438.17992-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200404004438.17992-1-laurent.pinchart@ideasonboard.com>","References":"<20200404004438.17992-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 04/11] libcamera: v4l2_subdevice: Don't\n\tuse doxygen \\ref needlessly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 04 Apr 2020 00:44:54 -0000"},"content":"The doxygen \\ref command is used to generate a reference to a function,\nwhile adding parentheses after the function name is enough. Simplify the\ndocumentation.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \n---\n src/libcamera/v4l2_subdevice.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex f554d2385fff..c28e591ba51a 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -228,8 +228,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n * \"ActiveFormat\" or \\ref V4L2Subdevice::TryFormat \"TryFormat\"\n *\n * Apply the requested image format to the desired media pad and return the\n- * actually applied format parameters, as \\ref V4L2Subdevice::getFormat would\n- * do.\n+ * actually applied format parameters, as getFormat() would do.\n *\n * \\return 0 on success or a negative error code otherwise\n */\n","prefixes":["libcamera-devel","v4","04/11"]}