[{"id":4493,"web_url":"https://patchwork.libcamera.org/comment/4493/","msgid":"<20200423194749.GM6196@pendragon.ideasonboard.com>","date":"2020-04-23T19:47:49","subject":"Re: [libcamera-devel] [PATCH v3 5/5] libcamera: controls: Add AWB\n\trelated controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Apr 03, 2020 at 03:53:05PM +0100, Naushir Patuck wrote:\n> AwbMode is a new enum type to specify operating mode of the AWB\n> algorithm. All modes may not be supported by all platforms.\n> \n> ColourGains is a new float array type used to specify manual red\n> and blue (in that order) colour channel gains when AWB is disabled.\n> \n> ColourTemperature is a new control to return the current estimate of the\n> colour temperature.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 55 +++++++++++++++++++++++++++++++++-\n> 1 file changed, 54 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 50f9e07b..d2e1820a 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -162,7 +162,60 @@ controls:\n> description: |\n> Enable or disable the AWB.\n> \n> - \\sa ManualGain\n> + \\sa ColourGains\n> +\n> + # AwbMode needs further attention:\n> + # - Auto-generate max enum value.\n> + # - Better handling of custom types.\n> + - AwbMode:\n> + type: int32_t\n> + description: |\n> + Specify the range of illumants to use for the AWB algorithm. The modes\n> + supported are platform specific, and not all modes may be supported.\n> + enum:\n> + - name: AwbAuto\n> + value: 0\n> + description: Search over the whole CT range.\n\nMaybe s/CT/colour temperature/ ?\n\n> + - name: AwbIncandescent\n> + value: 1\n> + description: Incandescent AWB lamp mode.\n> + - name: AwbTungsten\n> + value: 2\n> + description: Tungsten AWB lamp mode.\n> + - name: AwbFluorescent\n> + value: 3\n> + description: Fluorescent AWB lamp mode.\n> + - name: AwbIndoor\n> + value: 4\n> + description: Indoor AWB lighting mode.\n> + - name: AwbDaylight\n> + value: 5\n> + description: Daylight AWB lighting mode.\n> + - name: AwbCloudy\n> + value: 6\n> + description: Cloudy AWB lighting mode.\n> + - name: AwbCustom\n> + value: 7\n> + description: Custom AWB mode.\n> + - name: AwbModeMax\n> + value: 7\n> + description: Maximum allowed value (place any new values above here).\n> +\n> + - ColourGains:\n> + type: float\n> + description: |\n> + Pair of gain values for the Red and Blue colour channels, in that\n> + order. ColourGains can only be applied in a Request when the AWB is\n> + disabled.\n> +\n> + \\sa AwbEnable\n> + size: [2]\n> +\n> + # ColourTemperature can only be returned in Metadata\n> + - ColourTemperature:\n> + type: float\n> + description: Report the current estimate of the colour temperature for\n> + this frame.\n\ns/this frame./this frame, in kelvin./ or\ns/colour temperature/colour temperature, in kelvin,/ ?\n\nReviewed-by: Laurent Pinchart \n\n> \n> - Saturation:\n> type: int32_t","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB42162E45\n\tfor ;\n\tThu, 23 Apr 2020 21:48:04 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 26CF94F7;\n\tThu, 23 Apr 2020 21:48:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"t/LUz1e6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587671284;\n\tbh=GRjwC27DN3XXAtrrrt6UhMqurzBh8eOVVMylrnpj5qE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=t/LUz1e6oiA2GIOQO41vWRf13S3aEMBsbyN6GwRd5uM8QdkpMjWWMPvLA4tz6PFiD\n\tuwx4YGyzTqAVHIHGgjh571eMilLpd+75P8+BUTVuVRLOERM85FHqJMf065ShRUH0iI\n\tQBvkBVEErHalYQ6BYeURPnjAl8s8g2TW5I8QFdnE=","Date":"Thu, 23 Apr 2020 22:47:49 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200423194749.GM6196@pendragon.ideasonboard.com>","References":"<20200403145305.10288-1-naush@raspberrypi.com>\n\t<20200403145305.10288-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200403145305.10288-6-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 5/5] libcamera: controls: Add AWB\n\trelated controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 23 Apr 2020 19:48:05 -0000"}},{"id":4496,"web_url":"https://patchwork.libcamera.org/comment/4496/","msgid":"","date":"2020-04-24T09:42:52","subject":"Re: [libcamera-devel] [PATCH v3 5/5] libcamera: controls: Add AWB\n\trelated controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Thu, 23 Apr 2020 at 20:48, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Fri, Apr 03, 2020 at 03:53:05PM +0100, Naushir Patuck wrote:\n> > AwbMode is a new enum type to specify operating mode of the AWB\n> > algorithm. All modes may not be supported by all platforms.\n> >\n> > ColourGains is a new float array type used to specify manual red\n> > and blue (in that order) colour channel gains when AWB is disabled.\n> >\n> > ColourTemperature is a new control to return the current estimate of the\n> > colour temperature.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/control_ids.yaml | 55 +++++++++++++++++++++++++++++++++-\n> > 1 file changed, 54 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index 50f9e07b..d2e1820a 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -162,7 +162,60 @@ controls:\n> > description: |\n> > Enable or disable the AWB.\n> >\n> > - \\sa ManualGain\n> > + \\sa ColourGains\n> > +\n> > + # AwbMode needs further attention:\n> > + # - Auto-generate max enum value.\n> > + # - Better handling of custom types.\n> > + - AwbMode:\n> > + type: int32_t\n> > + description: |\n> > + Specify the range of illumants to use for the AWB algorithm. The modes\n> > + supported are platform specific, and not all modes may be supported.\n> > + enum:\n> > + - name: AwbAuto\n> > + value: 0\n> > + description: Search over the whole CT range.\n>\n> Maybe s/CT/colour temperature/ ?\n\nDone\n\n>\n> > + - name: AwbIncandescent\n> > + value: 1\n> > + description: Incandescent AWB lamp mode.\n> > + - name: AwbTungsten\n> > + value: 2\n> > + description: Tungsten AWB lamp mode.\n> > + - name: AwbFluorescent\n> > + value: 3\n> > + description: Fluorescent AWB lamp mode.\n> > + - name: AwbIndoor\n> > + value: 4\n> > + description: Indoor AWB lighting mode.\n> > + - name: AwbDaylight\n> > + value: 5\n> > + description: Daylight AWB lighting mode.\n> > + - name: AwbCloudy\n> > + value: 6\n> > + description: Cloudy AWB lighting mode.\n> > + - name: AwbCustom\n> > + value: 7\n> > + description: Custom AWB mode.\n> > + - name: AwbModeMax\n> > + value: 7\n> > + description: Maximum allowed value (place any new values above here).\n> > +\n> > + - ColourGains:\n> > + type: float\n> > + description: |\n> > + Pair of gain values for the Red and Blue colour channels, in that\n> > + order. ColourGains can only be applied in a Request when the AWB is\n> > + disabled.\n> > +\n> > + \\sa AwbEnable\n> > + size: [2]\n> > +\n> > + # ColourTemperature can only be returned in Metadata\n> > + - ColourTemperature:\n> > + type: float\n> > + description: Report the current estimate of the colour temperature for\n> > + this frame.\n>\n> s/this frame./this frame, in kelvin./ or\n> s/colour temperature/colour temperature, in kelvin,/ ?\n\nDone, using the second suggestion. To be consistent with the previous\nchange for \"Lux\", I've removed the comment and updated the description\nto say the same.\n\nRegards,\nNaush\n\n\n>\n> Reviewed-by: Laurent Pinchart \n>\n> >\n> > - Saturation:\n> > type: int32_t\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97010603FB\n\tfor ;\n\tFri, 24 Apr 2020 11:43:09 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id b2so9258328ljp.4\n\tfor ;\n\tFri, 24 Apr 2020 02:43:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"EdMU3qS2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=E+W4T04KV8J/dyv3fYmIo9coGjGutHJCz1KOjB/zviE=;\n\tb=EdMU3qS2NB+9Y5D71QM/W4HEWlJYYqLXNWH0NHAJ+/1UqoMExkodH/hiX9L4bnf4F6\n\tk2fr0P/a1GeBGQMzsE9Pmti2khFs2dDvwwcwrdR54vyJihsqeP25leemJqerLXrmK6nA\n\tXNulGEJHGIitpfp1TIvtkdsUzOsVhe/RI4pAkExMJ4f/r8sFNKsvfLEONKzumd1okpDm\n\te+oq33W5c2gOAhTn5T9/3JX8F1euMBvLDPR93f03m8/iULkEX+2dXdduu+SqT+X35W4W\n\t6FTogRHwrLG8Tf0iudlzetuuLGMubzft3jVu8Hqp/eNpqSSdXlG9mixCa41b2+QoiLi+\n\t4qcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=E+W4T04KV8J/dyv3fYmIo9coGjGutHJCz1KOjB/zviE=;\n\tb=PxQqcDLfnJFKGG+mGOUiGVp+LfRo5EebsEIZOwwI/qRn9nAJzRcClqiAKBacAkAv/B\n\tbespqgDTyuUoeaM3oBPAoAC9KP7Ji/DPEXCwn4xIfjItO47qfykOoSv4smWbLg1DZiHH\n\tEs4qRu8UQmGzyMAJ0Djx2t0oMC94j7UIVKOjaLiete211NlkLh8USR0gGEYxCoE/5+fx\n\tRShD8Gb4cu4R72NqZoOWuJxIYdMX8oufhZ5KTKkBS0g06g5Y2rhJg3hwYSQrC+HM7RsF\n\tntPqElaFTn4bumevIVaQxa6ttd1xPcE7ZPJ70TDn1XWwsvb5J6/7kYBAPTbNLT61PlUL\n\taSPg==","X-Gm-Message-State":"AGi0Pubv9rbVhe8sOBGh2FL8ctvC1HTnlWl/II3SL0xOgRDedPY4keQS\n\tsGeRe+rQ4NSysn9U0bP3TyrQXZuH8l/z0txb8S51pA==","X-Google-Smtp-Source":"APiQypJcTO6c0blJhCVUWrc8ge5+bdlq1wK4fqen3UTSlhxz/3o64GOLE4RoqcxMSH+njlT0AAb4nRFHP9sQLPOdgwc=","X-Received":"by 2002:a2e:553:: with SMTP id 80mr5370121ljf.147.1587721388944; \n\tFri, 24 Apr 2020 02:43:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20200403145305.10288-1-naush@raspberrypi.com>\n\t<20200403145305.10288-6-naush@raspberrypi.com>\n\t<20200423194749.GM6196@pendragon.ideasonboard.com>","In-Reply-To":"<20200423194749.GM6196@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 24 Apr 2020 10:42:52 +0100","Message-ID":"","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 5/5] libcamera: controls: Add AWB\n\trelated controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 24 Apr 2020 09:43:09 -0000"}}]