{"id":3375,"url":"https://patchwork.libcamera.org/api/patches/3375/?format=json","web_url":"https://patchwork.libcamera.org/patch/3375/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200403145305.10288-6-naush@raspberrypi.com>","date":"2020-04-03T14:53:05","name":"[libcamera-devel,v3,5/5] libcamera: controls: Add AWB related controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"49ba823066c63f54fdb86eb3b30762c629a8179e","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3375/mbox/","series":[{"id":794,"url":"https://patchwork.libcamera.org/api/series/794/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=794","date":"2020-04-03T14:53:00","name":"Patchset for libcamera controls","version":3,"mbox":"https://patchwork.libcamera.org/series/794/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3375/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3375/checks/","tags":{},"headers":{"Return-Path":"<naush@raspberrypi.com>","Received":["from mail-wm1-x341.google.com (mail-wm1-x341.google.com\n\t[IPv6:2a00:1450:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4168062D64\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  3 Apr 2020 16:53:32 +0200 (CEST)","by mail-wm1-x341.google.com with SMTP id t8so7435251wmi.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 03 Apr 2020 07:53:32 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tu5sm13559469wrp.81.2020.04.03.07.53.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 03 Apr 2020 07:53:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Rj49iBe2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=2Y/cvyHB3yCOEjWu2+FR5pgwdPYPAyACZPa/xctDsQU=;\n\tb=Rj49iBe2144+FJOr7XJegccJeM+Zc4USJNISlndbUzSjjrRl04uXoyHA/OqqAOnV/Y\n\tAb1Ub55kUwC8BjXeo8YbGZdQ+fCrNlDaYM+FKC4xfkY5AN+Ci4wXMvgSTeud8jIylp6c\n\tP0sLRmvvEc9hXE1lGs++a9X9lGhf1HCpTW+gFtSaCwNvvWNPbe+UeQMOHkEk1XJ19Pkr\n\t543QNlLeArDivHdo+Px/7iq4G+IF7wNS7/nZNhZbsl4xX6PzTx+46oHUyGKujWQ4Rebt\n\tFtVfl9ul2CJphRfPRqIY9RodWItNY3z6zOTQeX2/ZdVZUz4ZpG8garFfbNlzT+uoyI20\n\tPXHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=2Y/cvyHB3yCOEjWu2+FR5pgwdPYPAyACZPa/xctDsQU=;\n\tb=oHjHID/6bm6+4IcsEknMrgSmhTDEaMualcrLbpGWRfhq+F2lJuRuMNisJOZ4m6bhuQ\n\tYbOAdPsPHDxs7dsKSywZ5GtJ2wndN5cHb72T5OVnxAsm3xuKnSQpRzt84vGMEq+SWUnS\n\tz6OJOSWcqPSh28ssm2uWHuabwkkUmovLTut//6hxUoJ0uZQdm3grDPfr7xYZPJFn3E+y\n\tpOQ0rHQj6nETI4oewc5Rf7aq+DM6Za3rB+Ms+YHMlYUXVJKDA435P6iIgd+fNH4sKbTP\n\tRxEHwjEx99jVJ98jf0V7RSsmcrX275yxokpWi8XNhljsFZCKSkTZbna6Wc2Zax+R6W0y\n\t9IYw==","X-Gm-Message-State":"AGi0PuZD27fVMvjVwsLYacqeC2DXv1GG+2aNPG2JTR4QbtaMLJcb33xo\n\tFSGf3LOBOTYoepeX1BXLnmKUkDLuV5tVSQ==","X-Google-Smtp-Source":"APiQypIwrxtQgCdldHJkrRh9tTgzvGOXZNGf+ytqPPA4OojXsxV7cTnaXvozgiU//GqZNn2mUvmThA==","X-Received":"by 2002:a7b:c144:: with SMTP id z4mr9645495wmi.128.1585925611818;\n\tFri, 03 Apr 2020 07:53:31 -0700 (PDT)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  3 Apr 2020 15:53:05 +0100","Message-Id":"<20200403145305.10288-6-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20200403145305.10288-1-naush@raspberrypi.com>","References":"<20200403145305.10288-1-naush@raspberrypi.com>","Subject":"[libcamera-devel] [PATCH v3 5/5] libcamera: controls: Add AWB\n\trelated controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 03 Apr 2020 14:53:32 -0000"},"content":"AwbMode is a new enum type to specify operating mode of the AWB\nalgorithm. All modes may not be supported by all platforms.\n\nColourGains is a new float array type used to specify manual red\nand blue (in that order) colour channel gains when AWB is disabled.\n\nColourTemperature is a new control to return the current estimate of the\ncolour temperature.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 55 +++++++++++++++++++++++++++++++++-\n 1 file changed, 54 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 50f9e07b..d2e1820a 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -162,7 +162,60 @@ controls:\n       description: |\n         Enable or disable the AWB.\n \n-        \\sa ManualGain\n+        \\sa ColourGains\n+\n+  # AwbMode needs further attention:\n+  # - Auto-generate max enum value.\n+  # - Better handling of custom types.\n+  - AwbMode:\n+      type: int32_t\n+      description: |\n+        Specify the range of illumants to use for the AWB algorithm. The modes\n+        supported are platform specific, and not all modes may be supported.\n+      enum:\n+        - name: AwbAuto\n+          value: 0\n+          description: Search over the whole CT range.\n+        - name: AwbIncandescent\n+          value: 1\n+          description: Incandescent AWB lamp mode.\n+        - name: AwbTungsten\n+          value: 2\n+          description: Tungsten AWB lamp mode.\n+        - name: AwbFluorescent\n+          value: 3\n+          description: Fluorescent AWB lamp mode.\n+        - name: AwbIndoor\n+          value: 4\n+          description: Indoor AWB lighting mode.\n+        - name: AwbDaylight\n+          value: 5\n+          description: Daylight AWB lighting mode.\n+        - name: AwbCloudy\n+          value: 6\n+          description: Cloudy AWB lighting mode.\n+        - name: AwbCustom\n+          value: 7\n+          description: Custom AWB mode.\n+        - name: AwbModeMax\n+          value: 7\n+          description: Maximum allowed value (place any new values above here).\n+\n+  - ColourGains:\n+      type: float\n+      description: |\n+        Pair of gain values for the Red and Blue colour channels, in that\n+        order. ColourGains can only be applied in a Request when the AWB is\n+        disabled.\n+\n+        \\sa AwbEnable\n+      size: [2]\n+\n+  # ColourTemperature can only be returned in Metadata\n+  - ColourTemperature:\n+      type: float\n+      description: Report the current estimate of the colour temperature for\n+        this frame.\n \n   - Saturation:\n       type: int32_t\n","prefixes":["libcamera-devel","v3","5/5"]}