[{"id":4490,"web_url":"https://patchwork.libcamera.org/comment/4490/","msgid":"<20200423191150.GJ6196@pendragon.ideasonboard.com>","date":"2020-04-23T19:11:50","subject":"Re: [libcamera-devel] [PATCH v3 3/5] libcamera: controls: Reorder\n\tand update description of existing controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Apr 03, 2020 at 03:53:03PM +0100, Naushir Patuck wrote:\n> Group AE, AWB, etc. controls together for accessibility.\n> \n> Update descriptions for Contrast, Brightness, and Saturation controls.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 45 ++++++++++++++++++++--------------\n> 1 file changed, 26 insertions(+), 19 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 839eea76..64e81520 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -23,25 +23,6 @@ controls:\n> \n> \\sa AeEnable\n> \n> - - AwbEnable:\n> - type: bool\n> - description: |\n> - Enable or disable the AWB.\n> -\n> - \\sa ManualGain\n> -\n> - - Brightness:\n> - type: int32_t\n> - description: Specify a fixed brightness parameter\n> -\n> - - Contrast:\n> - type: int32_t\n> - description: Specify a fixed contrast parameter\n> -\n> - - Saturation:\n> - type: int32_t\n> - description: Specify a fixed saturation parameter\n> -\n> - ExposureTime:\n> type: int32_t\n> description: |\n> @@ -58,4 +39,30 @@ controls:\n> colour channels. This value cannot be lower than 1.0.\n> \n> \\sa ExposureTime AeEnable\n> +\n> + - Brightness:\n> + type: int32_t\n> + description: |\n> + Specify a fixed brightness parameter. Positive values (up to 65535)\n> + produce brighter images; negative values (up to -65536) produce darker\n> + images and 0 leaves pixels unchanged.\n> +\n> + - Contrast:\n> + type: int32_t\n> + description: |\n> + Specify a fixed contrast parameter. Normal contrast is given by the\n> + value 1.0; larger values produce images with more contrast.\n\nContrast is an int32_t type. Should it be changed to a float, or use a\nfixed-point value like brightness ? I think both should use the same\ntype, and if we go for fixed-point, 1.0 isn't the right default :-)\n\nThe uvcvideo pipeline handler should be adapted, I can handle that once\nwe agree on what types and ranges are best.\n\n> +\n> + - AwbEnable:\n> + type: bool\n> + description: |\n> + Enable or disable the AWB.\n> +\n> + \\sa ManualGain\n> +\n> + - Saturation:\n> + type: int32_t\n> + description: |\n> + Specify a fixed saturation parameter. Normal saturation is given by\n> + the value 1.0; larger values produce more saturated colours.\n\nSame here.\n\n> ...","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E5F662E45\n\tfor ;\n\tThu, 23 Apr 2020 21:12:05 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C2A1A4F7;\n\tThu, 23 Apr 2020 21:12:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"J9YVsdGE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587669125;\n\tbh=GS0Rcsu7+KtQIifNgS7Pj6rC4fCjxwFwAI7CKNiUCZ0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J9YVsdGEHevYLpQhPFUR78PsO5vfaGFFqZlmsRS9CMrbL+z41Hu2D2oLMzwHLx1nq\n\tS8YUmQwHXD7IatVEEibf3pkbHX+TgWrcmq/QI/upyKw4rSZkrY+wUlRt/19EghOswO\n\tkgdXLBkqzzJMAwmGih38YDI9hKroMaPA+ZfjOl8U=","Date":"Thu, 23 Apr 2020 22:11:50 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200423191150.GJ6196@pendragon.ideasonboard.com>","References":"<20200403145305.10288-1-naush@raspberrypi.com>\n\t<20200403145305.10288-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200403145305.10288-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 3/5] libcamera: controls: Reorder\n\tand update description of existing controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 23 Apr 2020 19:12:05 -0000"}},{"id":4494,"web_url":"https://patchwork.libcamera.org/comment/4494/","msgid":"","date":"2020-04-24T08:53:13","subject":"Re: [libcamera-devel] [PATCH v3 3/5] libcamera: controls: Reorder\n\tand update description of existing controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Thu, 23 Apr 2020 at 20:12, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Fri, Apr 03, 2020 at 03:53:03PM +0100, Naushir Patuck wrote:\n> > Group AE, AWB, etc. controls together for accessibility.\n> >\n> > Update descriptions for Contrast, Brightness, and Saturation controls.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/control_ids.yaml | 45 ++++++++++++++++++++--------------\n> > 1 file changed, 26 insertions(+), 19 deletions(-)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index 839eea76..64e81520 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -23,25 +23,6 @@ controls:\n> >\n> > \\sa AeEnable\n> >\n> > - - AwbEnable:\n> > - type: bool\n> > - description: |\n> > - Enable or disable the AWB.\n> > -\n> > - \\sa ManualGain\n> > -\n> > - - Brightness:\n> > - type: int32_t\n> > - description: Specify a fixed brightness parameter\n> > -\n> > - - Contrast:\n> > - type: int32_t\n> > - description: Specify a fixed contrast parameter\n> > -\n> > - - Saturation:\n> > - type: int32_t\n> > - description: Specify a fixed saturation parameter\n> > -\n> > - ExposureTime:\n> > type: int32_t\n> > description: |\n> > @@ -58,4 +39,30 @@ controls:\n> > colour channels. This value cannot be lower than 1.0.\n> >\n> > \\sa ExposureTime AeEnable\n> > +\n> > + - Brightness:\n> > + type: int32_t\n> > + description: |\n> > + Specify a fixed brightness parameter. Positive values (up to 65535)\n> > + produce brighter images; negative values (up to -65536) produce darker\n> > + images and 0 leaves pixels unchanged.\n> > +\n> > + - Contrast:\n> > + type: int32_t\n> > + description: |\n> > + Specify a fixed contrast parameter. Normal contrast is given by the\n> > + value 1.0; larger values produce images with more contrast.\n>\n> Contrast is an int32_t type. Should it be changed to a float, or use a\n> fixed-point value like brightness ? I think both should use the same\n> type, and if we go for fixed-point, 1.0 isn't the right default :-)\n>\n\nSorry about that, error on my part. Contrast and Saturation should be\na float and follow Brightness. I will amend and push a new patchset\n(along with all the highlighted changes).\n\nRegards,\nNaush\n\n\n> The uvcvideo pipeline handler should be adapted, I can handle that once\n> we agree on what types and ranges are best.\n>\n> > +\n> > + - AwbEnable:\n> > + type: bool\n> > + description: |\n> > + Enable or disable the AWB.\n> > +\n> > + \\sa ManualGain\n> > +\n> > + - Saturation:\n> > + type: int32_t\n> > + description: |\n> > + Specify a fixed saturation parameter. Normal saturation is given by\n> > + the value 1.0; larger values produce more saturated colours.\n>\n> Same here.\n>\n> > ...\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 263FD603FB\n\tfor ;\n\tFri, 24 Apr 2020 10:53:29 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id r17so7057892lff.2\n\tfor ;\n\tFri, 24 Apr 2020 01:53:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"ZdBRKklU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=jfKSPwqcnlGTdsaU55CYXbGVj7LPJfqD3aMEa1cPXqY=;\n\tb=ZdBRKklUHrXpnQJL/85zV4wQWauosA9n+RqbCeHLvzNY72s9rzCOIhrruT7Lw636zD\n\tGsewoHgdjv+PhKgNbT2uqmFsjoEQpnhoAmzBkG+bhUmjIJjWNDB1CAQXyBMOta7aMV96\n\t9glLbSGWutZCJF9BsBngk7tZNRpM/4mqJLY/xP2wbYuCMZeFmx6pdNNbfFv7vUOqwx/F\n\tc5Mp9s1qGz/wY3j11vtPHsZcAbCw02xjdgMQS6nw8IC7bMNRN+Hxl9JjEK+YiPCACYKY\n\t1w9MNEFgUA6XcBXRPqtcqfTwRoW11HjfmgmAAL/d4NDt3AHNEqqUbXt9tFiDLFYJS5Pb\n\t5kGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=jfKSPwqcnlGTdsaU55CYXbGVj7LPJfqD3aMEa1cPXqY=;\n\tb=L4TbDaTzybsgO/cXlHygnJW3mNmHoVqF2GMMWtkR0pqV3Io6r+8rd/U6rp10GQYopC\n\t0uQpkRblT1dbi0HruUBwS0/RgOtXTW5yMV7vMqyZqsW07MlhpRuIDgDn+dAYKno13fgW\n\tzOmSCUJj+7Qi/sIx2oWRkF/cZvLaLcPi6HVKKjgl45LGRhbrivgJvDKx4NOOCqpY+aIl\n\tu6724/5ev4EktUmvEAjizm9CjeT7a0u6XGqfU+911D5IcuMCynrzB7ZhjfzMufxrOkLv\n\t9XbvTFhqfnVEbjz7dR7BgqgzTyFYWZ6u5oNI9nBKCzGpB9ohNOTOFPp+6EHnYm6NSPnv\n\tr2CA==","X-Gm-Message-State":"AGi0PuYXIt+bSaffageZOc1qvDu7K7Ahxef96eEZ495ZPJnREk4XZrCZ\n\tRccpdy8LySNPy1ZptQx13p2tBn86/doFIcCf/cwZ/g==","X-Google-Smtp-Source":"APiQypKC9aaHjP614fv5z/lPNMq815XQoDA8PgBpHz650vtpC/AceoOMUEF7EeLrmCO/04nl3THGQIA4DhJQsh3vLQA=","X-Received":"by 2002:ac2:5c4e:: with SMTP id s14mr5658702lfp.77.1587718408851;\n\tFri, 24 Apr 2020 01:53:28 -0700 (PDT)","MIME-Version":"1.0","References":"<20200403145305.10288-1-naush@raspberrypi.com>\n\t<20200403145305.10288-4-naush@raspberrypi.com>\n\t<20200423191150.GJ6196@pendragon.ideasonboard.com>","In-Reply-To":"<20200423191150.GJ6196@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 24 Apr 2020 09:53:13 +0100","Message-ID":"","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 3/5] libcamera: controls: Reorder\n\tand update description of existing controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 24 Apr 2020 08:53:30 -0000"}}]