{"id":3373,"url":"https://patchwork.libcamera.org/api/patches/3373/?format=json","web_url":"https://patchwork.libcamera.org/patch/3373/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200403145305.10288-4-naush@raspberrypi.com>","date":"2020-04-03T14:53:03","name":"[libcamera-devel,v3,3/5] libcamera: controls: Reorder and update description of existing controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8ff3c2520adcc559c5d0bdcdbc46c2c961313e63","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3373/mbox/","series":[{"id":794,"url":"https://patchwork.libcamera.org/api/series/794/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=794","date":"2020-04-03T14:53:00","name":"Patchset for libcamera controls","version":3,"mbox":"https://patchwork.libcamera.org/series/794/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3373/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3373/checks/","tags":{},"headers":{"Return-Path":"","Received":["from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n\t[IPv6:2a00:1450:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA0CA629C1\n\tfor ;\n\tFri, 3 Apr 2020 16:53:30 +0200 (CEST)","by mail-wr1-x442.google.com with SMTP id 31so8869209wrs.3\n\tfor ;\n\tFri, 03 Apr 2020 07:53:30 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tu5sm13559469wrp.81.2020.04.03.07.53.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 03 Apr 2020 07:53:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"ss2zo60c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=RtEZvi9ceNL8KobZqDTHZ/xMxtvepHlaSzXqdiU5oQc=;\n\tb=ss2zo60cA9tEyDBhBkf9PgFXfOrBVkHZYQbMn0uhTze5GegX9gEmm341y6EX7s/2qV\n\tiaPVOsKEaSqcT0M41KZrvZw17XNoHpgUVZubsN5zLFj4CaqQq6eeDTZKGIpOLuUBFzg0\n\tcV6V4K4mo1/sdfYGjY2z9lnMCLM9aIxvf2xkwtjLUUCfjEQVJXsOKhuKBAECfymJtUm0\n\tsipz143pQOZn8cvEnF549AOIp64vrtnm2wVLcHzQPbot6HAIx7rQ3BZI7JDFcly1xdt1\n\tY11FuxtyjVC0iwckK1RE/ZpidH5307h2rycozF7B3dIMemdsEHmbTYD3TuXL/5I+/lB1\n\tKQ4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=RtEZvi9ceNL8KobZqDTHZ/xMxtvepHlaSzXqdiU5oQc=;\n\tb=Se+n3lUM0FzBVpkkcY/iJH0IxpLxmKBfrvugyKfFPHmUqFfb0Jb/jk7p6iWROwybLN\n\trQaFz71ko+rIlfi9uTw39IwE+DCiM9Ev4hzWTOAg23RdTvB5ElBCkkRg+HLQRheLAcVV\n\tuaQCfDTzCpMdYrTEKEWSkBn/3AFViv/XuEzCun+/6pnzskIahJj5asnlIFUHsv5CsJuj\n\tQkAPndah3Lt2xt3ue8vI7+XV6aCTflxIDe7Q6+NpwN+b8tRL3KUCgkINN7pPL2S3g0nt\n\t9VL4Pmd/E/1c4/8lbY8IZ7LSswiTKOpw9dsm8iankCf13NpKXvEqtS3pzCQvhAPj19s8\n\t0j5A==","X-Gm-Message-State":"AGi0PuZ8E9flk2w0JiQZb8Q9qlGV8GbGKMIOwFWxrJU5F7STj1zM8UcA\n\tNxecUbdusoz86zjho5DDPYaoz9T/Z0WDQQ==","X-Google-Smtp-Source":"APiQypIez94NfxKvZMHHNFhYLbZCcAZEHN0xeDz8L3sB5J6YfxBzj4p74i0Da7zQsYgAKJw4DQaM4w==","X-Received":"by 2002:a5d:68c4:: with SMTP id p4mr9645833wrw.308.1585925610342;\n\tFri, 03 Apr 2020 07:53:30 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 3 Apr 2020 15:53:03 +0100","Message-Id":"<20200403145305.10288-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20200403145305.10288-1-naush@raspberrypi.com>","References":"<20200403145305.10288-1-naush@raspberrypi.com>","Subject":"[libcamera-devel] [PATCH v3 3/5] libcamera: controls: Reorder and\n\tupdate description of existing controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 03 Apr 2020 14:53:31 -0000"},"content":"Group AE, AWB, etc. controls together for accessibility.\n\nUpdate descriptions for Contrast, Brightness, and Saturation controls.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/control_ids.yaml | 45 ++++++++++++++++++++--------------\n 1 file changed, 26 insertions(+), 19 deletions(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 839eea76..64e81520 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -23,25 +23,6 @@ controls:\n \n \\sa AeEnable\n \n- - AwbEnable:\n- type: bool\n- description: |\n- Enable or disable the AWB.\n-\n- \\sa ManualGain\n-\n- - Brightness:\n- type: int32_t\n- description: Specify a fixed brightness parameter\n-\n- - Contrast:\n- type: int32_t\n- description: Specify a fixed contrast parameter\n-\n- - Saturation:\n- type: int32_t\n- description: Specify a fixed saturation parameter\n-\n - ExposureTime:\n type: int32_t\n description: |\n@@ -58,4 +39,30 @@ controls:\n colour channels. This value cannot be lower than 1.0.\n \n \\sa ExposureTime AeEnable\n+\n+ - Brightness:\n+ type: int32_t\n+ description: |\n+ Specify a fixed brightness parameter. Positive values (up to 65535)\n+ produce brighter images; negative values (up to -65536) produce darker\n+ images and 0 leaves pixels unchanged.\n+\n+ - Contrast:\n+ type: int32_t\n+ description: |\n+ Specify a fixed contrast parameter. Normal contrast is given by the\n+ value 1.0; larger values produce images with more contrast.\n+\n+ - AwbEnable:\n+ type: bool\n+ description: |\n+ Enable or disable the AWB.\n+\n+ \\sa ManualGain\n+\n+ - Saturation:\n+ type: int32_t\n+ description: |\n+ Specify a fixed saturation parameter. Normal saturation is given by\n+ the value 1.0; larger values produce more saturated colours.\n ...\n","prefixes":["libcamera-devel","v3","3/5"]}