{"id":3339,"url":"https://patchwork.libcamera.org/api/patches/3339/?format=json","web_url":"https://patchwork.libcamera.org/patch/3339/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200326160819.4088361-5-niklas.soderlund@ragnatech.se>","date":"2020-03-26T16:08:16","name":"[libcamera-devel,RFCv2,4/7] libcamera: pipeline: rkisp1: Do not try to process cancelled frames","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e5cfb81984cf213b7b8648c062c38bb12ea70e3a","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3339/mbox/","series":[{"id":783,"url":"https://patchwork.libcamera.org/api/series/783/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=783","date":"2020-03-26T16:08:12","name":"libcamera: ipa_manager: Proxy open-source IPAs to a thread","version":1,"mbox":"https://patchwork.libcamera.org/series/783/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3339/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3339/checks/","tags":{},"headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1836762CEB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Mar 2020 17:10:34 +0100 (CET)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 4d3d0928-6f7c-11ea-89d0-0050569116f7;\n\tThu, 26 Mar 2020 17:10:25 +0100 (CET)"],"X-Halon-ID":"4d3d0928-6f7c-11ea-89d0-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 26 Mar 2020 17:08:16 +0100","Message-Id":"<20200326160819.4088361-5-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200326160819.4088361-1-niklas.soderlund@ragnatech.se>","References":"<20200326160819.4088361-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFCv2 4/7] libcamera: pipeline: rkisp1: Do not\n\ttry to process cancelled frames","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 26 Mar 2020 16:10:36 -0000"},"content":"Their is no need to try and process cancelled frames.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex f64807984519779b..f49b3a7f0945ac92 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1011,6 +1011,9 @@ void PipelineHandlerRkISP1::tryCompleteRequest(Request *request)\n \n void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n {\n+\tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n+\t\treturn;\n+\n \tASSERT(activeCamera_);\n \tRkISP1CameraData *data = cameraData(activeCamera_);\n \tRequest *request = buffer->request();\n@@ -1026,6 +1029,9 @@ void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n \n void PipelineHandlerRkISP1::paramReady(FrameBuffer *buffer)\n {\n+\tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n+\t\treturn;\n+\n \tASSERT(activeCamera_);\n \tRkISP1CameraData *data = cameraData(activeCamera_);\n \n@@ -1037,6 +1043,9 @@ void PipelineHandlerRkISP1::paramReady(FrameBuffer *buffer)\n \n void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n {\n+\tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n+\t\treturn;\n+\n \tASSERT(activeCamera_);\n \tRkISP1CameraData *data = cameraData(activeCamera_);\n \n","prefixes":["libcamera-devel","RFCv2","4/7"]}