[{"id":4297,"web_url":"https://patchwork.libcamera.org/comment/4297/","msgid":"","date":"2020-03-26T08:56:42","subject":"Re: [libcamera-devel] [PATCH] qcam: Print whole stream\n\tconfiguration when adjusted","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 26/03/2020 01:35, Laurent Pinchart wrote:\n> When the validate() function adjusts the stream configuration, we print\n> the adjusted size for debugging purpose. Switch to printing the whole\n> configuration, as the pixel format may be useful too.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main_window.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 565732698a5e..cf39ed7aceca 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -281,6 +281,7 @@ int MainWindow::startCapture()\n> \tconfig_ = camera_->generateConfiguration({ StreamRole::Viewfinder });\n> \n> \tStreamConfiguration &cfg = config_->at(0);\n> +\n> \tif (options_.isSet(OptSize)) {\n> \t\tconst std::vector &sizeOptions =\n> \t\t\toptions_[OptSize].toArray();\n> @@ -316,10 +317,9 @@ int MainWindow::startCapture()\n> \t\treturn -EINVAL;\n> \t}\n> \n> -\tif (validation == CameraConfiguration::Adjusted) {\n> -\t\tqInfo() << \"Stream size adjusted to\"\n> -\t\t\t<< cfg.size.toString().c_str();\n> -\t}\n> +\tif (validation == CameraConfiguration::Adjusted)\n> +\t\tqInfo() << \"Stream configuration adjusted to \"\n> +\t\t\t<< cfg.toString().c_str();\n> \n\n\nShould we make this same change in the pipelines validate() call too?\n(as a separate patch from this I expect)\n\nBut for this patch,\n\nReviewed-by: Kieran Bingham \n\n> \tret = camera_->configure(config_.get());\n> \tif (ret < 0) {\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2151E6040F\n\tfor ;\n\tThu, 26 Mar 2020 09:56:46 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7950A2DC;\n\tThu, 26 Mar 2020 09:56:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Y+zo9nVt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585213005;\n\tbh=ejuMr0x2RqEv1JjUEQ1N0Yzy90oraJYmkA/zNpZnuGQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Y+zo9nVtKDTqrWOc7D36Ij23Oj9BxPOBjAjcVUPP6h0I6yK5WOw505Erjai1B/pO5\n\talf0zv0C/wcjTKlY6Vn9RBu1sW7Rp85L0zHB9NRJXnOwK3WFbbjX0YcXPfYseMqow7\n\ti5w3+NGxG5Ur0UzXfK4QPWx+eKKY06tnLVXrcS58=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200326013512.25425-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 26 Mar 2020 08:56:42 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200326013512.25425-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: Print whole stream\n\tconfiguration when adjusted","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 26 Mar 2020 08:56:46 -0000"}},{"id":4298,"web_url":"https://patchwork.libcamera.org/comment/4298/","msgid":"<20200326101830.GJ20581@pendragon.ideasonboard.com>","date":"2020-03-26T10:18:30","subject":"Re: [libcamera-devel] [PATCH] qcam: Print whole stream\n\tconfiguration when adjusted","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Mar 26, 2020 at 08:56:42AM +0000, Kieran Bingham wrote:\n> On 26/03/2020 01:35, Laurent Pinchart wrote:\n> > When the validate() function adjusts the stream configuration, we print\n> > the adjusted size for debugging purpose. Switch to printing the whole\n> > configuration, as the pixel format may be useful too.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/qcam/main_window.cpp | 8 ++++----\n> > 1 file changed, 4 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index 565732698a5e..cf39ed7aceca 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -281,6 +281,7 @@ int MainWindow::startCapture()\n> > \tconfig_ = camera_->generateConfiguration({ StreamRole::Viewfinder });\n> > \n> > \tStreamConfiguration &cfg = config_->at(0);\n> > +\n> > \tif (options_.isSet(OptSize)) {\n> > \t\tconst std::vector &sizeOptions =\n> > \t\t\toptions_[OptSize].toArray();\n> > @@ -316,10 +317,9 @@ int MainWindow::startCapture()\n> > \t\treturn -EINVAL;\n> > \t}\n> > \n> > -\tif (validation == CameraConfiguration::Adjusted) {\n> > -\t\tqInfo() << \"Stream size adjusted to\"\n> > -\t\t\t<< cfg.size.toString().c_str();\n> > -\t}\n> > +\tif (validation == CameraConfiguration::Adjusted)\n> > +\t\tqInfo() << \"Stream configuration adjusted to \"\n> > +\t\t\t<< cfg.toString().c_str();\n> > \n> \n> Should we make this same change in the pipelines validate() call too?\n> (as a separate patch from this I expect)\n\nI wonder if they would actually simplify pipeline handlers, as they\nwould need to keep a copy of the StreamConfiguration to be able to print\nthe old and new values. Something to think about separately indeed\nanyway.\n\n> But for this patch,\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \tret = camera_->configure(config_.get());\n> > \tif (ret < 0) {\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AE94605D1\n\tfor ;\n\tThu, 26 Mar 2020 11:18:34 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFA212DC;\n\tThu, 26 Mar 2020 11:18:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VjD5BwBQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585217914;\n\tbh=bidS1GYAgtOU7QduSeaYIV3wx9K1F++mwqaB3SFU21Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VjD5BwBQvHnL32jI8+Q40RxNT+B0TMnNh51+XxLebKKBW9RKNCAoRJVCXiSBWeDrz\n\tToLgTPCP+7BKvEjJPilLdyxzqP0NqhgBjHTM7xltZKFKw0C81Zm/vGCIhzk6RAOaAK\n\tnH69+6QJJPVqS9B31eZy6X3nUCmMGegEeFUlsM/E=","Date":"Thu, 26 Mar 2020 12:18:30 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200326101830.GJ20581@pendragon.ideasonboard.com>","References":"<20200326013512.25425-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] qcam: Print whole stream\n\tconfiguration when adjusted","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 26 Mar 2020 10:18:34 -0000"}}]