[{"id":4268,"web_url":"https://patchwork.libcamera.org/comment/4268/","msgid":"<20200324204616.GD20997@pendragon.ideasonboard.com>","date":"2020-03-24T20:46:16","subject":"Re: [libcamera-devel] [PATCH 4/4] media: bcm2835: Fix trivial\n\twhitespace error","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Mar 24, 2020 at 09:28:44PM +0100, Jacopo Mondi wrote:\n> Cosmetic change only.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> drivers/media/platform/bcm2835/bcm2835-unicam.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c b/drivers/media/platform/bcm2835/bcm2835-unicam.c\n> index 5001976dcebc..65534a18d3d4 100644\n> --- a/drivers/media/platform/bcm2835/bcm2835-unicam.c\n> +++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c\n> @@ -2462,7 +2462,7 @@ static int unicam_set_ctrl(struct v4l2_ctrl *ctrl)\n> \t\t/* Change the number of frames of delay we believe there\n> \t\t * to be between updating analogue gain and it taking effect.\n> \t\t */\n> -\t\treturn unicam_update_delay(unicam, \n> +\t\treturn unicam_update_delay(unicam,\n> \t\t\tV4L2_CID_ANALOGUE_GAIN, ctrl->val);\n\nWhile at it, write it\n\n\t\treturn unicam_update_delay(unicam, V4L2_CID_ANALOGUE_GAIN,\n\t\t\t\t\t ctrl->val);\n\nReviewed-by: Laurent Pinchart \n\n> \n> \tdefault:","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52E2860411\n\tfor ;\n\tTue, 24 Mar 2020 21:46:19 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F7A52D2;\n\tTue, 24 Mar 2020 21:46:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Khq6yQR4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585082778;\n\tbh=U0n7oZ9KuKIc+UfH46Id9kcgZ5vT9XPc8ip+OnadaMQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Khq6yQR4I9DlbU3B0OrA/h+4+uLAPoOCCu8DNit6P8OxUQBtEnKYl9VGpagEPjen8\n\tYMfjMlq9uYEVBRtSbyk9UM9I7uc3yUvq2pOgx38PkJx46Y7KaAk1guzoyvHsgHzXby\n\t51YvVcaCno2mKZLB+sU6P/9YVmOgONkUwM0P0wKo=","Date":"Tue, 24 Mar 2020 22:46:16 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"linux-media@vger.kernel.org, libcamera-devel@lists.libcamera.org,\n\thverkuil-cisco@xs4all.nl, mchehab@kernel.org,\n\tsakari.ailus@linux.intel.com","Message-ID":"<20200324204616.GD20997@pendragon.ideasonboard.com>","References":"<20200324202844.1518292-1-jacopo@jmondi.org>\n\t<20200324202844.1518292-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200324202844.1518292-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/4] media: bcm2835: Fix trivial\n\twhitespace error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 20:46:20 -0000"}}]