{"id":3314,"url":"https://patchwork.libcamera.org/api/patches/3314/?format=json","web_url":"https://patchwork.libcamera.org/patch/3314/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200324202844.1518292-4-jacopo@jmondi.org>","date":"2020-03-24T20:28:43","name":"[libcamera-devel,3/4] media: bcm2835: Register sensor devnode as read-only","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8a5f5e84d201d71d0087994a6ab89642be7b8a54","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3314/mbox/","series":[{"id":772,"url":"https://patchwork.libcamera.org/api/series/772/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=772","date":"2020-03-24T20:28:40","name":"media: Register read-only sub-dev devnode","version":1,"mbox":"https://patchwork.libcamera.org/series/772/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3314/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3314/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F27A562CE7\n\tfor ;\n\tTue, 24 Mar 2020 21:25:57 +0100 (CET)","from localhost.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id B7973100011;\n\tTue, 24 Mar 2020 20:25:56 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi , mchehab@kernel.org,\n\thverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com","Date":"Tue, 24 Mar 2020 21:28:43 +0100","Message-Id":"<20200324202844.1518292-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200324202844.1518292-1-jacopo@jmondi.org>","References":"<20200324202844.1518292-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/4] media: bcm2835: Register sensor\n\tdevnode as read-only","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 20:25:58 -0000"},"content":"The bcm2835 bridge drivers controls the camera sensor configuration through\ndirect calls to the kapi realized by the v4l2 sub-device operations and\ndoes not allow userspace to change the sensor parameter through the\nsub-device devnode.\n\nIn order to expose to userspace the current sensor configuration,\nregister the device node in read-only mode by using the newly introduced\nv4l2_device_register_subdev_ro_nodes() function.\n\nSigned-off-by: Jacopo Mondi \n---\n drivers/media/platform/bcm2835/bcm2835-unicam.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c b/drivers/media/platform/bcm2835/bcm2835-unicam.c\nindex 89bd1c842d38..5001976dcebc 100644\n--- a/drivers/media/platform/bcm2835/bcm2835-unicam.c\n+++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c\n@@ -2875,7 +2875,7 @@ static int unicam_probe_complete(struct unicam_device *unicam)\n \t\tgoto unregister;\n \t}\n \n-\tret = v4l2_device_register_subdev_nodes(&unicam->v4l2_dev);\n+\tret = v4l2_device_register_ro_subdev_nodes(&unicam->v4l2_dev);\n \tif (ret) {\n \t\tunicam_err(unicam, \"Unable to register subdev nodes.\\n\");\n \t\tgoto unregister;\n","prefixes":["libcamera-devel","3/4"]}