[{"id":4265,"web_url":"https://patchwork.libcamera.org/comment/4265/","msgid":"<20200324163534.GC20997@pendragon.ideasonboard.com>","date":"2020-03-24T16:35:34","subject":"Re: [libcamera-devel] [PATCH 2/7] cam: Add option to capture\n\tStillCaptureRaw stream","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Tue, Mar 24, 2020 at 04:51:40PM +0100, Niklas Söderlund wrote:\n> Add a role name 'stillraw' to request a StillCaptureRaw stream.\n> \n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/cam/main.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 7cdd215ba5398aec..4ef9cce2c97caddd 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -155,7 +155,7 @@ int CamApp::parseOptions(int argc, char *argv[])\n> {\n> \tKeyValueParser streamKeyValue;\n> \tstreamKeyValue.addOption(\"role\", OptionString,\n> -\t\t\t\t \"Role for the stream (viewfinder, video, still)\",\n> +\t\t\t\t \"Role for the stream (viewfinder, video, still, stillraw)\",\n> \t\t\t\t ArgumentRequired);\n> \tstreamKeyValue.addOption(\"width\", OptionInteger, \"Width in pixels\",\n> \t\t\t\t ArgumentRequired);\n> @@ -219,6 +219,8 @@ int CamApp::prepareConfig()\n> \t\t\t\troles.push_back(StreamRole::VideoRecording);\n> \t\t\t} else if (role == \"still\") {\n> \t\t\t\troles.push_back(StreamRole::StillCapture);\n> +\t\t\t} else if (opt[\"role\"].toString() == \"stillraw\") {\n\n\t\t\t} else if (role == \"stillraw\") {\n\nSorry for making master move too fast :-)\n\n> +\t\t\t\troles.push_back(StreamRole::StillCaptureRaw);\n> \t\t\t} else {\n> \t\t\t\tstd::cerr << \"Unknown stream role \"\n> \t\t\t\t\t << role << std::endl;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6B2260411\n\tfor ;\n\tTue, 24 Mar 2020 17:35:36 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 254E7308;\n\tTue, 24 Mar 2020 17:35:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tLiNYX38\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585067736;\n\tbh=IrWpWARofEAlqxPFk7hVORRkVpOdlsM9rEwTuXxEyW8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tLiNYX38HuO+O66j05RmrzM+ZriHwjnFejFOCY5lVkty3kiq35rQeRZNf5rB/XiZG\n\tz1TO1QuUpEsZoCHOk6oFUHuT4IcqdVTKcNugid5zxCAPvGGzs3FVOm5PDDLs2f8aSn\n\tgmYfYfK6IsOlx7HF0PrUGrR2drYqYVy9W+4a3L/I=","Date":"Tue, 24 Mar 2020 18:35:34 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200324163534.GC20997@pendragon.ideasonboard.com>","References":"<20200324155145.3896183-1-niklas.soderlund@ragnatech.se>\n\t<20200324155145.3896183-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200324155145.3896183-3-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/7] cam: Add option to capture\n\tStillCaptureRaw stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 16:35:37 -0000"}}]