{"id":3296,"url":"https://patchwork.libcamera.org/api/patches/3296/?format=json","web_url":"https://patchwork.libcamera.org/patch/3296/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200324103012.9678-2-laurent.pinchart@ideasonboard.com>","date":"2020-03-24T10:30:12","name":"[libcamera-devel,2/2] qcam: main_window: Prefer stream formats that don't require conversion","commit_ref":"e74885c870a8d13736b422f8faadec3339cc588d","pull_url":null,"state":"accepted","archived":false,"hash":"773767eaa9a8f110f79c8bab33aa10aa981ec45e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3296/mbox/","series":[{"id":768,"url":"https://patchwork.libcamera.org/api/series/768/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=768","date":"2020-03-24T10:30:12","name":"[libcamera-devel,1/2] qcam: viewfinder: Report the natively supported pixel formats","version":1,"mbox":"https://patchwork.libcamera.org/series/768/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3296/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3296/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FB7460414\n\tfor ;\n\tTue, 24 Mar 2020 11:30:18 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8BF8A58\n\tfor ;\n\tTue, 24 Mar 2020 11:30:17 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585045818;\n\tbh=qBu5c2Vl6DLPx3jdP+oopcjapdSMronTHRiolXMSQKo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=vtwM0FqVYLANRJYn0dfvNx/nDgAXWf8WPSVZ8q7DF0+QyGPeDYsYE5fE6/ZI5E+lT\n\t8cRIbTejjiZ7c8mJNislt7xG71o7O4Iql02Nr8Rs7UaRLL+bdplOWS/Oow1faie38O\n\tblhy1meK6ofhCXbN+d7s0QkV0+TfrjBqcgWolQWo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 24 Mar 2020 12:30:12 +0200","Message-Id":"<20200324103012.9678-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200324103012.9678-1-laurent.pinchart@ideasonboard.com>","References":"<20200324103012.9678-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] qcam: main_window: Prefer stream\n\tformats that don't require conversion","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 10:30:18 -0000"},"content":"Query the viewfinder for the formats it supports natively, and select\none of them for the stream if possible.\n\nSigned-off-by: Laurent Pinchart \n---\n src/qcam/main_window.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex b13660bccb25..565732698a5e 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -297,6 +297,19 @@ int MainWindow::startCapture()\n \t\t}\n \t}\n \n+\t/* Use a format supported by the viewfinder if available. */\n+\tstd::vector formats = cfg.formats().pixelformats();\n+\tfor (const PixelFormat &format : viewfinder_->nativeFormats()) {\n+\t\tauto match = std::find_if(formats.begin(), formats.end(),\n+\t\t\t\t\t [&](const PixelFormat &f) {\n+\t\t\t\t\t\t return f == format;\n+\t\t\t\t\t });\n+\t\tif (match != formats.end()) {\n+\t\t\tcfg.pixelFormat = format;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n \tCameraConfiguration::Status validation = config_->validate();\n \tif (validation == CameraConfiguration::Invalid) {\n \t\tqWarning() << \"Failed to create valid camera configuration\";\n","prefixes":["libcamera-devel","2/2"]}