[{"id":4254,"web_url":"https://patchwork.libcamera.org/comment/4254/","msgid":"<06187131-67ca-4c87-4971-4560c4b89727@ideasonboard.com>","date":"2020-03-24T11:57:52","subject":"Re: [libcamera-devel] [PATCH] qcam: viewfinder: Print message to\n\treport format converter usage","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 24/03/2020 09:41, Laurent Pinchart wrote:\n> Print an info message when initializing the viewfinder to report if the\n> format converter is used or if zero-copy is enabled. This is useful to\n> notify of a possible impact on performances.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/viewfinder.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> index c7c6d099dfba..df5ee5ee7b83 100644\n> --- a/src/qcam/viewfinder.cpp\n> +++ b/src/qcam/viewfinder.cpp\n> @@ -56,6 +56,11 @@ int ViewFinder::setFormat(const libcamera::PixelFormat &format,\n> \t\t\treturn ret;\n> \n> \t\timage_ = QImage(size, QImage::Format_RGB32);\n> +\n> +\t\tqInfo() << \"Using software format conversion from\"\n> +\t\t\t<< format.toString().c_str();\n\n\nShould this message state the conversion from and to?\n\nPerhaps it doesn't matter too much at the moment as we always convert to\nthe same destination format - but perhaps that might differ if we have\nmultiple compatible 'native' formats?\n\n> +\t} else {\n> +\t\tqInfo() << \"Zero-copy enabled\";\n\nReviewed-by: Kieran Bingham \n\n> \t}\n> \n> \tformat_ = format;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4033A60412\n\tfor ;\n\tTue, 24 Mar 2020 12:57:57 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57445308;\n\tTue, 24 Mar 2020 12:57:56 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585051076;\n\tbh=iudos30HvSpbc/3JW52tP0BNqXTFVLNeGRMX4uYHxVo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=AigcU9yBgOxYeJHVj/T3kANBKLtfGxI9EjKChYAd8PVYzY2nIbvTNh/c+K7W16jhX\n\tsJAIt9NyfLI2FyDG2Zt4a2bm+6f255aIz/EwB9JzpGuoGEaKE7D1hAoIkQ7EjG93r/\n\tfqqlOvElVhcy7+dayxbLKiG45O8rZn1/Ty1tbais=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200324094112.704-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<06187131-67ca-4c87-4971-4560c4b89727@ideasonboard.com>","Date":"Tue, 24 Mar 2020 11:57:52 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200324094112.704-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: viewfinder: Print message to\n\treport format converter usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 11:57:57 -0000"}},{"id":4258,"web_url":"https://patchwork.libcamera.org/comment/4258/","msgid":"<20200324124905.GC24971@pendragon.ideasonboard.com>","date":"2020-03-24T12:49:05","subject":"Re: [libcamera-devel] [PATCH] qcam: viewfinder: Print message to\n\treport format converter usage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Mar 24, 2020 at 11:57:52AM +0000, Kieran Bingham wrote:\n> Hi Laurent,\n> \n> On 24/03/2020 09:41, Laurent Pinchart wrote:\n> > Print an info message when initializing the viewfinder to report if the\n> > format converter is used or if zero-copy is enabled. This is useful to\n> > notify of a possible impact on performances.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/qcam/viewfinder.cpp | 5 +++++\n> > 1 file changed, 5 insertions(+)\n> > \n> > diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> > index c7c6d099dfba..df5ee5ee7b83 100644\n> > --- a/src/qcam/viewfinder.cpp\n> > +++ b/src/qcam/viewfinder.cpp\n> > @@ -56,6 +56,11 @@ int ViewFinder::setFormat(const libcamera::PixelFormat &format,\n> > \t\t\treturn ret;\n> > \n> > \t\timage_ = QImage(size, QImage::Format_RGB32);\n> > +\n> > +\t\tqInfo() << \"Using software format conversion from\"\n> > +\t\t\t<< format.toString().c_str();\n> \n> Should this message state the conversion from and to?\n> \n> Perhaps it doesn't matter too much at the moment as we always convert to\n> the same destination format - but perhaps that might differ if we have\n> multiple compatible 'native' formats?\n\nI initially had a message that stated \"... to QImage::Format_RGB32\", but\nthought it was overkill as that's fixed. If we end up picking the\ndestination format dynamically, we can update the message then.\n\n> \n> > +\t} else {\n> > +\t\tqInfo() << \"Zero-copy enabled\";\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \t}\n> > \n> > \tformat_ = format;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FF1260412\n\tfor ;\n\tTue, 24 Mar 2020 13:49:07 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02384308;\n\tTue, 24 Mar 2020 13:49:06 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585054147;\n\tbh=ILR938Zr87kf5b4u9J4N2JB9zzHEUoliVgexQz8Xdyg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LBAeCJnu7v7p2nSfDlYrqyHJUBCFuYQ1n7NLkb/NkauOzQSRIIk39nl6YN8BMBS5O\n\tQ0cHkxbu8nLFMy2lwmGbq+VBNRXd2im0NSTJ77HyJw+32xF2dXvHYusiSAeqMM3eMC\n\tNNlrx24cHlSrvbwYL/Ju7J1qrI/cUNIXHAg9mnJA=","Date":"Tue, 24 Mar 2020 14:49:05 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200324124905.GC24971@pendragon.ideasonboard.com>","References":"<20200324094112.704-1-laurent.pinchart@ideasonboard.com>\n\t<06187131-67ca-4c87-4971-4560c4b89727@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<06187131-67ca-4c87-4971-4560c4b89727@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] qcam: viewfinder: Print message to\n\treport format converter usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 12:49:07 -0000"}}]