{"id":3295,"url":"https://patchwork.libcamera.org/api/patches/3295/?format=json","web_url":"https://patchwork.libcamera.org/patch/3295/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200324094112.704-1-laurent.pinchart@ideasonboard.com>","date":"2020-03-24T09:41:12","name":"[libcamera-devel] qcam: viewfinder: Print message to report format converter usage","commit_ref":"798b7ac9692746ea9df15923f3b00b622c7f2ed4","pull_url":null,"state":"accepted","archived":false,"hash":"29b6912b1c7bcfe3ab38d4f3a479c66fa34c089a","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3295/mbox/","series":[{"id":767,"url":"https://patchwork.libcamera.org/api/series/767/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=767","date":"2020-03-24T09:41:12","name":"[libcamera-devel] qcam: viewfinder: Print message to report format converter usage","version":1,"mbox":"https://patchwork.libcamera.org/series/767/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3295/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3295/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A91B60414\n\tfor ;\n\tTue, 24 Mar 2020 10:41:17 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FD68308\n\tfor ;\n\tTue, 24 Mar 2020 10:41:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585042876;\n\tbh=kp4RgOS1YVp9bE542upXiAYHmEdxaecwpFrgQxjokws=;\n\th=From:To:Subject:Date:From;\n\tb=qhI8ni6At1DsRDYWPFSW9JDju6oudnmqeq7dHVNqa4iy+kPfHcwfgGQhywtoUrS0M\n\tzkO2tTYFD266rhmiFIelAEVFx+JeMVeZuop2vbLyvp5dCkqPYmQxC6s7ngLpWQuVst\n\t+sB/YtaVNc9wV1q+rxnWHhLJQCAiEdYlYZK1nwdc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 24 Mar 2020 11:41:12 +0200","Message-Id":"<20200324094112.704-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] qcam: viewfinder: Print message to report\n\tformat converter usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 09:41:17 -0000"},"content":"Print an info message when initializing the viewfinder to report if the\nformat converter is used or if zero-copy is enabled. This is useful to\nnotify of a possible impact on performances.\n\nSigned-off-by: Laurent Pinchart \n---\n src/qcam/viewfinder.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\nindex c7c6d099dfba..df5ee5ee7b83 100644\n--- a/src/qcam/viewfinder.cpp\n+++ b/src/qcam/viewfinder.cpp\n@@ -56,6 +56,11 @@ int ViewFinder::setFormat(const libcamera::PixelFormat &format,\n \t\t\treturn ret;\n \n \t\timage_ = QImage(size, QImage::Format_RGB32);\n+\n+\t\tqInfo() << \"Using software format conversion from\"\n+\t\t\t<< format.toString().c_str();\n+\t} else {\n+\t\tqInfo() << \"Zero-copy enabled\";\n \t}\n \n \tformat_ = format;\n","prefixes":["libcamera-devel"]}