[{"id":4249,"web_url":"https://patchwork.libcamera.org/comment/4249/","msgid":"<20200324081608.6fwsd6jdavf7ncl3@uno.localdomain>","date":"2020-03-24T08:16:08","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: ipu3: Use\n\tparameterized StreamConfiguration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kaaira\n\nOn Tue, Mar 24, 2020 at 04:59:01AM +0530, Kaaira Gupta wrote:\n> Replace default constructor StreamConfiguration() by it's parameterized\n> counterpart by using StreamFormats in generateConfiguration() in\n ^ nit: double space\n\n> ipu3.\n>\n> Signed-off-by: Kaaira Gupta \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 7feb44c..fe25cab 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -400,9 +400,17 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t};\n>\n> \tconfig = new IPU3CameraConfiguration(camera, data);\n> +\tstd::map> pixelformats;\n> +\n> +\t/*\n> +\t * The driver supports only one pixel format.\n> +\t * Size range is kept maximum.\n\nSeems like you are constructing a SizeRange with a single size, not a\nrange :(\n\nAnd the IPU3 supports a larger resolution than this, I'm sure :)\n\n> +\t */\n> +\tpixelformats[PixelFormat(DRM_FORMAT_NV12)] = {SizeRange{{ 2560, 1920 }}};\n>\n> \tfor (const StreamRole role : roles) {\n> -\t\tStreamConfiguration cfg = {};\n> +\t\tStreamFormats format(pixelformats);\n> +\t\tStreamConfiguration cfg(format);\n> \t\tIPU3Stream *stream = nullptr;\n>\n> \t\tcfg.pixelFormat = PixelFormat(DRM_FORMAT_NV12);\n> --\n> 2.17.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9316160411\n\tfor ;\n\tTue, 24 Mar 2020 09:13:10 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 35738100004;\n\tTue, 24 Mar 2020 08:13:08 +0000 (UTC)"],"Date":"Tue, 24 Mar 2020 09:16:08 +0100","From":"Jacopo Mondi ","To":"Kaaira Gupta ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tHelen Koike ,\n\tVaishali Thakkar ","Message-ID":"<20200324081608.6fwsd6jdavf7ncl3@uno.localdomain>","References":"<20200323232901.29169-1-kgupta@es.iitr.ac.in>\n\t<20200323232901.29169-4-kgupta@es.iitr.ac.in>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200323232901.29169-4-kgupta@es.iitr.ac.in>","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: ipu3: Use\n\tparameterized StreamConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 08:13:10 -0000"}},{"id":4261,"web_url":"https://patchwork.libcamera.org/comment/4261/","msgid":"<20200324132256.GA13324@kaaira-HP-Pavilion-Notebook>","date":"2020-03-24T13:22:56","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: ipu3: Use\n\tparameterized StreamConfiguration","submitter":{"id":39,"url":"https://patchwork.libcamera.org/api/people/39/","name":"Kaaira Gupta","email":"kgupta@es.iitr.ac.in"},"content":"On Tue, Mar 24, 2020 at 04:59:01AM +0530, Kaaira Gupta wrote:\n> Replace default constructor StreamConfiguration() by it's parameterized\n> counterpart by using StreamFormats in generateConfiguration() in\n> ipu3.\n> \n> Signed-off-by: Kaaira Gupta \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 7feb44c..fe25cab 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -400,9 +400,17 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t};\n> \n> \tconfig = new IPU3CameraConfiguration(camera, data);\n> +\tstd::map> pixelformats;\n> +\n> +\t/*\n> +\t * The driver supports only one pixel format.\n> +\t * Size range is kept maximum.\n\nI did not get the reply in my mailbox, hence I'll ask the question in\nreply to this :D\njmondi: I passed a single size because the validate() uses a single size\nas well..which is the maximum height and width..as ipu3 can only\ndownscale.\n\nAlso, if this isn't the maximum, how do I find out what is?\n\n> +\t */\n> +\tpixelformats[PixelFormat(DRM_FORMAT_NV12)] = {SizeRange{{ 2560, 1920 }}};\n> \n> \tfor (const StreamRole role : roles) {\n> -\t\tStreamConfiguration cfg = {};\n> +\t\tStreamFormats format(pixelformats);\n> +\t\tStreamConfiguration cfg(format);\n> \t\tIPU3Stream *stream = nullptr;\n> \n> \t\tcfg.pixelFormat = PixelFormat(DRM_FORMAT_NV12);\n> -- \n> 2.17.1\n>","headers":{"Return-Path":"","Received":["from mail-pg1-x541.google.com (mail-pg1-x541.google.com\n\t[IPv6:2607:f8b0:4864:20::541])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D8DF60411\n\tfor ;\n\tTue, 24 Mar 2020 14:23:05 +0100 (CET)","by mail-pg1-x541.google.com with SMTP id d17so8448361pgo.0\n\tfor ;\n\tTue, 24 Mar 2020 06:23:05 -0700 (PDT)","from kaaira-HP-Pavilion-Notebook ([103.113.213.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ta8sm14613356pgg.79.2020.03.24.06.23.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 24 Mar 2020 06:23:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:date:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=bidcbMvxCet/Zb03nX8y2KMCMaHeHmFyDClrzeubP9c=;\n\tb=A0KCZw11D2cqBmm9q4ICRCqwSNjeH0ty4kSOtTDAXvZDu/hhMUCWLUn/rTjx6+k4Cu\n\tlRQMfBHG7SYMGpssz5k+EnL3ZBT0UuqjrSkrnFVEUyHyzp+k8McOkeKLuLXrZCHnq2Tr\n\tAh+TeX+7GcGvSanLJUnEs2oAfld6VCxPwuZL4n6gyYk1wnFmyGWUlvZLYSe609fSn0Js\n\tVA0iPPX5WmSMqV7ex65kcK6mahfY1VPLgH6l8gzx5FOcBKQNiLfZhzCYNSxcXDWMPEvD\n\tba3TW8HTSVPwL+cs0AIiaVzpGIXXzovkX6SwbvOu1eZ8bMooUcehUMcUeTSPmspxxxGo\n\tcpCw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:date:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=bidcbMvxCet/Zb03nX8y2KMCMaHeHmFyDClrzeubP9c=;\n\tb=LQuQqV/KxOi5V6IkxAD9cHNV0fmQL1tNkPcDj8Ibkq9OCf3CkskBTXgR/7GsvQev6p\n\tJNE8AIZbyqfvxrGmR1LiT7V4l5Z7v2eMUc17FNQsJJtHi602ySD66k297XF8pYFyxFxu\n\t+fEynmZdYspNviOLfNaO2SxsHgVHd2UMgbVHqldebwDPgV7/vBomiIeodhIYsJ9gOmJz\n\t14CQ3Tch1UMZqRF8gUhrRs1eL8b7XdGI8fO7ZPYGd0lGvfb3aDYHhPafjaZC31MQqjW/\n\t4xspCKZgwuR7jE0TMdvnqyIpdQ6wBNXqLzvOkcYexNcMbui1nflTUPa+pEqJ8E/J65Q/\n\tMpAA==","X-Gm-Message-State":"ANhLgQ0oZv/OOrngRUQt0xsd2J9Sln+XOPuQwxcEn8RkamT3rKNV8yY0\n\tEImfCnaCmYonQQ5cvhtgIVpbmw==","X-Google-Smtp-Source":"ADFU+vs5oln9NihfLp2rO1HYqC9n9SDlPR/X8hbRjR6FNNIvNN2RDLONDj5RBI8GMFIMJaxpTnCpWQ==","X-Received":"by 2002:a63:e809:: with SMTP id\n\ts9mr25602297pgh.214.1585056183784; \n\tTue, 24 Mar 2020 06:23:03 -0700 (PDT)","From":"Kaaira Gupta ","X-Google-Original-From":"Kaaira Gupta ","Date":"Tue, 24 Mar 2020 18:52:56 +0530","To":"jacopo@jmondi.org","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tHelen Koike ,\n\tVaishali Thakkar ","Message-ID":"<20200324132256.GA13324@kaaira-HP-Pavilion-Notebook>","References":"<20200323232901.29169-1-kgupta@es.iitr.ac.in>\n\t<20200323232901.29169-4-kgupta@es.iitr.ac.in>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20200323232901.29169-4-kgupta@es.iitr.ac.in>","User-Agent":"Mutt/1.9.4 (2018-02-28)","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: ipu3: Use\n\tparameterized StreamConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 13:23:05 -0000"}}]