{"id":3275,"url":"https://patchwork.libcamera.org/api/patches/3275/?format=json","web_url":"https://patchwork.libcamera.org/patch/3275/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200323173559.21109-10-laurent.pinchart@ideasonboard.com>","date":"2020-03-23T17:35:47","name":"[libcamera-devel,v2,09/21] qcam: main_window: Don't print message when saving a picture","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c292b3f34f1b85f0d0e7d784b7c122966d909eb4","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3275/mbox/","series":[{"id":762,"url":"https://patchwork.libcamera.org/api/series/762/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=762","date":"2020-03-23T17:35:38","name":"qcam: Bypass format conversion when not required","version":2,"mbox":"https://patchwork.libcamera.org/series/762/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3275/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3275/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7AF6D62CD0\n\tfor ;\n\tMon, 23 Mar 2020 18:36:19 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 199F3A31\n\tfor ;\n\tMon, 23 Mar 2020 18:36:19 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584984979;\n\tbh=8JiUz19Lt9JOUVAhxgL6yLvl19nOjqPLuLXY7pVwuhY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fhG42jsv0Pv6InU0TFxgGekfQakApGWKe0FkxpDkiRe7VCRN+//5QXxH6Hn4kV18n\n\tUZL/RhiFJeX8lMsvltxexcmT2HkOTAOyHLW6/W5HAcrpX9O47mIBKbPJxOTvBPC+RF\n\tMDVhtXPAIg63OXyWqx3wVA4J9wQpWvZZxqLiePxs=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Mar 2020 19:35:47 +0200","Message-Id":"<20200323173559.21109-10-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>","References":"<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 09/21] qcam: main_window: Don't print\n\tmessage when saving a picture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 17:36:22 -0000"},"content":"When saving a picture, the application prints a message on cout. This\nisn't necessary and doesn't really help with debugging or diagnostics,\nremove it.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/qcam/main_window.cpp | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 6afb7714c457..7959c17cd610 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -410,9 +410,6 @@ void MainWindow::saveImageAs()\n \n \tQString filename = QFileDialog::getSaveFileName(this, \"Save Image\", defaultPath,\n \t\t\t\t\t\t\t\"Image Files (*.png *.jpg *.jpeg)\");\n-\n-\tstd::cout << \"Save image to \" << filename.toStdString() << std::endl;\n-\n \tif (filename.isEmpty())\n \t\treturn;\n \n","prefixes":["libcamera-devel","v2","09/21"]}