{"id":3268,"url":"https://patchwork.libcamera.org/api/patches/3268/?format=json","web_url":"https://patchwork.libcamera.org/patch/3268/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200323173559.21109-3-laurent.pinchart@ideasonboard.com>","date":"2020-03-23T17:35:40","name":"[libcamera-devel,v2,02/21] qcam: Ensure headers are self-contained","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a976668d33fc293f2028ede63dcece248bb8bf75","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3268/mbox/","series":[{"id":762,"url":"https://patchwork.libcamera.org/api/series/762/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=762","date":"2020-03-23T17:35:38","name":"qcam: Bypass format conversion when not required","version":2,"mbox":"https://patchwork.libcamera.org/series/762/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3268/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3268/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F75060417\n\tfor ;\n\tMon, 23 Mar 2020 18:36:17 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA29A308\n\tfor ;\n\tMon, 23 Mar 2020 18:36:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584984976;\n\tbh=s+Iqz9znRqWSmtq7lW1qfOQxYUTrpz6t6L+xF8J61r0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UY6ozwK8m5FUZVEPUOQ2u7wfS7ttutcQGbfulPgQENbAGHjVcmrHv/Gln/LfaePyp\n\tF1Ow6cAGlJK7x5hlDypLmPKfWJ1B07WoFSQD9lzucd8sjmV0UWrQdcvRAkXulRjPuz\n\taTYQJOF5iHViHi+prM4gRYmuyBUYXvJlvpbyTq4U=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Mar 2020 19:35:40 +0200","Message-Id":"<20200323173559.21109-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>","References":"<20200323173559.21109-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 02/21] qcam: Ensure headers are\n\tself-contained","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 17:36:17 -0000"},"content":"Include the headers corresponding to each compile unit at the very first\nline to ensure they are self-contained.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/qcam/format_converter.cpp | 4 ++--\n src/qcam/main_window.cpp | 3 ++-\n src/qcam/viewfinder.cpp | 3 ++-\n 3 files changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\nindex 483f7c1edfce..d8962a28c06c 100644\n--- a/src/qcam/format_converter.cpp\n+++ b/src/qcam/format_converter.cpp\n@@ -5,12 +5,12 @@\n * format_convert.cpp - qcam - Convert buffer to RGB\n */\n \n+#include \"format_converter.h\"\n+\n #include \n \n #include \n \n-#include \"format_converter.h\"\n-\n #define RGBSHIFT\t\t8\n #ifndef MAX\n #define MAX(a,b)\t\t((a)>(b)?(a):(b))\ndiff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 6f4f1cd770bd..66aaf40c5d45 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -5,6 +5,8 @@\n * main_window.cpp - qcam - Main application window\n */\n \n+#include \"main_window.h\"\n+\n #include \n #include \n #include \n@@ -25,7 +27,6 @@\n #include \n #include \n \n-#include \"main_window.h\"\n #include \"viewfinder.h\"\n \n using namespace libcamera;\ndiff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\nindex e9d5cc1e014b..f4602f07c5d2 100644\n--- a/src/qcam/viewfinder.cpp\n+++ b/src/qcam/viewfinder.cpp\n@@ -5,13 +5,14 @@\n * viewfinder.cpp - qcam - Viewfinder\n */\n \n+#include \"viewfinder.h\"\n+\n #include \n #include \n #include \n #include \n \n #include \"format_converter.h\"\n-#include \"viewfinder.h\"\n \n ViewFinder::ViewFinder(QWidget *parent)\n \t: QWidget(parent), format_(0), width_(0), height_(0), image_(nullptr)\n","prefixes":["libcamera-devel","v2","02/21"]}