[{"id":4239,"web_url":"https://patchwork.libcamera.org/comment/4239/","msgid":"<447a668a-02d0-2fad-342d-f68e0cf6c4e2@ideasonboard.com>","date":"2020-03-23T17:28:05","subject":"Re: [libcamera-devel] [PATCH 20/21] qcam: viewfinder: Display icon\n\twhen stopping capture","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/03/2020 14:22, Laurent Pinchart wrote:\n> When stopping capture, display an icon instead of the last frame. This\n> is required to be able to release the last buffer when the viewfinder\n> operators in zero-copy mode.\n\nThis is actually really nice because it displays an icon when streams\nfail to start (I have a secondary IR camera on my laptop which is not\nsupported, and this icon shows up if I try to stream that camera).\n\nHowever, it does remove a 'feature' that I had before, where we could\n'pause' a running stream and have the last image still visible which\ncould be useful when trying to catch a picture to save perhaps.\n\nBut in general, I think this is a really good feature, and displaying an\nicon for a stream which can't run is more valuable than a pause feature\nwhich could be added later...\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/qcam/assets/feathericons/feathericons.qrc |  1 +\n>  src/qcam/main_window.cpp                      |  2 +\n>  src/qcam/viewfinder.cpp                       | 44 ++++++++++++++++++-\n>  src/qcam/viewfinder.h                         |  8 ++++\n>  4 files changed, 54 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/assets/feathericons/feathericons.qrc b/src/qcam/assets/feathericons/feathericons.qrc\n> index 6ca3a846803c..c4eb7a0be688 100644\n> --- a/src/qcam/assets/feathericons/feathericons.qrc\n> +++ b/src/qcam/assets/feathericons/feathericons.qrc\n> @@ -1,5 +1,6 @@\n>  <!DOCTYPE RCC><RCC version=\"1.0\">\n>  <qresource>\n> +<file>./camera-off.svg</file>\n>  <file>./play-circle.svg</file>\n>  <file>./save.svg</file>\n>  <file>./stop-circle.svg</file>\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index b68e171c5e01..a77d10bb7076 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -412,6 +412,8 @@ void MainWindow::stopCapture()\n>  \tif (!isCapturing_)\n>  \t\treturn;\n>  \n> +\tviewfinder_->stop();\n> +\n>  \tint ret = camera_->stop();\n>  \tif (ret)\n>  \t\tqInfo() << \"Failed to stop capture\";\n> diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> index 4c35659e24aa..a40b2b400daa 100644\n> --- a/src/qcam/viewfinder.cpp\n> +++ b/src/qcam/viewfinder.cpp\n> @@ -20,6 +20,7 @@\n>  ViewFinder::ViewFinder(QWidget *parent)\n>  \t: QWidget(parent), buffer_(nullptr)\n>  {\n> +\ticon_ = QIcon(\":camera-off.svg\");\n>  }\n>  \n>  ViewFinder::~ViewFinder()\n> @@ -89,6 +90,18 @@ void ViewFinder::render(libcamera::FrameBuffer *buffer, MappedBuffer *map)\n>  \t\trenderComplete(buffer);\n>  }\n>  \n> +void ViewFinder::stop()\n> +{\n> +\timage_ = QImage();\n> +\n> +\tif (buffer_) {\n> +\t\trenderComplete(buffer_);\n> +\t\tbuffer_ = nullptr;\n> +\t}\n> +\n> +\tupdate();\n> +}\n> +\n>  QImage ViewFinder::getCurrentImage()\n>  {\n>  \tQMutexLocker locker(&mutex_);\n> @@ -99,7 +112,36 @@ QImage ViewFinder::getCurrentImage()\n>  void ViewFinder::paintEvent(QPaintEvent *)\n>  {\n>  \tQPainter painter(this);\n> -\tpainter.drawImage(rect(), image_, image_.rect());\n> +\n> +\t/* If we have an image, draw it. */\n> +\tif (!image_.isNull()) {\n> +\t\tpainter.drawImage(rect(), image_, image_.rect());\n> +\t\treturn;\n> +\t}\n> +\n> +\t/*\n> +\t * Otherwise, draw the camera stopped icon. Render it to the pixmap if\n> +\t * the size has changed.\n> +\t */\n> +\tconstexpr int margin = 20;\n> +\n> +\tif (vfSize_ != size() || pixmap_.isNull()) {\n> +\t\tvfSize_ = size();\n> +\n> +\t\tQSize pixmapSize{ 1, 1 };\n> +\t\tpixmapSize.scale(vfSize_.shrunkBy({ margin, margin, margin, margin }),\n\nshrunkBy fails to compile on QT 5.12.2 ... but you already know (and\nhave fixed) that...\n\n\n> +\t\t\t\t Qt::KeepAspectRatio);\n> +\t\tpixmap_ = icon_.pixmap(pixmapSize);\n> +\t}\n> +\n> +\tQPoint point{ margin, margin };\n> +\tif (pixmap_.width() < width() - 2 * margin)\n> +\t\tpoint.setX((width() - pixmap_.width()) / 2);\n> +\telse\n> +\t\tpoint.setY((height() - pixmap_.height()) / 2);\n> +\n> +\tpainter.setBackgroundMode(Qt::OpaqueMode);\n> +\tpainter.drawPixmap(point, pixmap_);\n>  }\n>  \n>  QSize ViewFinder::sizeHint() const\n> diff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\n> index b5153160f70e..1a27f99ea202 100644\n> --- a/src/qcam/viewfinder.h\n> +++ b/src/qcam/viewfinder.h\n> @@ -9,6 +9,7 @@\n>  \n>  #include <stddef.h>\n>  \n> +#include <QIcon>\n>  #include <QImage>\n>  #include <QMutex>\n>  #include <QSize>\n> @@ -36,6 +37,7 @@ public:\n>  \n>  \tint setFormat(const libcamera::PixelFormat &format, const QSize &size);\n>  \tvoid render(libcamera::FrameBuffer *buffer, MappedBuffer *map);\n> +\tvoid stop();\n>  \n>  \tQImage getCurrentImage();\n>  \n> @@ -52,6 +54,12 @@ private:\n>  \tlibcamera::PixelFormat format_;\n>  \tQSize size_;\n>  \n> +\t/* Camera stopped icon */\n> +\tQSize vfSize_;\n> +\tQIcon icon_;\n> +\tQPixmap pixmap_;\n> +\n> +\t/* Buffer and render image */\n>  \tlibcamera::FrameBuffer *buffer_;\n>  \tQImage image_;\n>  \tQMutex mutex_; /* Prevent concurrent access to image_ */\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBB7160417\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:28:08 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56F2F308;\n\tMon, 23 Mar 2020 18:28:08 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584984488;\n\tbh=bERWCVCMaiaTHGjchyfVLloPc/3NxiMVG/8MrAIEKEA=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=daYtT3y+ZR8Aq6NBIoUMlqwBezrkv0QoWscjBnnRB0gv5ANjV6DYMdXd1BuDeqLbc\n\tM/AGxuNE/u/Y+BlpYHd9j2vnHFOJdVt+XVxhGtnlFgbhH42HDSvcHrXRa1RaWwrTmV\n\tNq4+4Y3whTF/xvfy1MvY4Y7WLSgQ3JGhErzDuP/c=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>\n\t<20200323142205.28342-21-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<447a668a-02d0-2fad-342d-f68e0cf6c4e2@ideasonboard.com>","Date":"Mon, 23 Mar 2020 17:28:05 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200323142205.28342-21-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 20/21] qcam: viewfinder: Display icon\n\twhen stopping capture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 23 Mar 2020 17:28:08 -0000"}},{"id":4240,"web_url":"https://patchwork.libcamera.org/comment/4240/","msgid":"<20200323172935.GT4768@pendragon.ideasonboard.com>","date":"2020-03-23T17:29:35","subject":"Re: [libcamera-devel] [PATCH 20/21] qcam: viewfinder: Display icon\n\twhen stopping capture","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 23, 2020 at 05:28:05PM +0000, Kieran Bingham wrote:\n> On 23/03/2020 14:22, Laurent Pinchart wrote:\n> > When stopping capture, display an icon instead of the last frame. This\n> > is required to be able to release the last buffer when the viewfinder\n> > operators in zero-copy mode.\n> \n> This is actually really nice because it displays an icon when streams\n> fail to start (I have a secondary IR camera on my laptop which is not\n> supported, and this icon shows up if I try to stream that camera).\n> \n> However, it does remove a 'feature' that I had before, where we could\n> 'pause' a running stream and have the last image still visible which\n> could be useful when trying to catch a picture to save perhaps.\n> \n> But in general, I think this is a really good feature, and displaying an\n> icon for a stream which can't run is more valuable than a pause feature\n> which could be added later...\n\nI agree with you, let's take a bit of time to design the pause feature\ncorrectly on top of this.\n\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  src/qcam/assets/feathericons/feathericons.qrc |  1 +\n> >  src/qcam/main_window.cpp                      |  2 +\n> >  src/qcam/viewfinder.cpp                       | 44 ++++++++++++++++++-\n> >  src/qcam/viewfinder.h                         |  8 ++++\n> >  4 files changed, 54 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/qcam/assets/feathericons/feathericons.qrc b/src/qcam/assets/feathericons/feathericons.qrc\n> > index 6ca3a846803c..c4eb7a0be688 100644\n> > --- a/src/qcam/assets/feathericons/feathericons.qrc\n> > +++ b/src/qcam/assets/feathericons/feathericons.qrc\n> > @@ -1,5 +1,6 @@\n> >  <!DOCTYPE RCC><RCC version=\"1.0\">\n> >  <qresource>\n> > +<file>./camera-off.svg</file>\n> >  <file>./play-circle.svg</file>\n> >  <file>./save.svg</file>\n> >  <file>./stop-circle.svg</file>\n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index b68e171c5e01..a77d10bb7076 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -412,6 +412,8 @@ void MainWindow::stopCapture()\n> >  \tif (!isCapturing_)\n> >  \t\treturn;\n> >  \n> > +\tviewfinder_->stop();\n> > +\n> >  \tint ret = camera_->stop();\n> >  \tif (ret)\n> >  \t\tqInfo() << \"Failed to stop capture\";\n> > diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> > index 4c35659e24aa..a40b2b400daa 100644\n> > --- a/src/qcam/viewfinder.cpp\n> > +++ b/src/qcam/viewfinder.cpp\n> > @@ -20,6 +20,7 @@\n> >  ViewFinder::ViewFinder(QWidget *parent)\n> >  \t: QWidget(parent), buffer_(nullptr)\n> >  {\n> > +\ticon_ = QIcon(\":camera-off.svg\");\n> >  }\n> >  \n> >  ViewFinder::~ViewFinder()\n> > @@ -89,6 +90,18 @@ void ViewFinder::render(libcamera::FrameBuffer *buffer, MappedBuffer *map)\n> >  \t\trenderComplete(buffer);\n> >  }\n> >  \n> > +void ViewFinder::stop()\n> > +{\n> > +\timage_ = QImage();\n> > +\n> > +\tif (buffer_) {\n> > +\t\trenderComplete(buffer_);\n> > +\t\tbuffer_ = nullptr;\n> > +\t}\n> > +\n> > +\tupdate();\n> > +}\n> > +\n> >  QImage ViewFinder::getCurrentImage()\n> >  {\n> >  \tQMutexLocker locker(&mutex_);\n> > @@ -99,7 +112,36 @@ QImage ViewFinder::getCurrentImage()\n> >  void ViewFinder::paintEvent(QPaintEvent *)\n> >  {\n> >  \tQPainter painter(this);\n> > -\tpainter.drawImage(rect(), image_, image_.rect());\n> > +\n> > +\t/* If we have an image, draw it. */\n> > +\tif (!image_.isNull()) {\n> > +\t\tpainter.drawImage(rect(), image_, image_.rect());\n> > +\t\treturn;\n> > +\t}\n> > +\n> > +\t/*\n> > +\t * Otherwise, draw the camera stopped icon. Render it to the pixmap if\n> > +\t * the size has changed.\n> > +\t */\n> > +\tconstexpr int margin = 20;\n> > +\n> > +\tif (vfSize_ != size() || pixmap_.isNull()) {\n> > +\t\tvfSize_ = size();\n> > +\n> > +\t\tQSize pixmapSize{ 1, 1 };\n> > +\t\tpixmapSize.scale(vfSize_.shrunkBy({ margin, margin, margin, margin }),\n> \n> shrunkBy fails to compile on QT 5.12.2 ... but you already know (and\n> have fixed) that...\n> \n> > +\t\t\t\t Qt::KeepAspectRatio);\n> > +\t\tpixmap_ = icon_.pixmap(pixmapSize);\n> > +\t}\n> > +\n> > +\tQPoint point{ margin, margin };\n> > +\tif (pixmap_.width() < width() - 2 * margin)\n> > +\t\tpoint.setX((width() - pixmap_.width()) / 2);\n> > +\telse\n> > +\t\tpoint.setY((height() - pixmap_.height()) / 2);\n> > +\n> > +\tpainter.setBackgroundMode(Qt::OpaqueMode);\n> > +\tpainter.drawPixmap(point, pixmap_);\n> >  }\n> >  \n> >  QSize ViewFinder::sizeHint() const\n> > diff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\n> > index b5153160f70e..1a27f99ea202 100644\n> > --- a/src/qcam/viewfinder.h\n> > +++ b/src/qcam/viewfinder.h\n> > @@ -9,6 +9,7 @@\n> >  \n> >  #include <stddef.h>\n> >  \n> > +#include <QIcon>\n> >  #include <QImage>\n> >  #include <QMutex>\n> >  #include <QSize>\n> > @@ -36,6 +37,7 @@ public:\n> >  \n> >  \tint setFormat(const libcamera::PixelFormat &format, const QSize &size);\n> >  \tvoid render(libcamera::FrameBuffer *buffer, MappedBuffer *map);\n> > +\tvoid stop();\n> >  \n> >  \tQImage getCurrentImage();\n> >  \n> > @@ -52,6 +54,12 @@ private:\n> >  \tlibcamera::PixelFormat format_;\n> >  \tQSize size_;\n> >  \n> > +\t/* Camera stopped icon */\n> > +\tQSize vfSize_;\n> > +\tQIcon icon_;\n> > +\tQPixmap pixmap_;\n> > +\n> > +\t/* Buffer and render image */\n> >  \tlibcamera::FrameBuffer *buffer_;\n> >  \tQImage image_;\n> >  \tQMutex mutex_; /* Prevent concurrent access to image_ */","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 843C760417\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 18:29:45 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B454308;\n\tMon, 23 Mar 2020 18:29:45 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584984585;\n\tbh=/NyXxO/GbKwEx54FrxuHYABXrNzZpSY7cRuV8PIFN+o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PJgAtuCZkK5wFAQE84fxlFjuUISW8f7vUAbWg/GbivPmcAzTbPP5CW868b939l66V\n\tjRnmRpWV3wd4ORPogeNVOmKb26c7dJZpjk4hHXuJKqOTPDp4OFhAdWNcQ72BWEtEA8\n\thAPgJsBM3jGnfhVPIy1x4fBK+7b5STfTFYOBCk34=","Date":"Mon, 23 Mar 2020 19:29:35 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200323172935.GT4768@pendragon.ideasonboard.com>","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>\n\t<20200323142205.28342-21-laurent.pinchart@ideasonboard.com>\n\t<447a668a-02d0-2fad-342d-f68e0cf6c4e2@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<447a668a-02d0-2fad-342d-f68e0cf6c4e2@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 20/21] qcam: viewfinder: Display icon\n\twhen stopping capture","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 23 Mar 2020 17:29:45 -0000"}}]