[{"id":4231,"web_url":"https://patchwork.libcamera.org/comment/4231/","msgid":"","date":"2020-03-23T17:06:24","subject":"Re: [libcamera-devel] [PATCH 14/21] qcam: viewfinder: Move\n\tmulti-planar check into viewfinder","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/03/2020 14:21, Laurent Pinchart wrote:\n> The lack of support for multiplanar buffers comes from the viewfinder.\n> Move the corresponding check from MainWindow.\n\nPresumably this limitation can be removed with the FormatConvertor too?\n(Particularly when we get a hardware accelerated format convertor...)\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main_window.cpp | 7 +------\n> src/qcam/main_window.h | 2 +-\n> src/qcam/viewfinder.cpp | 6 ++++++\n> 3 files changed, 8 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index c0feb91a6fb1..ad0d6bf4f3e5 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -519,14 +519,9 @@ void MainWindow::processCapture()\n> \tqueueRequest(buffer);\n> }\n> \n> -int MainWindow::display(FrameBuffer *buffer)\n> +void MainWindow::display(FrameBuffer *buffer)\n> {\n> -\tif (buffer->planes().size() != 1)\n> -\t\treturn -EINVAL;\n> -\n> \tviewfinder_->display(buffer, &mappedBuffers_[buffer]);\n> -\n> -\treturn 0;\n> }\n> \n> void MainWindow::queueRequest(FrameBuffer *buffer)\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index 0918ae5307d8..03db761b58e4 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -65,7 +65,7 @@ private:\n> \n> \tvoid requestComplete(Request *request);\n> \tvoid processCapture();\n> -\tint display(FrameBuffer *buffer);\n> +\tvoid display(FrameBuffer *buffer);\n> \tvoid queueRequest(FrameBuffer *buffer);\n> \n> \t/* UI elements */\n> diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> index d00edc33dfb7..b8feabd5d189 100644\n> --- a/src/qcam/viewfinder.cpp\n> +++ b/src/qcam/viewfinder.cpp\n> @@ -11,6 +11,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \"format_converter.h\"\n> \n> @@ -27,6 +28,11 @@ ViewFinder::~ViewFinder()\n> void ViewFinder::display(const libcamera::FrameBuffer *buffer,\n> \t\t\t MappedBuffer *map)\n> {\n> +\tif (buffer->planes().size() != 1) {\n> +\t\tqWarning() << \"Multi-planar buffers are not supported\";\n> +\t\treturn;\n> +\t}\n> +\n> \tQMutexLocker locker(&mutex_);\n> \n> \t/*\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82FC060417\n\tfor ;\n\tMon, 23 Mar 2020 18:06:28 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD5F1308;\n\tMon, 23 Mar 2020 18:06:27 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584983188;\n\tbh=6N5K0PpEacPJ1Pu076UR9C/t+P479ZFDhP5tBDxGIOE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=UqQorqj0ZoCFWn/JYVZvE0k7k1AOcF6IJNV5F8AAUkfqF0dU2Y06Uby++ksYds24C\n\tB/4Z6C5x6VpZKPFu+gAtXts73YZpWd4QbrS1VeDScclHkFvwQMXC0AtGRmonLyNBgK\n\tGmqnpvnB5fVSiLWVUOK87/k2KZXctnSt00VG2Ckk=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>\n\t<20200323142205.28342-15-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 23 Mar 2020 17:06:24 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200323142205.28342-15-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 14/21] qcam: viewfinder: Move\n\tmulti-planar check into viewfinder","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 17:06:28 -0000"}},{"id":4233,"web_url":"https://patchwork.libcamera.org/comment/4233/","msgid":"<20200323170944.GR4768@pendragon.ideasonboard.com>","date":"2020-03-23T17:09:44","subject":"Re: [libcamera-devel] [PATCH 14/21] qcam: viewfinder: Move\n\tmulti-planar check into viewfinder","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 23, 2020 at 05:06:24PM +0000, Kieran Bingham wrote:\n> On 23/03/2020 14:21, Laurent Pinchart wrote:\n> > The lack of support for multiplanar buffers comes from the viewfinder.\n> > Move the corresponding check from MainWindow.\n> \n> Presumably this limitation can be removed with the FormatConvertor too?\n> (Particularly when we get a hardware accelerated format convertor...)\n\nExactly. When we'll have multiple viewfinder implementations it will be\nup to them to report what they support. We'll need an API for that, but\none thing at a time :-)\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/qcam/main_window.cpp | 7 +------\n> > src/qcam/main_window.h | 2 +-\n> > src/qcam/viewfinder.cpp | 6 ++++++\n> > 3 files changed, 8 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index c0feb91a6fb1..ad0d6bf4f3e5 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -519,14 +519,9 @@ void MainWindow::processCapture()\n> > \tqueueRequest(buffer);\n> > }\n> > \n> > -int MainWindow::display(FrameBuffer *buffer)\n> > +void MainWindow::display(FrameBuffer *buffer)\n> > {\n> > -\tif (buffer->planes().size() != 1)\n> > -\t\treturn -EINVAL;\n> > -\n> > \tviewfinder_->display(buffer, &mappedBuffers_[buffer]);\n> > -\n> > -\treturn 0;\n> > }\n> > \n> > void MainWindow::queueRequest(FrameBuffer *buffer)\n> > diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> > index 0918ae5307d8..03db761b58e4 100644\n> > --- a/src/qcam/main_window.h\n> > +++ b/src/qcam/main_window.h\n> > @@ -65,7 +65,7 @@ private:\n> > \n> > \tvoid requestComplete(Request *request);\n> > \tvoid processCapture();\n> > -\tint display(FrameBuffer *buffer);\n> > +\tvoid display(FrameBuffer *buffer);\n> > \tvoid queueRequest(FrameBuffer *buffer);\n> > \n> > \t/* UI elements */\n> > diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> > index d00edc33dfb7..b8feabd5d189 100644\n> > --- a/src/qcam/viewfinder.cpp\n> > +++ b/src/qcam/viewfinder.cpp\n> > @@ -11,6 +11,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > \n> > #include \"format_converter.h\"\n> > \n> > @@ -27,6 +28,11 @@ ViewFinder::~ViewFinder()\n> > void ViewFinder::display(const libcamera::FrameBuffer *buffer,\n> > \t\t\t MappedBuffer *map)\n> > {\n> > +\tif (buffer->planes().size() != 1) {\n> > +\t\tqWarning() << \"Multi-planar buffers are not supported\";\n> > +\t\treturn;\n> > +\t}\n> > +\n> > \tQMutexLocker locker(&mutex_);\n> > \n> > \t/*\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5B1E60417\n\tfor ;\n\tMon, 23 Mar 2020 18:09:53 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66242308;\n\tMon, 23 Mar 2020 18:09:53 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584983393;\n\tbh=IpIMu5gFpGUFFbtJQ+o6EVocC7M3qTpsmgg/9pRkYaI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BBreIEcXhPNhDUGT4uEKf9Qqrrbt2yUs8Ysa8pLwMQi23Vk9YeAc1s1ncotKzs+SF\n\t+PA/t7SItRS/dqfh+0xNloezxzimK4K9tQC+5/SACe1Oef/mU626gwu7UlSzq4NrwZ\n\tQVdSU23NPh6gojrlYuSWQ8DeeiTtsxccFr/7iEYg=","Date":"Mon, 23 Mar 2020 19:09:44 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200323170944.GR4768@pendragon.ideasonboard.com>","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>\n\t<20200323142205.28342-15-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 14/21] qcam: viewfinder: Move\n\tmulti-planar check into viewfinder","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 17:09:54 -0000"}}]