[{"id":4211,"web_url":"https://patchwork.libcamera.org/comment/4211/","msgid":"<246395d8-b294-b43d-be1b-0553e1f0c440@ideasonboard.com>","date":"2020-03-23T15:18:57","subject":"Re: [libcamera-devel] [PATCH 07/21] qcam: main_window: Use icons\n\tfrom system icon theme","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/03/2020 14:21, Laurent Pinchart wrote:\n> Use the system icon theme by default, falling back to custom icons if no\n> theme is available.\n\nAha, I hadn't realised it was easy enough to obtain theme icons.\n\nI 'think' I prefer this except...\n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main_window.cpp | 12 +++++++++---\n> 1 file changed, 9 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 86f92360a1a9..14baf7ec4c2e 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -97,7 +97,9 @@ int MainWindow::createToolbars()\n> \t/* Disable right click context menu. */\n> \ttoolbar_->setContextMenuPolicy(Qt::PreventContextMenu);\n> \n> -\taction = toolbar_->addAction(QIcon(\":x-circle.svg\"), \"Quit\");\n> +\taction = toolbar_->addAction(QIcon::fromTheme(\"application-exit\",\n> +\t\t\t\t\t\t QIcon(\":x-circle.svg\")),\n> +\t\t\t\t \"Quit\");\n> \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n> \n> \t/* Camera selection. */\n> @@ -112,12 +114,16 @@ int MainWindow::createToolbars()\n> \n> \ttoolbar_->addSeparator();\n> \n> -\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"Start Capture\");\n> +\taction = toolbar_->addAction(QIcon::fromTheme(\"media-playback-start\",\n> +\t\t\t\t\t\t QIcon(\":play-circle.svg\")),\n> +\t\t\t\t \"Start Capture\");\n> \taction->setCheckable(true);\n> \tconnect(action, &QAction::toggled, this, &MainWindow::toggleCapture);\n> \tstartStopAction_ = action;\n> \n> -\taction = toolbar_->addAction(QIcon(\":save.svg\"), \"saveAs\");\n> +\taction = toolbar_->addAction(QIcon::fromTheme(\"document-save-as\",\n\nThis now looks like a 'document' instead of a disk ... ;-(\n\nBut maybe that's not the end of the world, and a potential restriction\nof the theme more than this patch ... so ...\n\nReviewed-by: Kieran Bingham \n\n\n\n> +\t\t\t\t\t\t QIcon(\":save.svg\")),\n> +\t\t\t\t \"Save As...\");\n> \tconnect(action, &QAction::triggered, this, &MainWindow::saveImageAs);\n> \n> \treturn 0;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18BBE60417\n\tfor ;\n\tMon, 23 Mar 2020 16:19:02 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71C68308;\n\tMon, 23 Mar 2020 16:19:00 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584976741;\n\tbh=YEnezZhm2rMjharIJ4U6ZBBBS+0J52sajdaqUe2/rV4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=dGfo+iv+eihrOdd/Tdnbxudzvj44+YRRdM6bXHN/W1UWIRqI88r54xxe3m4ApbNMq\n\tMjY2GiznZJZ5EGLTp2Nuw8snmnp0XMxomazgOZVxwArEtn9awzQwAY5gmCHKGc/6a9\n\tZv5V9SASGmYpo94/iRGGgQzwU/K/LmaXjREiTNkE=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>\n\t<20200323142205.28342-8-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<246395d8-b294-b43d-be1b-0553e1f0c440@ideasonboard.com>","Date":"Mon, 23 Mar 2020 15:18:57 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200323142205.28342-8-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 07/21] qcam: main_window: Use icons\n\tfrom system icon theme","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 15:19:02 -0000"}},{"id":4227,"web_url":"https://patchwork.libcamera.org/comment/4227/","msgid":"<20200323161927.GP4768@pendragon.ideasonboard.com>","date":"2020-03-23T16:19:27","subject":"Re: [libcamera-devel] [PATCH 07/21] qcam: main_window: Use icons\n\tfrom system icon theme","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 23, 2020 at 03:18:57PM +0000, Kieran Bingham wrote:\n> On 23/03/2020 14:21, Laurent Pinchart wrote:\n> > Use the system icon theme by default, falling back to custom icons if no\n> > theme is available.\n> \n> Aha, I hadn't realised it was easy enough to obtain theme icons.\n> \n> I 'think' I prefer this except...\n> \n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/qcam/main_window.cpp | 12 +++++++++---\n> > 1 file changed, 9 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index 86f92360a1a9..14baf7ec4c2e 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -97,7 +97,9 @@ int MainWindow::createToolbars()\n> > \t/* Disable right click context menu. */\n> > \ttoolbar_->setContextMenuPolicy(Qt::PreventContextMenu);\n> > \n> > -\taction = toolbar_->addAction(QIcon(\":x-circle.svg\"), \"Quit\");\n> > +\taction = toolbar_->addAction(QIcon::fromTheme(\"application-exit\",\n> > +\t\t\t\t\t\t QIcon(\":x-circle.svg\")),\n> > +\t\t\t\t \"Quit\");\n> > \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n> > \n> > \t/* Camera selection. */\n> > @@ -112,12 +114,16 @@ int MainWindow::createToolbars()\n> > \n> > \ttoolbar_->addSeparator();\n> > \n> > -\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"Start Capture\");\n> > +\taction = toolbar_->addAction(QIcon::fromTheme(\"media-playback-start\",\n> > +\t\t\t\t\t\t QIcon(\":play-circle.svg\")),\n> > +\t\t\t\t \"Start Capture\");\n> > \taction->setCheckable(true);\n> > \tconnect(action, &QAction::toggled, this, &MainWindow::toggleCapture);\n> > \tstartStopAction_ = action;\n> > \n> > -\taction = toolbar_->addAction(QIcon(\":save.svg\"), \"saveAs\");\n> > +\taction = toolbar_->addAction(QIcon::fromTheme(\"document-save-as\",\n> \n> This now looks like a 'document' instead of a disk ... ;-(\n\nI'm sorry :-S\n\n> But maybe that's not the end of the world, and a potential restriction\n> of the theme more than this patch ... so ...\n\n>From the screenshot you've shown me, I would say it's a bug in the icon\ntheme, not a restriction.\n\n> Reviewed-by: Kieran Bingham \n> \n> > +\t\t\t\t\t\t QIcon(\":save.svg\")),\n> > +\t\t\t\t \"Save As...\");\n> > \tconnect(action, &QAction::triggered, this, &MainWindow::saveImageAs);\n> > \n> > \treturn 0;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22BEF60429\n\tfor ;\n\tMon, 23 Mar 2020 17:19:37 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FE45308;\n\tMon, 23 Mar 2020 17:19:36 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584980376;\n\tbh=mEnXbrQwLLiAHE1mQBaHYAVRxxRrO0TtP1qS5BgqV3U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EZe/PGtquUzUeLVso9IKOjQSjvvuCbqKwJZMg/GBp+im9oUPg0pulPp20Yod9yv1B\n\tmzDsONsE8SnGBV4L9pRL9a4OeqGsQ7Pu4VF64NVpR2r6jOo7rQsIn3R52MBWSoLDuc\n\tUY5rzy3tN82LnyNDTnSk2WjhTvqyfN/HsFOpn6ww=","Date":"Mon, 23 Mar 2020 18:19:27 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200323161927.GP4768@pendragon.ideasonboard.com>","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>\n\t<20200323142205.28342-8-laurent.pinchart@ideasonboard.com>\n\t<246395d8-b294-b43d-be1b-0553e1f0c440@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<246395d8-b294-b43d-be1b-0553e1f0c440@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 07/21] qcam: main_window: Use icons\n\tfrom system icon theme","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 16:19:37 -0000"}}]