[{"id":4210,"web_url":"https://patchwork.libcamera.org/comment/4210/","msgid":"<cf40aac7-fab7-eae4-71fa-3621bdcf7af9@ideasonboard.com>","date":"2020-03-23T15:03:51","subject":"Re: [libcamera-devel] [PATCH 06/21] qcam: main_window: Replace\n\tstart and stop actions with a toggle action","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/03/2020 14:21, Laurent Pinchart wrote:\n> The main window toolbar contains a start button and a stop button. This\n> allows starting an already started camera (which is currently not\n> handled and results in an error) or stopping an already stopped camera.\n> Replace the two actions with a single start/stop toggle action,\n> preventing UI misuse and reducing confusion.\n\nOh - I was actually using this as a test already :-) - I have used it to\nstart a running stream, and stop a stopped stream.\n\nIt even found a bug in a pipeline already - but perhaps that just\nhighlights that we need a pipeline validation tool already, so it's not\nparticularly a requirement of the GUI interface.\n\n> \n\nOtherwise a question below - but:\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/qcam/main_window.cpp | 30 ++++++++++++++++++++----------\n>  src/qcam/main_window.h   |  9 ++++++---\n>  2 files changed, 26 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index afd8b9c413f5..86f92360a1a9 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -63,11 +63,10 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n>  \tadjustSize();\n>  \n>  \tret = openCamera();\n> -\tif (!ret)\n> -\t\tret = startCapture();\n> -\n>  \tif (ret < 0)\n>  \t\tquit();\n> +\n> +\tstartStopAction_->setChecked(true);\n>  }\n>  \n>  MainWindow::~MainWindow()\n> @@ -113,11 +112,10 @@ int MainWindow::createToolbars()\n>  \n>  \ttoolbar_->addSeparator();\n>  \n> -\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"start\");\n> -\tconnect(action, &QAction::triggered, this, &MainWindow::startCapture);\n> -\n> -\taction = toolbar_->addAction(QIcon(\":stop-circle.svg\"), \"stop\");\n> -\tconnect(action, &QAction::triggered, this, &MainWindow::stopCapture);\n> +\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"Start Capture\");\n> +\taction->setCheckable(true);\n> +\tconnect(action, &QAction::toggled, this, &MainWindow::toggleCapture);\n> +\tstartStopAction_ = action;\n>  \n>  \taction = toolbar_->addAction(QIcon(\":save.svg\"), \"saveAs\");\n>  \tconnect(action, &QAction::triggered, this, &MainWindow::saveImageAs);\n> @@ -159,12 +157,12 @@ void MainWindow::switchCamera(int index)\n>  \n>  \tstd::cout << \"Switching to camera \" << cam->name() << std::endl;\n>  \n> -\tstopCapture();\n> +\tstartStopAction_->setChecked(false);\n>  \n>  \tcamera_->release();\n>  \tcamera_ = cam;\n>  \n> -\tstartCapture();\n> +\tstartStopAction_->setChecked(true);\n>  }\n>  \n>  std::string MainWindow::chooseCamera()\n> @@ -217,6 +215,17 @@ int MainWindow::openCamera()\n>  \treturn 0;\n>  }\n>  \n> +void MainWindow::toggleCapture(bool start)\n> +{\n> +\tif (start) {\n> +\t\tstartCapture();\n> +\t\tstartStopAction_->setText(\"Stop Capture\");\n> +\t} else {\n> +\t\tstopCapture();\n> +\t\tstartStopAction_->setText(\"Start Capture\");\n\nShouldn't this update the icon to reflect the change in state somehow?\n\n> +\t}\n> +}\n> +\n>  int MainWindow::startCapture()\n>  {\n>  \tint ret;\n> @@ -322,6 +331,7 @@ int MainWindow::startCapture()\n>  \t}\n>  \n>  \tisCapturing_ = true;\n> +\n>  \treturn 0;\n>  \n>  error_disconnect:\n> diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> index c623120d5894..3d8d02b44696 100644\n> --- a/src/qcam/main_window.h\n> +++ b/src/qcam/main_window.h\n> @@ -26,6 +26,7 @@\n>  \n>  using namespace libcamera;\n>  \n> +class QAction;\n>  class ViewFinder;\n>  \n>  enum {\n> @@ -49,9 +50,7 @@ private Q_SLOTS:\n>  \tvoid updateTitle();\n>  \n>  \tvoid switchCamera(int index);\n> -\n> -\tint startCapture();\n> -\tvoid stopCapture();\n> +\tvoid toggleCapture(bool start);\n>  \n>  \tvoid saveImageAs();\n>  \n> @@ -60,6 +59,9 @@ private:\n>  \tstd::string chooseCamera();\n>  \tint openCamera();\n>  \n> +\tint startCapture();\n> +\tvoid stopCapture();\n> +\n>  \tvoid requestComplete(Request *request);\n>  \tvoid processCapture();\n>  \tint display(FrameBuffer *buffer);\n> @@ -87,6 +89,7 @@ private:\n>  \tQQueue<FrameBuffer *> doneQueue_;\n>  \n>  \tQToolBar *toolbar_;\n> +\tQAction *startStopAction_;\n>  \tViewFinder *viewfinder_;\n>  \tstd::map<int, std::pair<void *, unsigned int>> mappedBuffers_;\n>  };\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD39B60413\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 16:03:54 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E44A308;\n\tMon, 23 Mar 2020 16:03:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584975834;\n\tbh=hDPi9uRdww1jQKQra1SNE6oiVKbiy3dnkOxgYEPNAN8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ZsaifKHiK3/ey7laL+1kSfu+VMN0YLonyfqrn5zn/fZe4M1nu9kplzprpJnGFE+lh\n\tgclsYvTnVn01uDOn2mcc+vrZ4lcW8HdNWcPAgFEq3S5kBBI52+gy+9St1YJ3WJriRa\n\tz9Oh4i0QHIy8xc+U0CXl0WDdIpYrRAVHQgNVwibA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>\n\t<20200323142205.28342-7-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<cf40aac7-fab7-eae4-71fa-3621bdcf7af9@ideasonboard.com>","Date":"Mon, 23 Mar 2020 15:03:51 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200323142205.28342-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 06/21] qcam: main_window: Replace\n\tstart and stop actions with a toggle action","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 23 Mar 2020 15:03:54 -0000"}},{"id":4221,"web_url":"https://patchwork.libcamera.org/comment/4221/","msgid":"<20200323155055.GO4768@pendragon.ideasonboard.com>","date":"2020-03-23T15:50:55","subject":"Re: [libcamera-devel] [PATCH 06/21] qcam: main_window: Replace\n\tstart and stop actions with a toggle action","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 23, 2020 at 03:03:51PM +0000, Kieran Bingham wrote:\n> On 23/03/2020 14:21, Laurent Pinchart wrote:\n> > The main window toolbar contains a start button and a stop button. This\n> > allows starting an already started camera (which is currently not\n> > handled and results in an error) or stopping an already stopped camera.\n> > Replace the two actions with a single start/stop toggle action,\n> > preventing UI misuse and reducing confusion.\n> \n> Oh - I was actually using this as a test already :-) - I have used it to\n> start a running stream, and stop a stopped stream.\n\nThat's something that should be caught by unit tests though.\n\n> It even found a bug in a pipeline already - but perhaps that just\n> highlights that we need a pipeline validation tool already, so it's not\n> particularly a requirement of the GUI interface.\n\nYes, we also need a pipeline validation tool :-)\n\n> > \n> \n> Otherwise a question below - but:\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  src/qcam/main_window.cpp | 30 ++++++++++++++++++++----------\n> >  src/qcam/main_window.h   |  9 ++++++---\n> >  2 files changed, 26 insertions(+), 13 deletions(-)\n> > \n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index afd8b9c413f5..86f92360a1a9 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -63,11 +63,10 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> >  \tadjustSize();\n> >  \n> >  \tret = openCamera();\n> > -\tif (!ret)\n> > -\t\tret = startCapture();\n> > -\n> >  \tif (ret < 0)\n> >  \t\tquit();\n> > +\n> > +\tstartStopAction_->setChecked(true);\n> >  }\n> >  \n> >  MainWindow::~MainWindow()\n> > @@ -113,11 +112,10 @@ int MainWindow::createToolbars()\n> >  \n> >  \ttoolbar_->addSeparator();\n> >  \n> > -\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"start\");\n> > -\tconnect(action, &QAction::triggered, this, &MainWindow::startCapture);\n> > -\n> > -\taction = toolbar_->addAction(QIcon(\":stop-circle.svg\"), \"stop\");\n> > -\tconnect(action, &QAction::triggered, this, &MainWindow::stopCapture);\n> > +\taction = toolbar_->addAction(QIcon(\":play-circle.svg\"), \"Start Capture\");\n> > +\taction->setCheckable(true);\n> > +\tconnect(action, &QAction::toggled, this, &MainWindow::toggleCapture);\n> > +\tstartStopAction_ = action;\n> >  \n> >  \taction = toolbar_->addAction(QIcon(\":save.svg\"), \"saveAs\");\n> >  \tconnect(action, &QAction::triggered, this, &MainWindow::saveImageAs);\n> > @@ -159,12 +157,12 @@ void MainWindow::switchCamera(int index)\n> >  \n> >  \tstd::cout << \"Switching to camera \" << cam->name() << std::endl;\n> >  \n> > -\tstopCapture();\n> > +\tstartStopAction_->setChecked(false);\n> >  \n> >  \tcamera_->release();\n> >  \tcamera_ = cam;\n> >  \n> > -\tstartCapture();\n> > +\tstartStopAction_->setChecked(true);\n> >  }\n> >  \n> >  std::string MainWindow::chooseCamera()\n> > @@ -217,6 +215,17 @@ int MainWindow::openCamera()\n> >  \treturn 0;\n> >  }\n> >  \n> > +void MainWindow::toggleCapture(bool start)\n> > +{\n> > +\tif (start) {\n> > +\t\tstartCapture();\n> > +\t\tstartStopAction_->setText(\"Stop Capture\");\n> > +\t} else {\n> > +\t\tstopCapture();\n> > +\t\tstartStopAction_->setText(\"Start Capture\");\n> \n> Shouldn't this update the icon to reflect the change in state somehow?\n\nI have mixed feelings, so now that you ask, I'll fix this.\n\n> > +\t}\n> > +}\n> > +\n> >  int MainWindow::startCapture()\n> >  {\n> >  \tint ret;\n> > @@ -322,6 +331,7 @@ int MainWindow::startCapture()\n> >  \t}\n> >  \n> >  \tisCapturing_ = true;\n> > +\n> >  \treturn 0;\n> >  \n> >  error_disconnect:\n> > diff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\n> > index c623120d5894..3d8d02b44696 100644\n> > --- a/src/qcam/main_window.h\n> > +++ b/src/qcam/main_window.h\n> > @@ -26,6 +26,7 @@\n> >  \n> >  using namespace libcamera;\n> >  \n> > +class QAction;\n> >  class ViewFinder;\n> >  \n> >  enum {\n> > @@ -49,9 +50,7 @@ private Q_SLOTS:\n> >  \tvoid updateTitle();\n> >  \n> >  \tvoid switchCamera(int index);\n> > -\n> > -\tint startCapture();\n> > -\tvoid stopCapture();\n> > +\tvoid toggleCapture(bool start);\n> >  \n> >  \tvoid saveImageAs();\n> >  \n> > @@ -60,6 +59,9 @@ private:\n> >  \tstd::string chooseCamera();\n> >  \tint openCamera();\n> >  \n> > +\tint startCapture();\n> > +\tvoid stopCapture();\n> > +\n> >  \tvoid requestComplete(Request *request);\n> >  \tvoid processCapture();\n> >  \tint display(FrameBuffer *buffer);\n> > @@ -87,6 +89,7 @@ private:\n> >  \tQQueue<FrameBuffer *> doneQueue_;\n> >  \n> >  \tQToolBar *toolbar_;\n> > +\tQAction *startStopAction_;\n> >  \tViewFinder *viewfinder_;\n> >  \tstd::map<int, std::pair<void *, unsigned int>> mappedBuffers_;\n> >  };","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEAA060417\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2020 16:51:04 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DB9C308;\n\tMon, 23 Mar 2020 16:51:04 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584978664;\n\tbh=cvJBl2DvP47ma9dBPkW7MNvoDej8GNrPVU8O/fwZX90=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OAYOh/iWAx2Y1AXpzUvJXGwHSO/Gd/RK893BzTEvV+NBGV10XfvzfNCbCOgNiGGNl\n\t3DMEjrPfpO4qxHqrxUkrLYsmehfTTkH+9LDqQMli1w8tIZyYlb9wYIwBcKBvZvaPkZ\n\tHnub5bK325iBMo09bRMHHacRAYaCvdv0x9w1L/0o=","Date":"Mon, 23 Mar 2020 17:50:55 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200323155055.GO4768@pendragon.ideasonboard.com>","References":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>\n\t<20200323142205.28342-7-laurent.pinchart@ideasonboard.com>\n\t<cf40aac7-fab7-eae4-71fa-3621bdcf7af9@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<cf40aac7-fab7-eae4-71fa-3621bdcf7af9@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 06/21] qcam: main_window: Replace\n\tstart and stop actions with a toggle action","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 23 Mar 2020 15:51:05 -0000"}}]