[{"id":4180,"web_url":"https://patchwork.libcamera.org/comment/4180/","msgid":"<20200323104025.GD4768@pendragon.ideasonboard.com>","date":"2020-03-23T10:40:25","subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"This should obviously have s/qcam/cam/ in the subject line.\n\nOn Mon, Mar 23, 2020 at 12:39:38PM +0200, Laurent Pinchart wrote:\n> The code handling the stream role option retrieves the role property and\n> converts it to a string in every branch. Cache it and use the cached\n> value.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/main.cpp | 16 ++++++++++------\n> 1 file changed, 10 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 2a0a830ff371..56059ab6c047 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -209,17 +209,21 @@ int CamApp::prepareConfig()\n> \t\tfor (auto const &value : streamOptions) {\n> \t\t\tKeyValueParser::Options opt = value.toKeyValues();\n> \n> -\t\t\tif (!opt.isSet(\"role\")) {\n> -\t\t\t\troles.push_back(StreamRole::VideoRecording);\n> -\t\t\t} else if (opt[\"role\"].toString() == \"viewfinder\") {\n> +\t\t\tstd::string role;\n> +\t\t\tif (opt.isSet(\"role\"))\n> +\t\t\t\trole = opt[\"role\"].toString();\n> +\t\t\telse\n> +\t\t\t\trole = \"viewfinder\";\n> +\n> +\t\t\tif (role == \"viewfinder\") {\n> \t\t\t\troles.push_back(StreamRole::Viewfinder);\n> -\t\t\t} else if (opt[\"role\"].toString() == \"video\") {\n> +\t\t\t} else if (role == \"video\") {\n> \t\t\t\troles.push_back(StreamRole::VideoRecording);\n> -\t\t\t} else if (opt[\"role\"].toString() == \"still\") {\n> +\t\t\t} else if (role == \"still\") {\n> \t\t\t\troles.push_back(StreamRole::StillCapture);\n> \t\t\t} else {\n> \t\t\t\tstd::cerr << \"Unknown stream role \"\n> -\t\t\t\t\t << opt[\"role\"].toString() << std::endl;\n> +\t\t\t\t\t << role << std::endl;\n> \t\t\t\treturn -EINVAL;\n> \t\t\t}\n> \t\t}","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C31C60412\n\tfor ;\n\tMon, 23 Mar 2020 11:40:34 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 026F3308\n\tfor ;\n\tMon, 23 Mar 2020 11:40:33 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584960034;\n\tbh=my8vaNt18SVPX0SQKR9gha3/lNqAR/E8KSuShjVJahQ=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=WH0j4nDeiN9QZZ3UGhi7VH2Co4ovc65MLD3b/wv9moIfbBzb0VXk51095H3Vc0VDV\n\tDfwaNzzIZo5DsBU7jVPR5P0egEyTvVkzyy4RwGidLjOAQSIPmn2su4fWNIb536iUTf\n\tsjYz7Ut46EMK5d1K44+CeQuF8cQjM7vB7mrSLmBM=","Date":"Mon, 23 Mar 2020 12:40:25 +0200","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200323104025.GD4768@pendragon.ideasonboard.com>","References":"<20200323103938.11026-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200323103938.11026-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 10:40:34 -0000"}},{"id":4181,"web_url":"https://patchwork.libcamera.org/comment/4181/","msgid":"<06520ac5-9090-869e-8bf6-5a812393cbc5@ideasonboard.com>","date":"2020-03-23T11:00:47","subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/03/2020 10:40, Laurent Pinchart wrote:\n> This should obviously have s/qcam/cam/ in the subject line.\n> \n> On Mon, Mar 23, 2020 at 12:39:38PM +0200, Laurent Pinchart wrote:\n>> The code handling the stream role option retrieves the role property and\n>> converts it to a string in every branch. Cache it and use the cached\n>> value.\n>>\n\nTrivial suggestion, but otherwise LGTM.\n\nReviewed-by: Kieran Bingham \n\n>> Signed-off-by: Laurent Pinchart \n>> ---\n>> src/cam/main.cpp | 16 ++++++++++------\n>> 1 file changed, 10 insertions(+), 6 deletions(-)\n>>\n>> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n>> index 2a0a830ff371..56059ab6c047 100644\n>> --- a/src/cam/main.cpp\n>> +++ b/src/cam/main.cpp\n>> @@ -209,17 +209,21 @@ int CamApp::prepareConfig()\n>> \t\tfor (auto const &value : streamOptions) {\n>> \t\t\tKeyValueParser::Options opt = value.toKeyValues();\n>> \n>> -\t\t\tif (!opt.isSet(\"role\")) {\n>> -\t\t\t\troles.push_back(StreamRole::VideoRecording);\n>> -\t\t\t} else if (opt[\"role\"].toString() == \"viewfinder\") {\n>> +\t\t\tstd::string role;\n>> +\t\t\tif (opt.isSet(\"role\"))\n>> +\t\t\t\trole = opt[\"role\"].toString();\n>> +\t\t\telse\n>> +\t\t\t\trole = \"viewfinder\";\n\nThat almost looks worth a tertiary to make it a single line?\n role = opt.isSet(\"role\") ? opt[\"role\"].toString() : \"viewfinder\";\n\n?\n>> +\n>> +\t\t\tif (role == \"viewfinder\") {\n>> \t\t\t\troles.push_back(StreamRole::Viewfinder);\n>> -\t\t\t} else if (opt[\"role\"].toString() == \"video\") {\n>> +\t\t\t} else if (role == \"video\") {\n>> \t\t\t\troles.push_back(StreamRole::VideoRecording);\n>> -\t\t\t} else if (opt[\"role\"].toString() == \"still\") {\n>> +\t\t\t} else if (role == \"still\") {\n>> \t\t\t\troles.push_back(StreamRole::StillCapture);\n>> \t\t\t} else {\n>> \t\t\t\tstd::cerr << \"Unknown stream role \"\n>> -\t\t\t\t\t << opt[\"role\"].toString() << std::endl;\n>> +\t\t\t\t\t << role << std::endl;\n>> \t\t\t\treturn -EINVAL;\n>> \t\t\t}\n>> \t\t}\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25F1D60413\n\tfor ;\n\tMon, 23 Mar 2020 12:00:51 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A6D4308;\n\tMon, 23 Mar 2020 12:00:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584961250;\n\tbh=eNUBZICn/t0beChWB61whYlT7q+VftgPDDiAtMgFC1k=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=jh8cjHKt3MCSe+eyPvGM1nhu2e0ljxEUeVSMM/3r0b4Prm9EE+lmKNPemaQcpy1aX\n\thm2CDMG3U3735i6Tmj849NidT27WzmojUwVCOtmEsWvEHzouIfM/7lgcj08IZK+2Gq\n\trf1UFZn/nkAZFyfk266F3vZAoGq+TL3Ne09VDig8=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200323103938.11026-1-laurent.pinchart@ideasonboard.com>\n\t<20200323104025.GD4768@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<06520ac5-9090-869e-8bf6-5a812393cbc5@ideasonboard.com>","Date":"Mon, 23 Mar 2020 11:00:47 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200323104025.GD4768@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 11:00:51 -0000"}},{"id":4186,"web_url":"https://patchwork.libcamera.org/comment/4186/","msgid":"<20200323111100.GA12103@pendragon.ideasonboard.com>","date":"2020-03-23T11:11:00","subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 23, 2020 at 11:00:47AM +0000, Kieran Bingham wrote:\n> On 23/03/2020 10:40, Laurent Pinchart wrote:\n> > This should obviously have s/qcam/cam/ in the subject line.\n> > \n> > On Mon, Mar 23, 2020 at 12:39:38PM +0200, Laurent Pinchart wrote:\n> >> The code handling the stream role option retrieves the role property and\n> >> converts it to a string in every branch. Cache it and use the cached\n> >> value.\n> \n> Trivial suggestion, but otherwise LGTM.\n> \n> Reviewed-by: Kieran Bingham \n> \n> >> Signed-off-by: Laurent Pinchart \n> >> ---\n> >> src/cam/main.cpp | 16 ++++++++++------\n> >> 1 file changed, 10 insertions(+), 6 deletions(-)\n> >>\n> >> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> >> index 2a0a830ff371..56059ab6c047 100644\n> >> --- a/src/cam/main.cpp\n> >> +++ b/src/cam/main.cpp\n> >> @@ -209,17 +209,21 @@ int CamApp::prepareConfig()\n> >> \t\tfor (auto const &value : streamOptions) {\n> >> \t\t\tKeyValueParser::Options opt = value.toKeyValues();\n> >> \n> >> -\t\t\tif (!opt.isSet(\"role\")) {\n> >> -\t\t\t\troles.push_back(StreamRole::VideoRecording);\n> >> -\t\t\t} else if (opt[\"role\"].toString() == \"viewfinder\") {\n> >> +\t\t\tstd::string role;\n> >> +\t\t\tif (opt.isSet(\"role\"))\n> >> +\t\t\t\trole = opt[\"role\"].toString();\n> >> +\t\t\telse\n> >> +\t\t\t\trole = \"viewfinder\";\n> \n> That almost looks worth a tertiary to make it a single line?\n> role = opt.isSet(\"role\") ? opt[\"role\"].toString() : \"viewfinder\";\n> \n> ?\n\nSure. With identation and line break, it becomes\n\n\t\t\tstd::string role = opt.isSet(\"role\")\n\t\t\t\t\t ? opt[\"role\"].toString()\n\t\t\t\t\t : \"viewfinder\";\n\n> >> +\n> >> +\t\t\tif (role == \"viewfinder\") {\n> >> \t\t\t\troles.push_back(StreamRole::Viewfinder);\n> >> -\t\t\t} else if (opt[\"role\"].toString() == \"video\") {\n> >> +\t\t\t} else if (role == \"video\") {\n> >> \t\t\t\troles.push_back(StreamRole::VideoRecording);\n> >> -\t\t\t} else if (opt[\"role\"].toString() == \"still\") {\n> >> +\t\t\t} else if (role == \"still\") {\n> >> \t\t\t\troles.push_back(StreamRole::StillCapture);\n> >> \t\t\t} else {\n> >> \t\t\t\tstd::cerr << \"Unknown stream role \"\n> >> -\t\t\t\t\t << opt[\"role\"].toString() << std::endl;\n> >> +\t\t\t\t\t << role << std::endl;\n> >> \t\t\t\treturn -EINVAL;\n> >> \t\t\t}\n> >> \t\t}","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EF3C60413\n\tfor ;\n\tMon, 23 Mar 2020 12:11:10 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3A2B308;\n\tMon, 23 Mar 2020 12:11:09 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584961870;\n\tbh=zUHWqBC50HFZxFi3UjeoUzLeSspbkkUAciYU/5taRfI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=c9p+zYAvHv+jFpmyczR16A5mej9hBVdQx8ngYZCp4cmyBZSjAfPqzlw2UXtOUw8Yl\n\teDFXmw7jEIRpw0ZSxxh9Inm2aiK9MkGETirVVsZOg6YoZ5nn0fN+zb7Ph9zehko/DA\n\t5tv2e++Kd2132HctucMBEFXrELXtjrO3cMj/tr9s=","Date":"Mon, 23 Mar 2020 13:11:00 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200323111100.GA12103@pendragon.ideasonboard.com>","References":"<20200323103938.11026-1-laurent.pinchart@ideasonboard.com>\n\t<20200323104025.GD4768@pendragon.ideasonboard.com>\n\t<06520ac5-9090-869e-8bf6-5a812393cbc5@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<06520ac5-9090-869e-8bf6-5a812393cbc5@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 11:11:10 -0000"}},{"id":4188,"web_url":"https://patchwork.libcamera.org/comment/4188/","msgid":"","date":"2020-03-23T11:13:13","subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/03/2020 11:11, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, Mar 23, 2020 at 11:00:47AM +0000, Kieran Bingham wrote:\n>> On 23/03/2020 10:40, Laurent Pinchart wrote:\n>>> This should obviously have s/qcam/cam/ in the subject line.\n>>>\n>>> On Mon, Mar 23, 2020 at 12:39:38PM +0200, Laurent Pinchart wrote:\n>>>> The code handling the stream role option retrieves the role property and\n>>>> converts it to a string in every branch. Cache it and use the cached\n>>>> value.\n>>\n>> Trivial suggestion, but otherwise LGTM.\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>>> Signed-off-by: Laurent Pinchart \n>>>> ---\n>>>> src/cam/main.cpp | 16 ++++++++++------\n>>>> 1 file changed, 10 insertions(+), 6 deletions(-)\n>>>>\n>>>> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n>>>> index 2a0a830ff371..56059ab6c047 100644\n>>>> --- a/src/cam/main.cpp\n>>>> +++ b/src/cam/main.cpp\n>>>> @@ -209,17 +209,21 @@ int CamApp::prepareConfig()\n>>>> \t\tfor (auto const &value : streamOptions) {\n>>>> \t\t\tKeyValueParser::Options opt = value.toKeyValues();\n>>>> \n>>>> -\t\t\tif (!opt.isSet(\"role\")) {\n>>>> -\t\t\t\troles.push_back(StreamRole::VideoRecording);\n>>>> -\t\t\t} else if (opt[\"role\"].toString() == \"viewfinder\") {\n>>>> +\t\t\tstd::string role;\n>>>> +\t\t\tif (opt.isSet(\"role\"))\n>>>> +\t\t\t\trole = opt[\"role\"].toString();\n>>>> +\t\t\telse\n>>>> +\t\t\t\trole = \"viewfinder\";\n>>\n>> That almost looks worth a tertiary to make it a single line?\n>> role = opt.isSet(\"role\") ? opt[\"role\"].toString() : \"viewfinder\";\n>>\n>> ?\n> \n> Sure. With identation and line break, it becomes\n> \n> \t\t\tstd::string role = opt.isSet(\"role\")\n> \t\t\t\t\t ? opt[\"role\"].toString()\n> \t\t\t\t\t : \"viewfinder\";\n\nAh of course, you can also inline the declaration too then, but that\nincreases line length a little.\n\nPersonally I like tertiaries for small 'default' statements like this,\nso I prefer that - but it's up to you :) it's only minor.\n\n> \n>>>> +\n>>>> +\t\t\tif (role == \"viewfinder\") {\n>>>> \t\t\t\troles.push_back(StreamRole::Viewfinder);\n>>>> -\t\t\t} else if (opt[\"role\"].toString() == \"video\") {\n>>>> +\t\t\t} else if (role == \"video\") {\n>>>> \t\t\t\troles.push_back(StreamRole::VideoRecording);\n>>>> -\t\t\t} else if (opt[\"role\"].toString() == \"still\") {\n>>>> +\t\t\t} else if (role == \"still\") {\n>>>> \t\t\t\troles.push_back(StreamRole::StillCapture);\n>>>> \t\t\t} else {\n>>>> \t\t\t\tstd::cerr << \"Unknown stream role \"\n>>>> -\t\t\t\t\t << opt[\"role\"].toString() << std::endl;\n>>>> +\t\t\t\t\t << role << std::endl;\n>>>> \t\t\t\treturn -EINVAL;\n>>>> \t\t\t}\n>>>> \t\t}\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3883C60413\n\tfor ;\n\tMon, 23 Mar 2020 12:13:17 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADE78308;\n\tMon, 23 Mar 2020 12:13:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584961997;\n\tbh=WUo1hUXF6J78ApUIunl8nFjWdQZpBZi5O2yGIsJa5GM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=qNb1Vj1vsziqV6l3qQ+lAocr+0GlvQUgHqCFMLg+CkpZKB3SWO85iBaf1Eu3i6QZt\n\twlGXCNXf3bgIuxEgul803hvUlNcfJjGDacR/syt44rwnL1XllgD3mfenYobtywGnUP\n\tCAHq6SUGB4CYZLPR5MZSlMW2sPihham/sswUDz9U=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200323103938.11026-1-laurent.pinchart@ideasonboard.com>\n\t<20200323104025.GD4768@pendragon.ideasonboard.com>\n\t<06520ac5-9090-869e-8bf6-5a812393cbc5@ideasonboard.com>\n\t<20200323111100.GA12103@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 23 Mar 2020 11:13:13 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200323111100.GA12103@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 11:13:17 -0000"}},{"id":4197,"web_url":"https://patchwork.libcamera.org/comment/4197/","msgid":"<20200323125225.GE571071@oden.dyn.berto.se>","date":"2020-03-23T12:52:25","subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nOn 2020-03-23 12:40:25 +0200, Laurent Pinchart wrote:\n> This should obviously have s/qcam/cam/ in the subject line.\n\nWith this fixed and regardless on how you choose to act on Kieran's \nsuggestion,\n\nReviewed-by: Niklas Söderlund \n\n> \n> On Mon, Mar 23, 2020 at 12:39:38PM +0200, Laurent Pinchart wrote:\n> > The code handling the stream role option retrieves the role property and\n> > converts it to a string in every branch. Cache it and use the cached\n> > value.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/cam/main.cpp | 16 ++++++++++------\n> > 1 file changed, 10 insertions(+), 6 deletions(-)\n> > \n> > diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> > index 2a0a830ff371..56059ab6c047 100644\n> > --- a/src/cam/main.cpp\n> > +++ b/src/cam/main.cpp\n> > @@ -209,17 +209,21 @@ int CamApp::prepareConfig()\n> > \t\tfor (auto const &value : streamOptions) {\n> > \t\t\tKeyValueParser::Options opt = value.toKeyValues();\n> > \n> > -\t\t\tif (!opt.isSet(\"role\")) {\n> > -\t\t\t\troles.push_back(StreamRole::VideoRecording);\n> > -\t\t\t} else if (opt[\"role\"].toString() == \"viewfinder\") {\n> > +\t\t\tstd::string role;\n> > +\t\t\tif (opt.isSet(\"role\"))\n> > +\t\t\t\trole = opt[\"role\"].toString();\n> > +\t\t\telse\n> > +\t\t\t\trole = \"viewfinder\";\n> > +\n> > +\t\t\tif (role == \"viewfinder\") {\n> > \t\t\t\troles.push_back(StreamRole::Viewfinder);\n> > -\t\t\t} else if (opt[\"role\"].toString() == \"video\") {\n> > +\t\t\t} else if (role == \"video\") {\n> > \t\t\t\troles.push_back(StreamRole::VideoRecording);\n> > -\t\t\t} else if (opt[\"role\"].toString() == \"still\") {\n> > +\t\t\t} else if (role == \"still\") {\n> > \t\t\t\troles.push_back(StreamRole::StillCapture);\n> > \t\t\t} else {\n> > \t\t\t\tstd::cerr << \"Unknown stream role \"\n> > -\t\t\t\t\t << opt[\"role\"].toString() << std::endl;\n> > +\t\t\t\t\t << role << std::endl;\n> > \t\t\t\treturn -EINVAL;\n> > \t\t\t}\n> > \t\t}\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C105A6041A\n\tfor ;\n\tMon, 23 Mar 2020 13:52:27 +0100 (CET)","by mail-lj1-x234.google.com with SMTP id v16so7351438ljk.13\n\tfor ;\n\tMon, 23 Mar 2020 05:52:27 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\th22sm8248588ljc.15.2020.03.23.05.52.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 Mar 2020 05:52:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=7cYgzERuueVvzX4jThsPX/2oDEB879/h1+dfanrJQB8=;\n\tb=YadgRtZ9loq3By3O5pQVIcvErNC3SiO0eu3wlUi56LrOhIV5SowaZ5yVJt2CLy/YfQ\n\tBY5B5NlOwYcDhbiduCsaxW8Ax7l4WzIkRwxnvPSHwBmLvkDbbFDmQIXvYh3LyxFnbSdS\n\tR7GGygoEnAaorDZcDjRXqwqyP3vllduT/fwXg2LsFwBoA0VsBNhkDMOJpEjTT6+5bIuh\n\toZI+ZMwr+J/4IAQmINxOFcajuvC3ypkLlPv/0DID1ZV4ojzLOBWnCRCgalBkcJRYuu6C\n\tR2uSa/ae1ckbiPli/SIZZgs+NZkrnjtFIRGhRbOWmpMoNvU++Wnx6WY7V3fqNRRnmWWa\n\t4wlg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=7cYgzERuueVvzX4jThsPX/2oDEB879/h1+dfanrJQB8=;\n\tb=OxkZnFau4Pwm2U5CVzuJcTU2EeW+Elgc+gRMLNcdabHZlSeRucK8sIUcTyYLwE3DeE\n\tmwSXKlr9MTypvgOJteORBXgWeVa3CMmPd+WFQBVr+kc+/Um2RQH425Cuj/PrxRneLdlI\n\tcZsj2S+70wmvjRFyWzOKTdh9BwM57S+NWNorZib3bEl8QNwQJY+lWdzYRc/DqoQBvKvv\n\tCgkxhGdYw3KuweMg3lQbLc3/l/bEINOcJcjS67+JmB2BZN7/y2j+epInAH3/UEHBlQee\n\t6o+Pg76tUHQat/eKYfirrGKpty1YWoiBMn6gJMtEELAU8iNfV8v7F6VoCLwnJvSpgEBx\n\t6ZBA==","X-Gm-Message-State":"ANhLgQ1KtKIJcHSdr2cOx4u7YFRB0ZD7hsSXD0UXO4A7iO97pBbkxKuG\n\twXaIN5UKCowaDMoU5T/h7r9OtbFIs3I=","X-Google-Smtp-Source":"ADFU+vsXNN7n6lrX9hKDwe4hS7iGAplQQZQghxnz80GHGsbzMWcPNzja4R9Tg8Gi7CD7Kq5hhvi2Fg==","X-Received":"by 2002:a2e:8350:: with SMTP id\n\tl16mr13210535ljh.202.1584967947133; \n\tMon, 23 Mar 2020 05:52:27 -0700 (PDT)","Date":"Mon, 23 Mar 2020 13:52:25 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200323125225.GE571071@oden.dyn.berto.se>","References":"<20200323103938.11026-1-laurent.pinchart@ideasonboard.com>\n\t<20200323104025.GD4768@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200323104025.GD4768@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: main: Cache lookup of role\n\tproperty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 12:52:27 -0000"}}]