{"id":3239,"url":"https://patchwork.libcamera.org/api/patches/3239/?format=json","web_url":"https://patchwork.libcamera.org/patch/3239/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200322120225.31356-1-laurent.pinchart@ideasonboard.com>","date":"2020-03-22T12:02:24","name":"[libcamera-devel,1/2] utils: checkstyle: Add formatter to sort #include statements","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"397ee5d5245292f3cdfbf845267fbc2497fe19c4","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3239/mbox/","series":[{"id":757,"url":"https://patchwork.libcamera.org/api/series/757/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=757","date":"2020-03-22T12:02:24","name":"[libcamera-devel,1/2] utils: checkstyle: Add formatter to sort #include statements","version":1,"mbox":"https://patchwork.libcamera.org/series/757/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3239/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3239/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B695760414\n\tfor ;\n\tSun, 22 Mar 2020 13:02:39 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1D32308\n\tfor ;\n\tSun, 22 Mar 2020 13:02:38 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584878559;\n\tbh=vi75NsTb4Z+bptfBBY1OrQI+31P9vFgQAnLZXjSo98w=;\n\th=From:To:Subject:Date:From;\n\tb=wN1nf0c7grLIBaw2JgdK99eAny+TY6ODIBbyOtO1VlViPwkNPq1+fJ0xyyO4AZp6s\n\t3mvt6d9OtnRLdUtn6qbUSiPXaB1CruyRWmT9dsB4IqbFBq0xFhEwK/thnG7tfE6GAD\n\tzZ5M6udmMdFKsSE85mGe3zEZVS4ltJGrGMqbuKEE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 22 Mar 2020 14:02:24 +0200","Message-Id":"<20200322120225.31356-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] utils: checkstyle: Add formatter to\n\tsort #include statements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 22 Mar 2020 12:02:39 -0000"},"content":"Signed-off-by: Laurent Pinchart \n---\n utils/checkstyle.py | 33 +++++++++++++++++++++++++++++++++\n 1 file changed, 33 insertions(+)","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 0827a1e6ba0f..5fd63f047781 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -481,6 +481,39 @@ class DoxygenFormatter(Formatter):\n return '\\n'.join(lines)\n \n \n+class IncludeOrderFormatter(Formatter):\n+ patterns = ('*.cpp', '*.h')\n+\n+ include_regex = re.compile('^#include [\"<]([^\">]*)[\">]')\n+\n+ @classmethod\n+ def format(cls, filename, data):\n+ lines = []\n+ includes = []\n+\n+ for line in data.split('\\n'):\n+ match = IncludeOrderFormatter.include_regex.match(line)\n+ if match:\n+ includes.append((line, match.group(1)))\n+ continue\n+\n+ if len(includes):\n+ includes.sort(key=lambda i: i[1])\n+ for include in includes:\n+ lines.append(include[0])\n+ includes = []\n+\n+ lines.append(line)\n+\n+ if len(includes):\n+ includes.sort(key=lambda i: i[1])\n+ for include in includes:\n+ lines.append(include[0])\n+ includes = []\n+\n+ return '\\n'.join(lines)\n+\n+\n class StripTrailingSpaceFormatter(Formatter):\n patterns = ('*.c', '*.cpp', '*.h', '*.py', 'meson.build')\n \n","prefixes":["libcamera-devel","1/2"]}