[{"id":4133,"web_url":"https://patchwork.libcamera.org/comment/4133/","msgid":"<20200320135903.GB3717547@oden.dyn.berto.se>","date":"2020-03-20T13:59:03","subject":"Re: [libcamera-devel] [RFC] [PATCH 1/3] Added statusbar to show the\n\tcamera stream configuration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Show,\n\nThanks for your work.\n\nOn 2020-03-20 16:50:27 +0800, Show Liu wrote:\n> qcam: Added statusbar to show the camera stream information\n> \n> Signed-off-by: Show Liu \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/main_window.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index ae1760d..98e55ba 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -21,6 +21,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> #include \n> @@ -238,6 +239,8 @@ int MainWindow::startCapture()\n> \t\treturn ret;\n> \t}\n> \n> +\tstatusBar()->showMessage(QString(cfg.toString().c_str()));\n> +\n> \tadjustSize();\n> \n> \tallocator_ = FrameBufferAllocator::create(camera_);\n> @@ -342,6 +345,8 @@ void MainWindow::stopCapture()\n> \n> \tconfig_.reset();\n> \n> +\tstatusBar()->clearMessage();\n> +\n> \ttitleTimer_.stop();\n> \tsetWindowTitle(title_);\n> }\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D667060416\n\tfor ;\n\tFri, 20 Mar 2020 14:59:05 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id a28so4606930lfr.13\n\tfor ;\n\tFri, 20 Mar 2020 06:59:05 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tl205sm3492117lfd.50.2020.03.20.06.59.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 20 Mar 2020 06:59:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=KXNdhWCNfiJB9GAQnKx9FMsKzGgMqZ9lJqnDZI+o89I=;\n\tb=eM2i9MOdMLuWwiaH3S3ZmRA+DCWjZsGF0Tfa9nooYTMd7e8yij3xzuBV+Yo31BiFu1\n\t/jZJlfK6Bdx3pb8onTASo3Lzsd7SQJqCDmHuKMO6vWju7UF65eNohgpusMJRgpRhrQSm\n\tWboffnhTpxDzTUIgte00esSjUZ9yePZWgSgWgGt8jtjmci30sn8EEfp4qqs2PzG3DM3G\n\t522jTY79RfzY97ASsD3kioafSWlv2lc/GRbf6FYrfo7YJoMyzA34tggbERdtjZmcoJAB\n\tQ3L5nK8T2BOO1MQlF4LPeQU2aCFbt9cfV8toqcHs4udT4UWXS56gmOWLg4q7Q4erddsh\n\t5cFw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=KXNdhWCNfiJB9GAQnKx9FMsKzGgMqZ9lJqnDZI+o89I=;\n\tb=VpwiRKWgvyiwrEjroz/5xxkZJa12sJL2DcHMsMtpEn4s/yrtMMr6Lwh/IktyAUw9H4\n\tQrcIBOefQgS18mpzrqTlCdhABJ4h/wVYL1Np/o7VUEeemX3e+SExWb/L7i/liMkePgYG\n\tKRGtKfV8VWgesbY9Roh2RDUOOSYHVfbJAW1idTseWJnOAVfb5VvTwUbH5L7u59LOQIHr\n\tTcxLwSwITWkbSXnqXaOsDgaUrDY0c2/5DXvnuLkbYI/9fl3VQz3Z5QdjwYHlYqXVWI9B\n\tfMe1OygZfuYI0CLzznaDLD/G9KPxl1FwQ5eOYAgWAAN1/AAdlMlvkhoZTmebnG/dCdp5\n\t0fFQ==","X-Gm-Message-State":"ANhLgQ09lCO5+H2pTrzNcKDwtMbUFzsOzb/jjIWKgpZ57jgnVrzoDZDR\n\t6pj5zMuxd7LoEgNHH2bbRtF8bzvqllo=","X-Google-Smtp-Source":"ADFU+vvy+ITaAVDQw7rLlfDdeu8Si1UPsQx3q+3vw7tDosUsfVV0dQQIIZs79V49IllSOCW/ZECyKQ==","X-Received":"by 2002:a19:6f07:: with SMTP id k7mr1919502lfc.79.1584712744463; \n\tFri, 20 Mar 2020 06:59:04 -0700 (PDT)","Date":"Fri, 20 Mar 2020 14:59:03 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Show Liu ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200320135903.GB3717547@oden.dyn.berto.se>","References":"<20200320085029.17875-1-show.liu@linaro.org>\n\t<20200320085029.17875-2-show.liu@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200320085029.17875-2-show.liu@linaro.org>","Subject":"Re: [libcamera-devel] [RFC] [PATCH 1/3] Added statusbar to show the\n\tcamera stream configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 13:59:06 -0000"}},{"id":4142,"web_url":"https://patchwork.libcamera.org/comment/4142/","msgid":"<20200320144132.GL5193@pendragon.ideasonboard.com>","date":"2020-03-20T14:41:32","subject":"Re: [libcamera-devel] [RFC] [PATCH 1/3] Added statusbar to show the\n\tcamera stream configuration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Show,\n\nThank you for the patch.\n\nOn Fri, Mar 20, 2020 at 04:50:27PM +0800, Show Liu wrote:\n> qcam: Added statusbar to show the camera stream information\n\nThis should be the subject line :-)\n\ns/statusbar/status bar/\n\n> Signed-off-by: Show Liu \n> ---\n> src/qcam/main_window.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index ae1760d..98e55ba 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -21,6 +21,7 @@\n> #include \n> #include \n> #include \n> +#include \n\nPlease keep headers sorted alphabetically.\n\n> \n> #include \n> #include \n> @@ -238,6 +239,8 @@ int MainWindow::startCapture()\n> \t\treturn ret;\n> \t}\n> \n> +\tstatusBar()->showMessage(QString(cfg.toString().c_str()));\n> +\n\nShouldn't we create the status bar when creating the main window, to\navoid its magical apparition when starting the stream ? I would then\nstore it in the MainWindow class to avoid retrieving it from Qt every\ntime.\n\n> \tadjustSize();\n> \n> \tallocator_ = FrameBufferAllocator::create(camera_);\n> @@ -342,6 +345,8 @@ void MainWindow::stopCapture()\n> \n> \tconfig_.reset();\n> \n> +\tstatusBar()->clearMessage();\n> +\n> \ttitleTimer_.stop();\n> \tsetWindowTitle(title_);\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6244C60415\n\tfor ;\n\tFri, 20 Mar 2020 15:41:39 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7DF0504;\n\tFri, 20 Mar 2020 15:41:38 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584715299;\n\tbh=TfNaY1+6sXpgLHqvRbD1m9QkNNB+zqIcewtzVGjBz7I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XclakcT5vSxc4NWVoNMnm2QPF5J2cfYlNLm6iUxVuUEqXWTBKcV0AyYWMH9C2j5H6\n\tERvVj7mrGPMuILCm9NflBy72wJ9cZj32Be77dM5ouGfKVuSExl06EIhUMySdGA6BXA\n\t1h1QWk/47zfVWOHLR8boP5QxMN9+C0vhkybnry6s=","Date":"Fri, 20 Mar 2020 16:41:32 +0200","From":"Laurent Pinchart ","To":"Show Liu ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200320144132.GL5193@pendragon.ideasonboard.com>","References":"<20200320085029.17875-1-show.liu@linaro.org>\n\t<20200320085029.17875-2-show.liu@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200320085029.17875-2-show.liu@linaro.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC] [PATCH 1/3] Added statusbar to show the\n\tcamera stream configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 14:41:39 -0000"}}]