[{"id":489,"web_url":"https://patchwork.libcamera.org/comment/489/","msgid":"<20190122134323.GQ6484@bigcity.dyn.berto.se>","date":"2019-01-22T13:43:23","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Use log categories","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-01-22 14:31:42 +0100, Jacopo Mondi wrote:\n> Log the IPU3 pipeline using IPU3 log category\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 9 ++++++---\n> 1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index daf681c..8cbc10a 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -18,6 +18,8 @@\n> \n> namespace libcamera {\n> \n> +LOG_DEFINE_CATEGORY(IPU3)\n> +\n> class PipelineHandlerIPU3 : public PipelineHandler\n> {\n> public:\n> @@ -172,9 +174,10 @@ void PipelineHandlerIPU3::registerCameras(CameraManager *manager)\n> \t\tstd::shared_ptr camera = Camera::create(cameraName);\n> \t\tmanager->addCamera(std::move(camera));\n> \n> -\t\tLOG(Info) << \"Registered Camera[\" << numCameras << \"] \\\"\"\n> -\t\t\t << cameraName << \"\\\"\"\n> -\t\t\t << \" connected to CSI-2 receiver \" << id;\n> +\t\tLOG(IPU3, Info)\n> +\t\t\t<< \"Registered Camera[\" << numCameras << \"] \\\"\"\n> +\t\t\t<< cameraName << \"\\\"\"\n> +\t\t\t<< \" connected to CSI-2 receiver \" << id;\n> \n> \t\tnumCameras++;\n> \t}\n> --\n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com\n\t[IPv6:2a00:1450:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F241F60B1B\n\tfor ;\n\tTue, 22 Jan 2019 14:43:24 +0100 (CET)","by mail-lj1-x22c.google.com with SMTP id k19-v6so20588610lji.11\n\tfor ;\n\tTue, 22 Jan 2019 05:43:24 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\td2sm15483lfg.16.2019.01.22.05.43.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 22 Jan 2019 05:43:23 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=7C4035lEv4Kd27xRR6rlHMnoNJJ1VjAB5rnnuv+K+cY=;\n\tb=SDo1kO6tbJdVwvAiM/P0Ed5AOXCeyM290VRtuDTn24aHy6Fxx+xwmNfj6XRVZdMf75\n\tOGUDeT8T0Y3o8o+sP7FeUlQY+DQIJOg+m3Y9ZAgrWKHT090pHBPIxcwmgEUzhOxn8pH4\n\tQEvt/Wb32VNSsUmjThLCQmXqS9/kTvmYYtZ/xojYZYA8LgIoMPG32EpoTkPYtqoWwypC\n\tkLpzxFAboRAz9SXzbJOLgU57l7dOmzPX0Yf0WbkyYqsrHIC2I8kptd/nFT+yueSyyIin\n\ti1HHb/fUELpTNqBJrjGB6xGdULicETdcQecFT4dBeGWd8emRtVrGmsVukHj54vxtZAgh\n\tj2kA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=7C4035lEv4Kd27xRR6rlHMnoNJJ1VjAB5rnnuv+K+cY=;\n\tb=RVKjLXbeq3uRBmVFIZfg55e57t/IWVwLKib0B5CN+FK7x7I+njSZMd7smPEbE76ij3\n\tdWsVQ3pPc/SHr2Yqpsra9/FxTe0lbM3/gEUpV4SCwAn0eQK326YKqTmtS9yOIovOp7Xl\n\tFaA3tHSkecoprBqBbO/WGGNcL0E36gUl1Fgmbbf+dPyRVTUoUKw2I+ica7jYc/EKA0Kb\n\tlXpbfvbcJuECGiXIi+TA1V2/nDkTP57TXD65JsTgPLFO66F0gemaRLv2GxxLeqLw6WN4\n\t5UcD18Q3/l39rHFUXrkFL/X1Bn+1bH2BBsJxMaph+kouU1tggnFNzxdOCyMAcqt541MH\n\tBerA==","X-Gm-Message-State":"AJcUukdkDJmEtYDM+QMfnFlqVu/3EtFPMhkDGvfyK0iaUZI9gstgLz6k\n\t92WxWvZaWVUWDy3ynHXwjVj5hOrqe5E=","X-Google-Smtp-Source":"ALg8bN4W6tmVVVaJQNtFxiOn3La0iEZjxzpUto+vm/X6xbJtCcvl+raQ6BfjpBqNe8gG2OeVbNZUZw==","X-Received":"by 2002:a2e:750a:: with SMTP id\n\tq10-v6mr22618143ljc.39.1548164604273; \n\tTue, 22 Jan 2019 05:43:24 -0800 (PST)","Date":"Tue, 22 Jan 2019 14:43:23 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190122134323.GQ6484@bigcity.dyn.berto.se>","References":"<20190122133142.1165-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190122133142.1165-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Use log categories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 22 Jan 2019 13:43:25 -0000"}}]