{"id":3215,"url":"https://patchwork.libcamera.org/api/patches/3215/?format=json","web_url":"https://patchwork.libcamera.org/patch/3215/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200320014839.14683-8-laurent.pinchart@ideasonboard.com>","date":"2020-03-20T01:48:35","name":"[libcamera-devel,v3,07/11] libcamera: v4l2_videodevice: Downgrade 4CC conversion errors to warnings","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"36b223367d6599069a89952b2fec7a0cd4319114","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3215/mbox/","series":[{"id":749,"url":"https://patchwork.libcamera.org/api/series/749/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=749","date":"2020-03-20T01:48:28","name":"Simple pipeline handler","version":3,"mbox":"https://patchwork.libcamera.org/series/749/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3215/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3215/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 681C060418\n\tfor ;\n\tFri, 20 Mar 2020 02:48:55 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C851E1529;\n\tFri, 20 Mar 2020 02:48:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584668935;\n\tbh=UkHMEsSEIZFaLoQiV9nRaF6yz+t3etZAzboZO1q5XJw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GeK3phWjMbTLe/c/zhopaOsKm+KVAS46DYiTmh4RCFZsDje2JXwNF32FJm8bM6ThD\n\tdDJ+LKgj1qaZhzSDCd4IfCuzwq/mTfLc4DfA5P4Gmb9dN5ch76xbxZRaCmSHZCdg9c\n\tRuqXCWFgz1AjHuoxG+OvOylZvBKIWyuwT4dWPLbw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Martijn Braam ,\n\tBenjamin GAIGNARD ,\n\tAndrey Konovalov ","Date":"Fri, 20 Mar 2020 03:48:35 +0200","Message-Id":"<20200320014839.14683-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>","References":"<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 07/11] libcamera: v4l2_videodevice:\n\tDowngrade 4CC conversion errors to warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 01:48:55 -0000"},"content":"Failing to convert between V4L2 and DRM 4CCs indicates something is\nlikely wrong, but doesn't necessarily prevent the camera from being\nusable. It may for instance only limit the number of supported formats.\nDowngrade the related log messages from LogError to LogWarning.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/v4l2_videodevice.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 096ebc1bbb88..180eb192a951 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1691,7 +1691,7 @@ PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n \t\t * class. Until we fix the logger, work around it.\n \t\t */\n \t\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n-\t\t\t\tLogError).stream()\n+\t\t\t\tLogWarning).stream()\n \t\t\t<< \"Unsupported V4L2 pixel format \"\n \t\t\t<< v4l2Fourcc.toString();\n \t\treturn PixelFormat();\n@@ -1773,7 +1773,8 @@ V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelForma\n \t * \\todo We can't use LOG() in a static method of a Loggable\n \t * class. Until we fix the logger, work around it.\n \t */\n-\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(), LogError).stream()\n+\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n+\t\t\tLogWarning).stream()\n \t\t<< \"Unsupported V4L2 pixel format \" << pixelFormat.toString();\n \treturn {};\n }\n","prefixes":["libcamera-devel","v3","07/11"]}