[{"id":4357,"web_url":"https://patchwork.libcamera.org/comment/4357/","msgid":"<347ca4fd-3fb8-0683-312c-5b419b4da124@ideasonboard.com>","date":"2020-03-31T12:45:34","subject":"Re: [libcamera-devel] [PATCH v3 02/11] libcamera: utils: Add string\n\tjoin function","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 20/03/2020 01:48, Laurent Pinchart wrote:\n> Add a utils::join() function to join elements of a container into a\n> string, with a separator and an optional conversion function if the\n> elements are not implicitly convertible to std::string.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/include/utils.h | 44 +++++++++++++++++++++++++++++++++++\n> src/libcamera/utils.cpp | 16 +++++++++++++\n> test/utils.cpp | 7 +++++-\n> 3 files changed, 66 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\n> index cfa620f24581..242eeded9d50 100644\n> --- a/src/libcamera/include/utils.h\n> +++ b/src/libcamera/include/utils.h\n> @@ -11,6 +11,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -109,6 +110,49 @@ inline _hex hex(uint64_t value, unsigned int width)\n> \n> size_t strlcpy(char *dst, const char *src, size_t size);\n> \n> +#ifndef __DOXYGEN__\n> +template\n> +std::string join(const Container &items, const std::string &sep, UnaryOp op)\n> +{\n> +\tstd::ostringstream ss;\n> +\tbool first = true;\n> +\n> +\tfor (typename Container::const_iterator it = std::begin(items);\n> +\t it != std::end(items); ++it) {\n> +\t\tif (!first)\n> +\t\t\tss << sep;\n> +\t\telse\n> +\t\t\tfirst = false;\n> +\n> +\t\tss << op(*it);\n> +\t}\n> +\n> +\treturn ss.str();\n> +}\n> +\n> +template\n> +std::string join(const Container &items, const std::string &sep)\n> +{\n> +\tstd::ostringstream ss;\n> +\tbool first = true;\n> +\n> +\tfor (typename Container::const_iterator it = std::begin(items);\n> +\t it != std::end(items); ++it) {\n> +\t\tif (!first)\n> +\t\t\tss << sep;\n> +\t\telse\n> +\t\t\tfirst = false;\n> +\n> +\t\tss << *it;\n> +\t}\n> +\n> +\treturn ss.str();\n> +}\n> +#else\n> +template\n> +std::string join(const Container &items, const std::string &sep, UnaryOp op = nullptr);\n> +#endif\n> +\n> namespace details {\n> \n> class StringSplitter\n> diff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\n> index 58ee7cc19c8c..97f9b632e45b 100644\n> --- a/src/libcamera/utils.cpp\n> +++ b/src/libcamera/utils.cpp\n> @@ -297,6 +297,22 @@ details::StringSplitter::iterator details::StringSplitter::end() const\n> \treturn iterator(this, std::string::npos);\n> }\n> \n> +/**\n> + * \\fn template \\\n> + * std::string utils::join(const Container &items, const std::string &sep, UnaryOp op)\n> + * \\brief Join elements of a container in a string with a separator\n> + * \\param[in] items The container\n> + * \\param[in] sep The separator to add between elements\n> + * \\param[in] op A function that converts individual elements to strings\n> + *\n> + * This function joins all elements in the \\a items container into a string and\n> + * returns it. The \\a sep separator is added between elements. If the container\n> + * elements are not implicitly convertible to std::string, the \\a op function\n> + * shall be provided to perform conversion of elements to std::string.\n> + *\n> + * \\return A string that concatenates all elements in the container\n> + */\n> +\n> /**\n> * \\fn split(const std::string &str, const std::string &delim)\n> * \\brief Split a string based on a delimiter\n> diff --git a/test/utils.cpp b/test/utils.cpp\n> index 58816f153066..2fca89ef3278 100644\n> --- a/test/utils.cpp\n> +++ b/test/utils.cpp\n> @@ -99,7 +99,7 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\t/* utils::split() test. */\n> +\t\t/* utils::join() and utils::split() test. */\n> \t\tstd::vector elements = {\n> \t\t\t\"/bin\",\n> \t\t\t\"/usr/bin\",\n> @@ -111,6 +111,11 @@ protected:\n> \t\tfor (const auto &element : elements)\n> \t\t\tpath += (path.empty() ? \"\" : \":\") + element;\n> \n> +\t\tif (path != utils::join(elements, \":\")) {\n> +\t\t\tcerr << \"utils::join() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n\n\nThis is lacking a test for the optional conversion function ?\n\n\n> \t\tstd::vector dirs;\n> \n> \t\tfor (const auto &dir : utils::split(path, \":\"))\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9E736040B\n\tfor ;\n\tTue, 31 Mar 2020 14:45:37 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 40EC7B18;\n\tTue, 31 Mar 2020 14:45:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Qrvn9xv0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585658737;\n\tbh=oQ+21B30iNj6VvGUTlVRO9GUcKHjmH5HQyxplMv8Tjo=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Qrvn9xv0MwG/Ikh4cZR9/iJ4eVqDUvbNx391YEhp8a5oGCTcVTMDsi8d5ZeIWlNud\n\t3dnK9K3Ivjh0GOUugYYW/38e/IHuLfttmg5sKc+YFFFMMB34ULbR5KLOCOm49hd1ut\n\tH4+n0n1xOBOn1g/mOUl0QUgCEVXqEiYrGfCAIusU=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Martijn Braam ,\n\tBenjamin GAIGNARD ","References":"<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>\n\t<20200320014839.14683-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<347ca4fd-3fb8-0683-312c-5b419b4da124@ideasonboard.com>","Date":"Tue, 31 Mar 2020 13:45:34 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200320014839.14683-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3 02/11] libcamera: utils: Add string\n\tjoin function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 31 Mar 2020 12:45:38 -0000"}},{"id":4377,"web_url":"https://patchwork.libcamera.org/comment/4377/","msgid":"<20200403231854.GC9690@pendragon.ideasonboard.com>","date":"2020-04-03T23:18:54","subject":"Re: [libcamera-devel] [PATCH v3 02/11] libcamera: utils: Add string\n\tjoin function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Mar 31, 2020 at 01:45:34PM +0100, Kieran Bingham wrote:\n> On 20/03/2020 01:48, Laurent Pinchart wrote:\n> > Add a utils::join() function to join elements of a container into a\n> > string, with a separator and an optional conversion function if the\n> > elements are not implicitly convertible to std::string.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > Reviewed-by: Niklas Söderlund \n> > Reviewed-by: Jacopo Mondi \n> > ---\n> > src/libcamera/include/utils.h | 44 +++++++++++++++++++++++++++++++++++\n> > src/libcamera/utils.cpp | 16 +++++++++++++\n> > test/utils.cpp | 7 +++++-\n> > 3 files changed, 66 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\n> > index cfa620f24581..242eeded9d50 100644\n> > --- a/src/libcamera/include/utils.h\n> > +++ b/src/libcamera/include/utils.h\n> > @@ -11,6 +11,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > #include \n> > @@ -109,6 +110,49 @@ inline _hex hex(uint64_t value, unsigned int width)\n> > \n> > size_t strlcpy(char *dst, const char *src, size_t size);\n> > \n> > +#ifndef __DOXYGEN__\n> > +template\n> > +std::string join(const Container &items, const std::string &sep, UnaryOp op)\n> > +{\n> > +\tstd::ostringstream ss;\n> > +\tbool first = true;\n> > +\n> > +\tfor (typename Container::const_iterator it = std::begin(items);\n> > +\t it != std::end(items); ++it) {\n> > +\t\tif (!first)\n> > +\t\t\tss << sep;\n> > +\t\telse\n> > +\t\t\tfirst = false;\n> > +\n> > +\t\tss << op(*it);\n> > +\t}\n> > +\n> > +\treturn ss.str();\n> > +}\n> > +\n> > +template\n> > +std::string join(const Container &items, const std::string &sep)\n> > +{\n> > +\tstd::ostringstream ss;\n> > +\tbool first = true;\n> > +\n> > +\tfor (typename Container::const_iterator it = std::begin(items);\n> > +\t it != std::end(items); ++it) {\n> > +\t\tif (!first)\n> > +\t\t\tss << sep;\n> > +\t\telse\n> > +\t\t\tfirst = false;\n> > +\n> > +\t\tss << *it;\n> > +\t}\n> > +\n> > +\treturn ss.str();\n> > +}\n> > +#else\n> > +template\n> > +std::string join(const Container &items, const std::string &sep, UnaryOp op = nullptr);\n> > +#endif\n> > +\n> > namespace details {\n> > \n> > class StringSplitter\n> > diff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\n> > index 58ee7cc19c8c..97f9b632e45b 100644\n> > --- a/src/libcamera/utils.cpp\n> > +++ b/src/libcamera/utils.cpp\n> > @@ -297,6 +297,22 @@ details::StringSplitter::iterator details::StringSplitter::end() const\n> > \treturn iterator(this, std::string::npos);\n> > }\n> > \n> > +/**\n> > + * \\fn template \\\n> > + * std::string utils::join(const Container &items, const std::string &sep, UnaryOp op)\n> > + * \\brief Join elements of a container in a string with a separator\n> > + * \\param[in] items The container\n> > + * \\param[in] sep The separator to add between elements\n> > + * \\param[in] op A function that converts individual elements to strings\n> > + *\n> > + * This function joins all elements in the \\a items container into a string and\n> > + * returns it. The \\a sep separator is added between elements. If the container\n> > + * elements are not implicitly convertible to std::string, the \\a op function\n> > + * shall be provided to perform conversion of elements to std::string.\n> > + *\n> > + * \\return A string that concatenates all elements in the container\n> > + */\n> > +\n> > /**\n> > * \\fn split(const std::string &str, const std::string &delim)\n> > * \\brief Split a string based on a delimiter\n> > diff --git a/test/utils.cpp b/test/utils.cpp\n> > index 58816f153066..2fca89ef3278 100644\n> > --- a/test/utils.cpp\n> > +++ b/test/utils.cpp\n> > @@ -99,7 +99,7 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > -\t\t/* utils::split() test. */\n> > +\t\t/* utils::join() and utils::split() test. */\n> > \t\tstd::vector elements = {\n> > \t\t\t\"/bin\",\n> > \t\t\t\"/usr/bin\",\n> > @@ -111,6 +111,11 @@ protected:\n> > \t\tfor (const auto &element : elements)\n> > \t\t\tpath += (path.empty() ? \"\" : \":\") + element;\n> > \n> > +\t\tif (path != utils::join(elements, \":\")) {\n> > +\t\t\tcerr << \"utils::join() test failed\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> \n> This is lacking a test for the optional conversion function ?\n\nGood point. I've added this.\n\n\t\t/* utils::join() with conversion function test. */\n\t\tstd::vector sizes = { { 0, 0 }, { 100, 100 } };\n\t\ts = utils::join(sizes, \"/\", [](const Size &size) {\n\t\t\t\t\treturn size.toString();\n\t\t\t\t});\n \n\t\tif (s != \"0x0/100x100\") {\n\t\t\tcerr << \"utils::join() with conversion test failed\" << endl;\n\t\t\treturn TestFail;\n\t\t}\n\n(I've used Size as I needed something that can't be implicitly converted\nto a string, otherwise I would just have used int).\n\n> > \t\tstd::vector dirs;\n> > \n> > \t\tfor (const auto &dir : utils::split(path, \":\"))\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A3E8605D1\n\tfor ;\n\tSat, 4 Apr 2020 01:19:04 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED6BE321;\n\tSat, 4 Apr 2020 01:19:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fjFcHMvz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585955944;\n\tbh=kDzAot1pi14lcBMm8/Q4A8QLEiqkt17SBMTs+tS9ms0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fjFcHMvz2SYbz631MA/LbCPtwi67jbB6VVCVucydObQqF3lGDNOACGd7OLBVw834x\n\tOs0bcP+Y78dU63WPFLnLQ+SdtJtqKjBQGkqk5bYQI7kQuapCLReAehnm+Xj+3gezL1\n\t6nCStDmxs5vulX0cLFVDiEfAtM6/ra/Pju1oVom4=","Date":"Sat, 4 Apr 2020 02:18:54 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org, Martijn Braam , \n\tBenjamin GAIGNARD ","Message-ID":"<20200403231854.GC9690@pendragon.ideasonboard.com>","References":"<20200320014839.14683-1-laurent.pinchart@ideasonboard.com>\n\t<20200320014839.14683-3-laurent.pinchart@ideasonboard.com>\n\t<347ca4fd-3fb8-0683-312c-5b419b4da124@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<347ca4fd-3fb8-0683-312c-5b419b4da124@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 02/11] libcamera: utils: Add string\n\tjoin function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 03 Apr 2020 23:19:04 -0000"}}]