[{"id":4111,"web_url":"https://patchwork.libcamera.org/comment/4111/","msgid":"<20200319235035.GO14585@pendragon.ideasonboard.com>","date":"2020-03-19T23:50:35","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Use\n\tmaxBuffers instead of count when importing buffers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Mar 20, 2020 at 12:44:01AM +0100, Niklas Söderlund wrote:\n> When folding buffer management with start/stop the wrong variable was\n> passed to importBuffers() resulting in only one buffer being imported\n> for the video node making capture impossible. Fix this by using the\n> right variable, maxBuffers.\n> \n> Rename the misleadingly named count variable to avoid confusion in the\n> future.\n> \n> Fixes: 33fedea818e2b6a9 (\"libcamera: pipeline_handler: Fold buffer management with start/stop\")\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 97bb4f72cde5423e..d9a221d2df3e4b4c 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -668,14 +668,14 @@ int PipelineHandlerRkISP1::exportFrameBuffers(Camera *camera, Stream *stream,\n> int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)\n> {\n> \tRkISP1CameraData *data = cameraData(camera);\n> -\tunsigned int count = 1;\n> +\tunsigned int ipaBufferIDCounter = 1;\n\nThat's a bit of a long name. How about bufferId ? Or ipaBufferId if you\nreally insist ? :-) (ID should be spelled Id in any case)\n\n> \tint ret;\n> \n> \tunsigned int maxBuffers = 0;\n> \tfor (const Stream *s : camera->streams())\n> \t\tmaxBuffers = std::max(maxBuffers, s->configuration().bufferCount);\n> \n> -\tret = video_->importBuffers(count);\n> +\tret = video_->importBuffers(maxBuffers);\n\nSo before the faulty patch, we were importing, for each stream, the\nnumber of buffers specified for that stream. Now we're importing the\nmaximum number of buffers. As the pipeline handler supports a single\nstream this is equivalent, but is it the right thing to do when we'll\nhave multiple streams ?\n\n> \tif (ret < 0)\n> \t\tgoto error;\n> \n> @@ -688,14 +688,14 @@ int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)\n> \t\tgoto error;\n> \n> \tfor (std::unique_ptr &buffer : paramBuffers_) {\n> -\t\tbuffer->setCookie(count++);\n> +\t\tbuffer->setCookie(ipaBufferIDCounter++);\n> \t\tdata->ipaBuffers_.push_back({ .id = buffer->cookie(),\n> \t\t\t\t\t .planes = buffer->planes() });\n> \t\tavailableParamBuffers_.push(buffer.get());\n> \t}\n> \n> \tfor (std::unique_ptr &buffer : statBuffers_) {\n> -\t\tbuffer->setCookie(count++);\n> +\t\tbuffer->setCookie(ipaBufferIDCounter++);\n> \t\tdata->ipaBuffers_.push_back({ .id = buffer->cookie(),\n> \t\t\t\t\t .planes = buffer->planes() });\n> \t\tavailableStatBuffers_.push(buffer.get());","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BB9A60415\n\tfor ;\n\tFri, 20 Mar 2020 00:50:42 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E21E1A53;\n\tFri, 20 Mar 2020 00:50:41 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584661842;\n\tbh=eFznFu+ybNSNqqqTWZ6UDEEQLoqd1xhifFzjTkWLQPo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gAPLZwDnp09eWEYRZuioNsW1Im0F05EYdEuzg93bD4/4pzh7HQ4NxpOg1M2zlh3MX\n\tFhdQHcJndc81/VxciDeLPkoAiYLBBFECPjTVuEwFrYLE2dK+qS2NSHLnk/5asjpaLj\n\tdrBaDJQSe1DnLynnCrqJNN0psIGkTJYGlU0a88hU=","Date":"Fri, 20 Mar 2020 01:50:35 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200319235035.GO14585@pendragon.ideasonboard.com>","References":"<20200319234401.3522424-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200319234401.3522424-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Use\n\tmaxBuffers instead of count when importing buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 19 Mar 2020 23:50:42 -0000"}},{"id":4113,"web_url":"https://patchwork.libcamera.org/comment/4113/","msgid":"<20200320000541.GA3542252@oden.dyn.berto.se>","date":"2020-03-20T00:05:41","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Use\n\tmaxBuffers instead of count when importing buffers","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2020-03-20 01:50:35 +0200, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Fri, Mar 20, 2020 at 12:44:01AM +0100, Niklas Söderlund wrote:\n> > When folding buffer management with start/stop the wrong variable was\n> > passed to importBuffers() resulting in only one buffer being imported\n> > for the video node making capture impossible. Fix this by using the\n> > right variable, maxBuffers.\n> > \n> > Rename the misleadingly named count variable to avoid confusion in the\n> > future.\n> > \n> > Fixes: 33fedea818e2b6a9 (\"libcamera: pipeline_handler: Fold buffer management with start/stop\")\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 ++++----\n> > 1 file changed, 4 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index 97bb4f72cde5423e..d9a221d2df3e4b4c 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -668,14 +668,14 @@ int PipelineHandlerRkISP1::exportFrameBuffers(Camera *camera, Stream *stream,\n> > int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)\n> > {\n> > \tRkISP1CameraData *data = cameraData(camera);\n> > -\tunsigned int count = 1;\n> > +\tunsigned int ipaBufferIDCounter = 1;\n> \n> That's a bit of a long name. How about bufferId ? Or ipaBufferId if you\n> really insist ? :-) (ID should be spelled Id in any case)\n\nipaBufferId it is :-)\n\n> \n> > \tint ret;\n> > \n> > \tunsigned int maxBuffers = 0;\n> > \tfor (const Stream *s : camera->streams())\n> > \t\tmaxBuffers = std::max(maxBuffers, s->configuration().bufferCount);\n> > \n> > -\tret = video_->importBuffers(count);\n> > +\tret = video_->importBuffers(maxBuffers);\n> \n> So before the faulty patch, we were importing, for each stream, the\n> number of buffers specified for that stream. Now we're importing the\n> maximum number of buffers. As the pipeline handler supports a single\n> stream this is equivalent, but is it the right thing to do when we'll\n> have multiple streams ?\n\nI'm not sure, for parameters and statistics I think it is. For the video \nnode probably not. How about something like this (making count the right \nname again ;-P)\n\n unsigned int maxBuffers = 0; \n for (const Stream *s : camera->streams()) {\n unsigned int count = s->configuration().bufferCount;\n\n if (s == &data->stream_) {\n ret = video_->importBuffers(count);\n if (ret < 0) \n goto error;\n } \n\n maxBuffers = std::max(maxBuffers, count);\n }\n\nThe check for 's == data->stream_' seems a bit silly but makes it \nextreamly clear where the checks needs to be added when we add more \nstreams.\n\n> \n> > \tif (ret < 0)\n> > \t\tgoto error;\n> > \n> > @@ -688,14 +688,14 @@ int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)\n> > \t\tgoto error;\n> > \n> > \tfor (std::unique_ptr &buffer : paramBuffers_) {\n> > -\t\tbuffer->setCookie(count++);\n> > +\t\tbuffer->setCookie(ipaBufferIDCounter++);\n> > \t\tdata->ipaBuffers_.push_back({ .id = buffer->cookie(),\n> > \t\t\t\t\t .planes = buffer->planes() });\n> > \t\tavailableParamBuffers_.push(buffer.get());\n> > \t}\n> > \n> > \tfor (std::unique_ptr &buffer : statBuffers_) {\n> > -\t\tbuffer->setCookie(count++);\n> > +\t\tbuffer->setCookie(ipaBufferIDCounter++);\n> > \t\tdata->ipaBuffers_.push_back({ .id = buffer->cookie(),\n> > \t\t\t\t\t .planes = buffer->planes() });\n> > \t\tavailableStatBuffers_.push(buffer.get());\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2CA560415\n\tfor ;\n\tFri, 20 Mar 2020 01:05:43 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id w4so4551385lji.11\n\tfor ;\n\tThu, 19 Mar 2020 17:05:43 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tl16sm2311346lje.7.2020.03.19.17.05.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Mar 2020 17:05:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=NmcRV483jE5YUqhjuQwzbKkuRBGnBhK9gMN1Tg1QDq4=;\n\tb=tGDX41Dk8/gNB8E3n3IfALcDG1ku8KSos4Mi3tsK6hZmU0SqafVRWpkBdymachwAzB\n\tORG9VqL+7eoyOxlsifzEqevOiOQO7KR784N6mIE4EAJMtpIj3waXX9s1AJtxe4KXOA4R\n\tNzc5vyexexpgel04ny2IM/+wFBxgtRrbyBVX2L31PNaLkE3jPtHYcA3mERKgKmDMGojK\n\tuprYwUOFiGscFJdOwyYJHZ8FlyfTLpo24e+g9Ml5KK4mkAi9SQEQh+yayMMa0b1r9Xaw\n\ts58cSbRA4JWcqbZ0w4ZiH+C7LlfHiX+/5CHO+7BrITLinAqMpNd0iKINjpP/O01W3Vuc\n\twsFA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=NmcRV483jE5YUqhjuQwzbKkuRBGnBhK9gMN1Tg1QDq4=;\n\tb=KNd1q9Ej3AB6qjuiQjMuf/E0oS74Y0j5NPFCeN2KDPBc5UsHkr0BgT/oQQi6UXH0kR\n\t49yZui/Bkf/+oh96L3v3R+hfZEHovsUVJ+gzfdsOlXHBl7EY3OvZZx52zDUG/ee5bfZ4\n\tSgT9Fc2J07m+4PxdrdhcJsCoGnA/IGPR/k59m1lkZ0sOYIt6S9Oqro7m61FyBZPgQKki\n\t3mdCCVdGTOPEm+aGrnqEzX0JN4zPkEjI2znWWk/1iWZzsBiyZ4d1MhYc+gwUN+uxVn0H\n\tL40/665Sf59bcRBB6DoVc8CuZr0LMx9irn6FGXGRPEIcZaMbcJZEzGn3aqqwVMaK+DtC\n\tBL7g==","X-Gm-Message-State":"ANhLgQ3kwy0ibvUhaa2JL8HXM88wUT0HTdy8A766H8gWmQVumL1+rxuY\n\trnKHkgtmkzaWZVXYgH9VHypneA4buAQ=","X-Google-Smtp-Source":"ADFU+vscobFs+89eGTrzfETaQaaV8qa1/9N+E7CCLFntlXWTZW7xxw2STp8PfevSYgux8lmpaI3iDw==","X-Received":"by 2002:a2e:9284:: with SMTP id d4mr3544116ljh.226.1584662743030;\n\tThu, 19 Mar 2020 17:05:43 -0700 (PDT)","Date":"Fri, 20 Mar 2020 01:05:41 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200320000541.GA3542252@oden.dyn.berto.se>","References":"<20200319234401.3522424-1-niklas.soderlund@ragnatech.se>\n\t<20200319235035.GO14585@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200319235035.GO14585@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Use\n\tmaxBuffers instead of count when importing buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 00:05:43 -0000"}},{"id":4114,"web_url":"https://patchwork.libcamera.org/comment/4114/","msgid":"<20200320000944.GR14585@pendragon.ideasonboard.com>","date":"2020-03-20T00:09:44","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Use\n\tmaxBuffers instead of count when importing buffers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Fri, Mar 20, 2020 at 01:05:41AM +0100, Niklas Söderlund wrote:\n> On 2020-03-20 01:50:35 +0200, Laurent Pinchart wrote:\n> > On Fri, Mar 20, 2020 at 12:44:01AM +0100, Niklas Söderlund wrote:\n> > > When folding buffer management with start/stop the wrong variable was\n> > > passed to importBuffers() resulting in only one buffer being imported\n> > > for the video node making capture impossible. Fix this by using the\n> > > right variable, maxBuffers.\n> > > \n> > > Rename the misleadingly named count variable to avoid confusion in the\n> > > future.\n> > > \n> > > Fixes: 33fedea818e2b6a9 (\"libcamera: pipeline_handler: Fold buffer management with start/stop\")\n> > > Signed-off-by: Niklas Söderlund \n> > > ---\n> > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 ++++----\n> > > 1 file changed, 4 insertions(+), 4 deletions(-)\n> > > \n> > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > index 97bb4f72cde5423e..d9a221d2df3e4b4c 100644\n> > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > @@ -668,14 +668,14 @@ int PipelineHandlerRkISP1::exportFrameBuffers(Camera *camera, Stream *stream,\n> > > int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)\n> > > {\n> > > \tRkISP1CameraData *data = cameraData(camera);\n> > > -\tunsigned int count = 1;\n> > > +\tunsigned int ipaBufferIDCounter = 1;\n> > \n> > That's a bit of a long name. How about bufferId ? Or ipaBufferId if you\n> > really insist ? :-) (ID should be spelled Id in any case)\n> \n> ipaBufferId it is :-)\n> \n> > \n> > > \tint ret;\n> > > \n> > > \tunsigned int maxBuffers = 0;\n> > > \tfor (const Stream *s : camera->streams())\n> > > \t\tmaxBuffers = std::max(maxBuffers, s->configuration().bufferCount);\n> > > \n> > > -\tret = video_->importBuffers(count);\n> > > +\tret = video_->importBuffers(maxBuffers);\n> > \n> > So before the faulty patch, we were importing, for each stream, the\n> > number of buffers specified for that stream. Now we're importing the\n> > maximum number of buffers. As the pipeline handler supports a single\n> > stream this is equivalent, but is it the right thing to do when we'll\n> > have multiple streams ?\n> \n> I'm not sure, for parameters and statistics I think it is. For the video \n> node probably not. How about something like this (making count the right \n> name again ;-P)\n> \n> unsigned int maxBuffers = 0; \n> for (const Stream *s : camera->streams()) {\n> unsigned int count = s->configuration().bufferCount;\n> \n> if (s == &data->stream_) {\n> ret = video_->importBuffers(count);\n> if (ret < 0) \n> goto error;\n> } \n> \n> maxBuffers = std::max(maxBuffers, count);\n> }\n> \n> The check for 's == data->stream_' seems a bit silly but makes it \n> extreamly clear where the checks needs to be added when we add more \n> streams.\n\nThat's over-complicated for something that supports a single stream in\npractice. Also, looping over camera->streams() is broken, you should\nloop over all active streams. I think you should just remove the loop\nand use the number of buffers for the single stream we have. Easy and\nhassle-free :-)\n\n> > \n> > > \tif (ret < 0)\n> > > \t\tgoto error;\n> > > \n> > > @@ -688,14 +688,14 @@ int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)\n> > > \t\tgoto error;\n> > > \n> > > \tfor (std::unique_ptr &buffer : paramBuffers_) {\n> > > -\t\tbuffer->setCookie(count++);\n> > > +\t\tbuffer->setCookie(ipaBufferIDCounter++);\n> > > \t\tdata->ipaBuffers_.push_back({ .id = buffer->cookie(),\n> > > \t\t\t\t\t .planes = buffer->planes() });\n> > > \t\tavailableParamBuffers_.push(buffer.get());\n> > > \t}\n> > > \n> > > \tfor (std::unique_ptr &buffer : statBuffers_) {\n> > > -\t\tbuffer->setCookie(count++);\n> > > +\t\tbuffer->setCookie(ipaBufferIDCounter++);\n> > > \t\tdata->ipaBuffers_.push_back({ .id = buffer->cookie(),\n> > > \t\t\t\t\t .planes = buffer->planes() });\n> > > \t\tavailableStatBuffers_.push(buffer.get());","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 230EF60415\n\tfor ;\n\tFri, 20 Mar 2020 01:09:51 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9CB46A53;\n\tFri, 20 Mar 2020 01:09:50 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584662990;\n\tbh=MihDrmHGdLHOk7U+Yik50uw9Er9Ae3EdtHRNLuPrkQ0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e7VDfAyKlsKkJuCyHWfvdpltk8ZX+LGCLRLLz4jlv4Bk4nHnBzOB+FANdaNHBRARa\n\tptGib+PhX+H3YB7I10z2X/gYJMOz4jMtIXb3poV5KOZ/JwJcMYu2BeCH2kWs9B2HBT\n\tOBoWmfZsacprrMEMbrJnhNUqI297VoU9e1gtKFzQ=","Date":"Fri, 20 Mar 2020 02:09:44 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200320000944.GR14585@pendragon.ideasonboard.com>","References":"<20200319234401.3522424-1-niklas.soderlund@ragnatech.se>\n\t<20200319235035.GO14585@pendragon.ideasonboard.com>\n\t<20200320000541.GA3542252@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200320000541.GA3542252@oden.dyn.berto.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: Use\n\tmaxBuffers instead of count when importing buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 00:09:51 -0000"}}]