[{"id":4087,"web_url":"https://patchwork.libcamera.org/comment/4087/","msgid":"<7c8ad10a-05be-5f32-9a28-4bb04ab8b272@ideasonboard.com>","date":"2020-03-19T10:36:14","subject":"Re: [libcamera-devel] [PATCH LIBCAMERA] libcamera: utils: merge\n\tisLibcamerainstalled with libcameraPath","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Kaaira,\n\nOn 19/03/2020 09:54, Kaaira Gupta wrote:\n> The two callers of functions libcameraPath() and isLibcameraInstalled()\n> end up using the same process and finally use the path with\n> libcamera.so. Hence write a function libcameraSourcePath() which\n> combines their functions, thereby making call sites simpler.\n> \n> Signed-off-by: Kaaira Gupta \n> ---\n> src/libcamera/include/utils.h | 2 +-\n> src/libcamera/ipa_manager.cpp | 5 +++--\n> src/libcamera/ipa_proxy.cpp | 6 +++---\n> src/libcamera/utils.cpp | 20 +++++++++++---------\n> 4 files changed, 18 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\n> index bc96e79..2cff15e 100644\n> --- a/src/libcamera/include/utils.h\n> +++ b/src/libcamera/include/utils.h\n> @@ -145,7 +145,7 @@ details::StringSplitter split(const std::string &str, const std::string &delim);\n> \n> bool isLibcameraInstalled();\n> \n> -std::string libcameraPath();\n> +std::string libcameraSourcePath();\n> \n> } /* namespace utils */\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 0bd280c..cf9b6e7 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -119,8 +119,9 @@ IPAManager::IPAManager()\n> \t * path for the IPA from that point. We need to recurse one level of\n> \t * sub-directories to match the build tree.\n> \t */\n> -\tif (!utils::isLibcameraInstalled()) {\n> -\t\tstd::string ipaBuildPath = utils::dirname(utils::libcameraPath()) + \"/../ipa\";\n> +\tstd::string libPath = utils::libcameraSourcePath();\n> +\tif (!libPath.empty()) {\n> +\t\tstd::string ipaBuildPath = libPath + \"/../ipa\";\n\n\nI wonder if we should make utils::libcameraSourcePath return the root of\nthe libcamera sources so that any users take a relative path from the root?\n\nThat might make things clearer or more consistent as then the\nipaBuildPath would become:\n\n std::string ipaBuildPath = root + \"/src/ipa\";\n\nWhat do you think?\n\nif we do change to return the 'root', it would be a 'Build' directory\nroot not a 'Source', so I think we might have to reconsider the name of\nthe function too.\n\n> \t\tconstexpr int maxDepth = 1;\n> \n> \t\tLOG(IPAManager, Info)\n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index 2f866cc..e9b7568 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -97,9 +97,9 @@ std::string IPAProxy::resolvePath(const std::string &file) const\n> \t * This requires identifying the path of the libcamera.so, and\n> \t * referencing a relative path for the proxy workers from that point.\n> \t */\n> -\tif (!utils::isLibcameraInstalled()) {\n> -\t\tstd::string ipaProxyDir = utils::dirname(utils::libcameraPath())\n> -\t\t\t\t\t + \"/proxy/worker\";\n> +\tstd::string libPath = utils::libcameraSourcePath();\n> +\tif (!libPath.empty()) {\n> +\t\tstd::string ipaProxyDir = libPath + \"/proxy/worker\";\n\nOf course, this would then become a bit longer:\n\nstd::string ipaProxyDir = libPath + \"src/libcamera/proxy/worker\";\n\nBut I think it might make the intent clearer for both locations?\n\n\n> \n> \t\tLOG(IPAProxy, Info)\n> \t\t\t<< \"libcamera is not installed. Loading proxy workers from'\"\n> diff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\n> index 7e118fa..8212d3e 100644\n> --- a/src/libcamera/utils.cpp\n> +++ b/src/libcamera/utils.cpp\n> @@ -347,16 +347,18 @@ bool isLibcameraInstalled()\n> *\n> * \\return A string stating the path\n> */\n> -std::string libcameraPath()\n> +std::string libcameraSourcePath()\n> {\n> -\tDl_info info;\n> -\n> -\t/* Look up our own symbol. */\n> -\tint ret = dladdr(reinterpret_cast(libcameraPath), &info);\n> -\tif (ret == 0)\n> -\t\treturn nullptr;\n> -\n> -\treturn info.dli_fname;\n> +\tif (!utils::isLibcameraInstalled()) {\n\nBecause we are 'in' the utils:: namespace here, I don't think you need\nto explicitly state 'utils::' to call isLibcameraInstalled.\n\nThe compiler will find the function without it.\n\n> +\t\tDl_info info;\n> +\t\t/* Look up our own symbol. */\n> +\t\tint ret = dladdr(reinterpret_cast(libcameraSourcePath), &info);\n> +\t\tif (ret == 0)\n> +\t\t\treturn nullptr;\n> +\n> +\t\treturn utils::dirname(info.dli_fname);\n\nIf you drop the 'else' as stated below, you can invert this if, to\n\n if (ret)\n\treturn utils::dirname(info.dli_fname);\n\nand let the error case fall through to the return std::string(); below\nwhich is better than returning a nullptr anyway, as the callers check\nthis returned string for .empty() (so returning a nullptr is bad).\n\n> +\t} else\n> +\t\treturn std::string();\n\nYou can drop the 'else', and put the return std::string(); as the last\nstatement of the function.\n\n\n> }\n> \n> } /* namespace utils */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B514C60416\n\tfor ;\n\tThu, 19 Mar 2020 11:36:17 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E600BA53;\n\tThu, 19 Mar 2020 11:36:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584614177;\n\tbh=WEJ6prrsxCUS8F+rD0jy5ZTwGvQkdgOhS2h9z+LUrAg=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=AaHkqIbJ7nxfFccwv3dXa9eM5t6CgBkPeF4CHQxTYK7GLUYkfhrwWks1lx2DIoSrP\n\tvJ3qIP+edG2SAbKAgsGDyKgG9uWjlSNl7lCqzGPM5UuDRFGM8oKqZrO6774cgEYln8\n\tuFkn+vXcFZM5HBtWi0KFEjHSXS4HK+wNT8pM7/zg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Kaaira Gupta , libcamera-devel@lists.libcamera.org","Cc":"Helen Koike ,\n\tVaishali Thakkar ","References":"<20200319095406.GA26435@kaaira-HP-Pavilion-Notebook>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7c8ad10a-05be-5f32-9a28-4bb04ab8b272@ideasonboard.com>","Date":"Thu, 19 Mar 2020 10:36:14 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200319095406.GA26435@kaaira-HP-Pavilion-Notebook>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH LIBCAMERA] libcamera: utils: merge\n\tisLibcamerainstalled with libcameraPath","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 19 Mar 2020 10:36:17 -0000"}},{"id":4089,"web_url":"https://patchwork.libcamera.org/comment/4089/","msgid":"<20200319120026.GA30517@kaaira-HP-Pavilion-Notebook>","date":"2020-03-19T12:00:26","subject":"Re: [libcamera-devel] [PATCH LIBCAMERA] libcamera: utils: merge\n\tisLibcamerainstalled with libcameraPath","submitter":{"id":39,"url":"https://patchwork.libcamera.org/api/people/39/","name":"Kaaira Gupta","email":"kgupta@es.iitr.ac.in"},"content":"On Thu, Mar 19, 2020 at 10:36:14AM +0000, Kieran Bingham wrote:\n> Hi Kaaira,\n> \n> On 19/03/2020 09:54, Kaaira Gupta wrote:\n> > The two callers of functions libcameraPath() and isLibcameraInstalled()\n> > end up using the same process and finally use the path with\n> > libcamera.so. Hence write a function libcameraSourcePath() which\n> > combines their functions, thereby making call sites simpler.\n> > \n> > Signed-off-by: Kaaira Gupta \n> > ---\n> > src/libcamera/include/utils.h | 2 +-\n> > src/libcamera/ipa_manager.cpp | 5 +++--\n> > src/libcamera/ipa_proxy.cpp | 6 +++---\n> > src/libcamera/utils.cpp | 20 +++++++++++---------\n> > 4 files changed, 18 insertions(+), 15 deletions(-)\n> > \n> > diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\n> > index bc96e79..2cff15e 100644\n> > --- a/src/libcamera/include/utils.h\n> > +++ b/src/libcamera/include/utils.h\n> > @@ -145,7 +145,7 @@ details::StringSplitter split(const std::string &str, const std::string &delim);\n> > \n> > bool isLibcameraInstalled();\n> > \n> > -std::string libcameraPath();\n> > +std::string libcameraSourcePath();\n> > \n> > } /* namespace utils */\n> > \n> > diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> > index 0bd280c..cf9b6e7 100644\n> > --- a/src/libcamera/ipa_manager.cpp\n> > +++ b/src/libcamera/ipa_manager.cpp\n> > @@ -119,8 +119,9 @@ IPAManager::IPAManager()\n> > \t * path for the IPA from that point. We need to recurse one level of\n> > \t * sub-directories to match the build tree.\n> > \t */\n> > -\tif (!utils::isLibcameraInstalled()) {\n> > -\t\tstd::string ipaBuildPath = utils::dirname(utils::libcameraPath()) + \"/../ipa\";\n> > +\tstd::string libPath = utils::libcameraSourcePath();\n> > +\tif (!libPath.empty()) {\n> > +\t\tstd::string ipaBuildPath = libPath + \"/../ipa\";\n> \n> \n> I wonder if we should make utils::libcameraSourcePath return the root of\n> the libcamera sources so that any users take a relative path from the root?\n> \n> That might make things clearer or more consistent as then the\n> ipaBuildPath would become:\n\nYes, that will make things more clean. I have updated the patch.\n\n> \n> std::string ipaBuildPath = root + \"/src/ipa\";\n> \n> What do you think?\n> \n> if we do change to return the 'root', it would be a 'Build' directory\n> root not a 'Source', so I think we might have to reconsider the name of\n> the function too.\n> \n> > \t\tconstexpr int maxDepth = 1;\n> > \n> > \t\tLOG(IPAManager, Info)\n> > diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> > index 2f866cc..e9b7568 100644\n> > --- a/src/libcamera/ipa_proxy.cpp\n> > +++ b/src/libcamera/ipa_proxy.cpp\n> > @@ -97,9 +97,9 @@ std::string IPAProxy::resolvePath(const std::string &file) const\n> > \t * This requires identifying the path of the libcamera.so, and\n> > \t * referencing a relative path for the proxy workers from that point.\n> > \t */\n> > -\tif (!utils::isLibcameraInstalled()) {\n> > -\t\tstd::string ipaProxyDir = utils::dirname(utils::libcameraPath())\n> > -\t\t\t\t\t + \"/proxy/worker\";\n> > +\tstd::string libPath = utils::libcameraSourcePath();\n> > +\tif (!libPath.empty()) {\n> > +\t\tstd::string ipaProxyDir = libPath + \"/proxy/worker\";\n> \n> Of course, this would then become a bit longer:\n> \n> std::string ipaProxyDir = libPath + \"src/libcamera/proxy/worker\";\n> \n> But I think it might make the intent clearer for both locations?\n> \n> \n> > \n> > \t\tLOG(IPAProxy, Info)\n> > \t\t\t<< \"libcamera is not installed. Loading proxy workers from'\"\n> > diff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\n> > index 7e118fa..8212d3e 100644\n> > --- a/src/libcamera/utils.cpp\n> > +++ b/src/libcamera/utils.cpp\n> > @@ -347,16 +347,18 @@ bool isLibcameraInstalled()\n> > *\n> > * \\return A string stating the path\n> > */\n> > -std::string libcameraPath()\n> > +std::string libcameraSourcePath()\n> > {\n> > -\tDl_info info;\n> > -\n> > -\t/* Look up our own symbol. */\n> > -\tint ret = dladdr(reinterpret_cast(libcameraPath), &info);\n> > -\tif (ret == 0)\n> > -\t\treturn nullptr;\n> > -\n> > -\treturn info.dli_fname;\n> > +\tif (!utils::isLibcameraInstalled()) {\n> \n> Because we are 'in' the utils:: namespace here, I don't think you need\n> to explicitly state 'utils::' to call isLibcameraInstalled.\n> \n> The compiler will find the function without it.\n> \n> > +\t\tDl_info info;\n> > +\t\t/* Look up our own symbol. */\n> > +\t\tint ret = dladdr(reinterpret_cast(libcameraSourcePath), &info);\n> > +\t\tif (ret == 0)\n> > +\t\t\treturn nullptr;\n> > +\n> > +\t\treturn utils::dirname(info.dli_fname);\n> \n> If you drop the 'else' as stated below, you can invert this if, to\n> \n> if (ret)\n> \treturn utils::dirname(info.dli_fname);\n> \n> and let the error case fall through to the return std::string(); below\n> which is better than returning a nullptr anyway, as the callers check\n> this returned string for .empty() (so returning a nullptr is bad).\n> \n> > +\t} else\n> > +\t\treturn std::string();\n> \n> You can drop the 'else', and put the return std::string(); as the last\n> statement of the function.\n> \n> \n> > }\n> > \n> > } /* namespace utils */\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-pl1-x642.google.com (mail-pl1-x642.google.com\n\t[IPv6:2607:f8b0:4864:20::642])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EC9E60417\n\tfor ;\n\tThu, 19 Mar 2020 13:00:34 +0100 (CET)","by mail-pl1-x642.google.com with SMTP id f8so962270plt.10\n\tfor ;\n\tThu, 19 Mar 2020 05:00:34 -0700 (PDT)","from kaaira-HP-Pavilion-Notebook ([103.113.213.153])\n\tby smtp.gmail.com with ESMTPSA id\n\tg19sm2300587pfh.141.2020.03.19.05.00.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 19 Mar 2020 05:00:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623;\n\th=from:date:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=7ZAT6I7sy9+vrzVvirqjW+jaV2qtJihpnjbTBdA/4OA=;\n\tb=HxvSdh64sE034E8M4f5JjJsTg1IIB9+LIfy6wlf+3nO1SBj6uqeBDV8UKCze7mei2J\n\toflBU3wINza7YSm4PPSQwDIKgniI601ik8Wuzpb/0xCAgiW6BCTO6fBYOfypcu+Axqme\n\t+6ONrBNex/DHd3RlmLhlKKP4qJYE5ths3UO8A1lK+7URaZmyLO0kcmx1eYJcaihTqkWU\n\tuRwBYIqu/gwW4ULfysy00qsWlLslvoYAno5pGSh2fsU51h1HnTlftlKwX5YdesrJct+X\n\t7zXmL1APFfTXVClub/0sfn29kJngFL/9xnM7xSciP9kORG16LL25B6QIhKjRAmxfPH0Z\n\tKdKg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:date:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=7ZAT6I7sy9+vrzVvirqjW+jaV2qtJihpnjbTBdA/4OA=;\n\tb=TZbi2X4Du5pj+JmZvv+NMMAGeETra01eyOFaJF3cOhzi/RORN68Z7d/VuyFFGFDLO7\n\toNSbMcb2RG4LqxDDiltm/GW+AuCWQ9oO4hTA5Oo1tU3C3x7RXmU6TqaNFNrEgYkZwLdL\n\tJ/DWX+tPQ2eCyml98LuiNyVl2PlVQjU75FUY87uHiY6JzahG/oYHdTprUip9E3uWqVZy\n\tjG4zlCTC1D/02btdT+P2EQsteej4pbcotaSIpxCVKcGAxq8WeR8mOk38uTS2bHz4pff/\n\tuyGtWEOn8MpHYlKTeAk6s1+MZKYzvZxXZZB4SiIBxqvYqO77NgZxyxudrLH+hS8NcRiS\n\tMJpg==","X-Gm-Message-State":"ANhLgQ0VQEt82LHSicwHdWi6q71Y20BGXxWFrXJX+Chyia39QltJl6ZQ\n\tJ7DRNoD8Me8khk+g8NR9FhhJpg==","X-Google-Smtp-Source":"ADFU+vum0G8YeCuQl0V+YXrm9It+ffwMB1vng9izqZ52QlDdwtHNHNFtPaTFh6pz/VoPMwFpD5h4+Q==","X-Received":"by 2002:a17:902:788e:: with SMTP id\n\tq14mr3228208pll.72.1584619233198; \n\tThu, 19 Mar 2020 05:00:33 -0700 (PDT)","From":"Kaaira Gupta ","X-Google-Original-From":"Kaaira Gupta ","Date":"Thu, 19 Mar 2020 17:30:26 +0530","To":"Kieran Bingham ","Cc":"Kaaira Gupta , libcamera-devel@lists.libcamera.org,\n\tHelen Koike ,\n\tVaishali Thakkar ","Message-ID":"<20200319120026.GA30517@kaaira-HP-Pavilion-Notebook>","References":"<20200319095406.GA26435@kaaira-HP-Pavilion-Notebook>\n\t<7c8ad10a-05be-5f32-9a28-4bb04ab8b272@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<7c8ad10a-05be-5f32-9a28-4bb04ab8b272@ideasonboard.com>","User-Agent":"Mutt/1.9.4 (2018-02-28)","Subject":"Re: [libcamera-devel] [PATCH LIBCAMERA] libcamera: utils: merge\n\tisLibcamerainstalled with libcameraPath","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 19 Mar 2020 12:00:35 -0000"}}]