{"id":3183,"url":"https://patchwork.libcamera.org/api/patches/3183/?format=json","web_url":"https://patchwork.libcamera.org/patch/3183/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200318205034.949531-6-jacopo@jmondi.org>","date":"2020-03-18T20:50:28","name":"[libcamera-devel,v7,05/11] media: v4l2-ctrls: Add camera location and rotation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8ad6960cf09bfe0954840b94ba2ca7047e500c5f","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3183/mbox/","series":[{"id":736,"url":"https://patchwork.libcamera.org/api/series/736/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=736","date":"2020-03-18T20:50:23","name":"media: Report camera sensor properties","version":7,"mbox":"https://patchwork.libcamera.org/series/736/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3183/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3183/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37C5B60415\n\tfor ;\n\tWed, 18 Mar 2020 21:48:02 +0100 (CET)","from localhost.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 139CD20005;\n\tWed, 18 Mar 2020 20:47:59 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"Mauro Carvalho Chehab ,\n\tHans Verkuil ,\n\tSakari Ailus ,\n\tLaurent Pinchart , tfiga@google.com,\n\tpavel@ucw.cz","Cc":"Jacopo Mondi ,\n\tlinux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE\n\t(V4L/DVB)), libcamera-devel@lists.libcamera.org","Date":"Wed, 18 Mar 2020 21:50:28 +0100","Message-Id":"<20200318205034.949531-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200318205034.949531-1-jacopo@jmondi.org>","References":"<20200318205034.949531-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 05/11] media: v4l2-ctrls: Add camera\n\tlocation and rotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 18 Mar 2020 20:48:02 -0000"},"content":"Add support for the newly defined V4L2_CID_CAMERA_SENSOR_LOCATION\nand V4L2_CID_CAMERA_SENSOR_ROTATION read-only controls used to report\nthe camera device mounting position and orientation respectively.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++\n include/uapi/linux/v4l2-controls.h | 7 +++++++\n 2 files changed, 11 insertions(+)","diff":"diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c\nindex 2928c5e0a73d..e0aa24e8ad84 100644\n--- a/drivers/media/v4l2-core/v4l2-ctrls.c\n+++ b/drivers/media/v4l2-core/v4l2-ctrls.c\n@@ -1015,6 +1015,8 @@ const char *v4l2_ctrl_get_name(u32 id)\n \tcase V4L2_CID_PAN_SPEED:\t\treturn \"Pan, Speed\";\n \tcase V4L2_CID_TILT_SPEED:\t\treturn \"Tilt, Speed\";\n \tcase V4L2_CID_UNIT_CELL_SIZE:\t\treturn \"Unit Cell Size\";\n+\tcase V4L2_CID_CAMERA_SENSOR_LOCATION:\treturn \"Camera Sensor Location\";\n+\tcase V4L2_CID_CAMERA_SENSOR_ROTATION:\treturn \"Camera Sensor Rotation\";\n \n \t/* FM Radio Modulator controls */\n \t/* Keep the order of the 'case's the same as in v4l2-controls.h! */\n@@ -1341,6 +1343,8 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type,\n \t\tbreak;\n \tcase V4L2_CID_MIN_BUFFERS_FOR_CAPTURE:\n \tcase V4L2_CID_MIN_BUFFERS_FOR_OUTPUT:\n+\tcase V4L2_CID_CAMERA_SENSOR_LOCATION:\n+\tcase V4L2_CID_CAMERA_SENSOR_ROTATION:\n \t\t*type = V4L2_CTRL_TYPE_INTEGER;\n \t\t*flags |= V4L2_CTRL_FLAG_READ_ONLY;\n \t\tbreak;\ndiff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h\nindex 5a7bedee2b0e..2517d2f63d2f 100644\n--- a/include/uapi/linux/v4l2-controls.h\n+++ b/include/uapi/linux/v4l2-controls.h\n@@ -912,6 +912,13 @@ enum v4l2_auto_focus_range {\n #define V4L2_CID_PAN_SPEED\t\t\t(V4L2_CID_CAMERA_CLASS_BASE+32)\n #define V4L2_CID_TILT_SPEED\t\t\t(V4L2_CID_CAMERA_CLASS_BASE+33)\n \n+#define V4L2_CID_CAMERA_SENSOR_LOCATION\t\t(V4L2_CID_CAMERA_CLASS_BASE+34)\n+#define V4L2_LOCATION_FRONT\t\t\t0\n+#define V4L2_LOCATION_BACK\t\t\t1\n+#define V4L2_LOCATION_EXTERNAL\t\t\t2\n+\n+#define V4L2_CID_CAMERA_SENSOR_ROTATION\t\t(V4L2_CID_CAMERA_CLASS_BASE+35)\n+\n /* FM Modulator class control IDs */\n \n #define V4L2_CID_FM_TX_CLASS_BASE\t\t(V4L2_CTRL_CLASS_FM_TX | 0x900)\n","prefixes":["libcamera-devel","v7","05/11"]}