[{"id":4085,"web_url":"https://patchwork.libcamera.org/comment/4085/","msgid":"<20200319000841.GE3042581@oden.dyn.berto.se>","date":"2020-03-19T00:08:41","subject":"Re: [libcamera-devel] [PATCH] cam: Print one property per line","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-03-18 17:30:40 +0100, Jacopo Mondi wrote:\n> When printing camera properties, print one property per line.\n\n:-)\n\n> \n> Fixes: a14b6baca9af (\"cam: Add option to list camera properties\")\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/main.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index ea6f7914839c..25282a04dcae 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -284,7 +284,8 @@ int CamApp::listProperties()\n> \t\tconst ControlId *id = properties::properties.at(prop.first);\n> \t\tconst ControlValue &value = prop.second;\n> \n> -\t\tstd::cout << \"Property: \" << id->name() << \" = \" << value.toString();\n> +\t\tstd::cout << \"Property: \" << id->name() << \" = \"\n> +\t\t\t << value.toString() << std::endl;\n> \t}\n> \n> \treturn 0;\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C701460419\n\tfor ;\n\tThu, 19 Mar 2020 01:08:43 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id s13so462348ljm.1\n\tfor ;\n\tWed, 18 Mar 2020 17:08:43 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tq4sm177725lfp.18.2020.03.18.17.08.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 18 Mar 2020 17:08:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=nSqmsHcH7wu8BHiVj3XU0ADfo5pPdXAPmLV2FuxYuBI=;\n\tb=p0QIHVfsJvpvd1bFusNOGMU81I8I1bvBHKdMVgDeSeHUB/B1sMCnI4Z3haFY5NZ9qW\n\tnfQxrYnzjaYaGfkaEHLWKiV7qjkOajxIJqcRkMZ0iYrBhKAHGaydJK7B8h7Lg6Exw+gf\n\t1DB+WOz+fV/ePwKYfO3NW/0vNd+CFgbHqjLI5yq9VPgTBohyToYNfAkJdsuh7MyPYIz+\n\trUWfj4gbyfnIyDDndCcvWLUwuN9w1/XdUTRpFAj1yVaHzvxy2uqXu8h+MR7f3avX5xgu\n\tmy01n/e/c1WA0FzwjXOIFEnqa6qC/80cw4mxXXBRVcrQZXQNjqgaFCl+0ZTk+mz38eYK\n\thY0g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=nSqmsHcH7wu8BHiVj3XU0ADfo5pPdXAPmLV2FuxYuBI=;\n\tb=ZyBbWXaZZcrFk2Schq2GzkzVIdkhGXIk03PIqR7JmX/KZIJCBD2MYMw4W+g6KM4qVK\n\thXM39UT0HZxFFIJ1RtWndggN3HEHyPgFQ/b9y/GlTH1yS2IvxIRfYNY2Ok3hDN/AhjtW\n\t6ounRXxe8MHNY4zRh1/TMoFuy5psTMWT0ZzqyYObyk6bpTNFymVj8eNtIWsbKhaoG5nn\n\t8k1ofc/uWL+ai99u1/RT0ALs8xL1bshbxGXRLwTzPaegNJuYHmGnxhoMQ9DL+dOVq1i8\n\tMq7cgKC6TFoj/Qbwx7CxoG2b7ImcyhueF5GJDJEEF2YZqZ5gm+6fUaI3v8lsGRqJWsXL\n\tTaMg==","X-Gm-Message-State":"ANhLgQ2Z83uW0za1lIZVcO/+UH3vweWWJ9H0oXgUMTk9SpI7d+q1pMIN\n\tvpHfAPYCLROK5fT57+40GfVMzlyBmSg=","X-Google-Smtp-Source":"ADFU+vtpJf82ahrNp+8TIt07CQCXwXPszNqj027s/YuNCtJykv9hJLmQ9tPcXboOc2BKWMLkwV4H0Q==","X-Received":"by 2002:a2e:8192:: with SMTP id e18mr326351ljg.57.1584576523157; \n\tWed, 18 Mar 2020 17:08:43 -0700 (PDT)","Date":"Thu, 19 Mar 2020 01:08:41 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200319000841.GE3042581@oden.dyn.berto.se>","References":"<20200318163040.629527-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200318163040.629527-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] cam: Print one property per line","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 19 Mar 2020 00:08:44 -0000"}}]