{"id":3158,"url":"https://patchwork.libcamera.org/api/patches/3158/?format=json","web_url":"https://patchwork.libcamera.org/patch/3158/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200318033200.3042855-6-niklas.soderlund@ragnatech.se>","date":"2020-03-18T03:31:57","name":"[libcamera-devel,v3,5/8] libcamera: pipeline: uvcvideo: Translate from V4L2 to DRM pixel formats","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e2140b1927ab7ae3c20d6963f9853f13f2d6c4ea","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3158/mbox/","series":[{"id":730,"url":"https://patchwork.libcamera.org/api/series/730/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=730","date":"2020-03-18T03:31:52","name":"libcamera: PixelFormat: Turn into a class","version":3,"mbox":"https://patchwork.libcamera.org/series/730/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3158/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3158/checks/","tags":{},"headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90DEC629AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Mar 2020 04:32:38 +0100 (CET)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 1d31c314-68c9-11ea-9f85-005056917a89;\n\tWed, 18 Mar 2020 04:32:37 +0100 (CET)"],"X-Halon-ID":"1d31c314-68c9-11ea-9f85-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 18 Mar 2020 04:31:57 +0100","Message-Id":"<20200318033200.3042855-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200318033200.3042855-1-niklas.soderlund@ragnatech.se>","References":"<20200318033200.3042855-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 5/8] libcamera: pipeline: uvcvideo:\n\tTranslate from V4L2 to DRM pixel formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 18 Mar 2020 03:32:39 -0000"},"content":"When generating a camera configuration pixel formats directly from the\nvideo device are used that contains V4L2 pixel formats. Translate the\npixel formats to DRM before using them in the camera configuration.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo.cpp | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex 320da2685795c041..1de091e0c0e57f7c 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -153,8 +153,19 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n \tif (roles.empty())\n \t\treturn config;\n \n-\tImageFormats v4l2formats = data->video_->formats();\n-\tStreamFormats formats(v4l2formats.data());\n+\tstd::map<unsigned int, std::vector<SizeRange>> v4l2Formats =\n+\t\tdata->video_->formats().data();\n+\tstd::map<PixelFormat, std::vector<SizeRange>> deviceFormats;\n+\tstd::transform(v4l2Formats.begin(), v4l2Formats.end(),\n+\t\t       std::inserter(deviceFormats, deviceFormats.begin()),\n+\t\t       [&](const decltype(v4l2Formats)::value_type &format) {\n+\t\t\t       return decltype(deviceFormats)::value_type{\n+\t\t\t\t       data->video_->toPixelFormat(format.first),\n+\t\t\t\t       format.second\n+\t\t\t       };\n+\t\t       });\n+\n+\tStreamFormats formats(deviceFormats);\n \tStreamConfiguration cfg(formats);\n \n \tcfg.pixelFormat = formats.pixelformats().front();\n","prefixes":["libcamera-devel","v3","5/8"]}