[{"id":4075,"web_url":"https://patchwork.libcamera.org/comment/4075/","msgid":"<20200318130101.GK4733@pendragon.ideasonboard.com>","date":"2020-03-18T13:01:01","subject":"Re: [libcamera-devel] [PATCH v3 2/8] libcamera: pixelformats:\n\tinclude linux/drm_fourcc.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nReviewed-by: Laurent Pinchart \n\nOn Wed, Mar 18, 2020 at 04:31:54AM +0100, Niklas Söderlund wrote:\n> Instead of having to include linux/drm_fourcc.h everywhere a DRM FourCC\n> are used in conjunction with PixelFormat include the header directly in\n\ns/are/is/\n\n> pixelformats.h.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/pixelformats.h | 2 ++\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n> src/libcamera/pipeline/vimc.cpp | 1 -\n> src/libcamera/v4l2_videodevice.cpp | 1 -\n> src/qcam/format_converter.cpp | 2 --\n> src/v4l2/v4l2_camera_proxy.cpp | 1 -\n> 7 files changed, 2 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/pixelformats.h b/include/libcamera/pixelformats.h\n> index 6e25b8d8b76e5961..544363af7a8c6f05 100644\n> --- a/include/libcamera/pixelformats.h\n> +++ b/include/libcamera/pixelformats.h\n> @@ -9,6 +9,8 @@\n> \n> #include \n> \n> +#include \n> +\n> namespace libcamera {\n> \n> using PixelFormat = uint32_t;\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 0c2a217c9ea8f6ba..1e3d8a107c6475be 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index dec0ad6118241ff1..a95ae48ac8cfbc98 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -11,7 +11,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index a30e416e6000bcda..de2458afff3a4784 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 858310c3b810350a..3869766046236f34 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -18,7 +18,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\n> index d4a66f381f5a1b78..7b8ad77c42fe85d4 100644\n> --- a/src/qcam/format_converter.cpp\n> +++ b/src/qcam/format_converter.cpp\n> @@ -7,8 +7,6 @@\n> \n> #include \n> \n> -#include \n> -\n> #include \n> \n> #include \"format_converter.h\"\n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index b620f236499cf77d..e349fbddc2a4d5a2 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6C5060418\n\tfor ;\n\tWed, 18 Mar 2020 14:01:06 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84545AC0;\n\tWed, 18 Mar 2020 14:01:06 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584536466;\n\tbh=xHlcgyj3E10zWVufDs48z+bVZqhiyoamyQq8ldgELXk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GNu8qyKIdgJXt4M5pIUpKDlNDbCkkOKMSmvgVY+lbJmUwaGYb815TZVhWIIHXLIlP\n\tHa0uohn21l5oZXzlaE//sTmXLwGrEp/Co6U8jiRHajeDaKJwHim53TAIGcoQ/Zkr0Q\n\tMDJEgCMYezL6vWxcfq+Sgk5Dy7YIg5eIewPmySYg=","Date":"Wed, 18 Mar 2020 15:01:01 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200318130101.GK4733@pendragon.ideasonboard.com>","References":"<20200318033200.3042855-1-niklas.soderlund@ragnatech.se>\n\t<20200318033200.3042855-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200318033200.3042855-3-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 2/8] libcamera: pixelformats:\n\tinclude linux/drm_fourcc.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 18 Mar 2020 13:01:07 -0000"}}]