[{"id":471,"web_url":"https://patchwork.libcamera.org/comment/471/","msgid":"<20190122084827.7xx4vsaspglrd6bj@uno.localdomain>","date":"2019-01-22T08:48:27","subject":"Re: [libcamera-devel] [PATCH v2 4/4] libcamera: Use log categories","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Jan 21, 2019 at 09:56:06PM +0200, Laurent Pinchart wrote:\n> Use log categories in the whole existing code base.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/camera_manager.cpp | 14 ++++---\n> src/libcamera/device_enumerator.cpp | 25 +++++++-----\n> src/libcamera/event_dispatcher.cpp | 4 ++\n> src/libcamera/event_dispatcher_poll.cpp | 28 +++++++------\n> src/libcamera/media_device.cpp | 52 +++++++++++++++----------\n> src/libcamera/media_object.cpp | 7 +++-\n> src/libcamera/pipeline_handler.cpp | 5 ++-\n> src/libcamera/timer.cpp | 7 +++-\n> src/libcamera/v4l2_device.cpp | 25 +++++++-----\n> 9 files changed, 107 insertions(+), 60 deletions(-)\n>\n\n[snip]\n\n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 55c510e3b79a..22d4edee1cb2 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n\nIt seems to me line 97:\n\tLOG(Debug) << \"Found a match with \" << log::quoted(name);\n\nhas not been changed to use categories. Was this intentional?\n\nThanks\n j","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F47260C81\n\tfor ;\n\tTue, 22 Jan 2019 09:48:15 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id D21C2100014;\n\tTue, 22 Jan 2019 08:48:14 +0000 (UTC)"],"Date":"Tue, 22 Jan 2019 09:48:27 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190122084827.7xx4vsaspglrd6bj@uno.localdomain>","References":"<20190121195606.8526-1-laurent.pinchart@ideasonboard.com>\n\t<20190121195606.8526-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"3rzcgm7lewgygbat\"","Content-Disposition":"inline","In-Reply-To":"<20190121195606.8526-5-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] libcamera: Use log categories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 22 Jan 2019 08:48:15 -0000"}},{"id":501,"web_url":"https://patchwork.libcamera.org/comment/501/","msgid":"<20190122142436.GH4455@pendragon.ideasonboard.com>","date":"2019-01-22T14:24:36","subject":"Re: [libcamera-devel] [PATCH v2 4/4] libcamera: Use log categories","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Tue, Jan 22, 2019 at 09:48:27AM +0100, Jacopo Mondi wrote:\n> On Mon, Jan 21, 2019 at 09:56:06PM +0200, Laurent Pinchart wrote:\n> > Use log categories in the whole existing code base.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/camera_manager.cpp | 14 ++++---\n> > src/libcamera/device_enumerator.cpp | 25 +++++++-----\n> > src/libcamera/event_dispatcher.cpp | 4 ++\n> > src/libcamera/event_dispatcher_poll.cpp | 28 +++++++------\n> > src/libcamera/media_device.cpp | 52 +++++++++++++++----------\n> > src/libcamera/media_object.cpp | 7 +++-\n> > src/libcamera/pipeline_handler.cpp | 5 ++-\n> > src/libcamera/timer.cpp | 7 +++-\n> > src/libcamera/v4l2_device.cpp | 25 +++++++-----\n> > 9 files changed, 107 insertions(+), 60 deletions(-)\n> >\n> \n> [snip]\n> \n> > diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> > index 55c510e3b79a..22d4edee1cb2 100644\n> > --- a/src/libcamera/device_enumerator.cpp\n> > +++ b/src/libcamera/device_enumerator.cpp\n> \n> It seems to me line 97:\n> \tLOG(Debug) << \"Found a match with \" << log::quoted(name);\n> \n> has not been changed to use categories. Was this intentional?\n\nI see no such code in the master branch :-)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F7B360B1B\n\tfor ;\n\tTue, 22 Jan 2019 15:24:37 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FFE653E;\n\tTue, 22 Jan 2019 15:24:37 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548167077;\n\tbh=Abjvgn0rZwZoAcRz7gZHhuXCIyDEXqdiO9FVDxit7ow=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XTjr17GlCHv26g5XpBL1oh+LmoV5+B2xHtStbf5L3l6RgYrvl3kOe/nhAi6aAXTXg\n\tBD4vv/901nRDjIC/PVQRgmm5uoT4SX1KB0qeZ9DB9pdSEhdH/8nhJ1weDku8gYTRaI\n\tL/hgVJs4fzSbY4b2gbeQP/4/BAvRAOv2SI5wIx4g=","Date":"Tue, 22 Jan 2019 16:24:36 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190122142436.GH4455@pendragon.ideasonboard.com>","References":"<20190121195606.8526-1-laurent.pinchart@ideasonboard.com>\n\t<20190121195606.8526-5-laurent.pinchart@ideasonboard.com>\n\t<20190122084827.7xx4vsaspglrd6bj@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190122084827.7xx4vsaspglrd6bj@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] libcamera: Use log categories","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 22 Jan 2019 14:24:37 -0000"}}]