[{"id":4059,"web_url":"https://patchwork.libcamera.org/comment/4059/","msgid":"<20200317202651.GA2753013@oden.dyn.berto.se>","date":"2020-03-17T20:26:51","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_subdevice: Don't use\n\tdoxygen \\ref needlessly","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-03-17 22:19:25 +0200, Laurent Pinchart wrote:\n> The doxygen \\ref command is used to generate a reference to a function,\n> while adding parentheses after the function name is enough. Simplify the\n> documentation.\n\nNeat!\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index e0985e05a8de..16b015595163 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -228,8 +228,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> * \"ActiveFormat\" or \\ref V4L2Subdevice::TryFormat \"TryFormat\"\n> *\n> * Apply the requested image format to the desired media pad and return the\n> - * actually applied format parameters, as \\ref V4L2Subdevice::getFormat would\n> - * do.\n> + * actually applied format parameters, as getFormat() would do.\n> *\n> * \\return 0 on success or a negative error code otherwise\n> */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14D0662923\n\tfor ;\n\tTue, 17 Mar 2020 21:26:53 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id w1so24513611ljh.5\n\tfor ;\n\tTue, 17 Mar 2020 13:26:53 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tt27sm3003010ljk.78.2020.03.17.13.26.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Mar 2020 13:26:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=zTyHpBKKMQhW6FWA5+O+rDMVv1RF31eBDwlN6GppHpU=;\n\tb=toDuVTDjjz9Yyp0/3JTjDe9X0baRJKsbUkCYcUQ/vimUsW7ip5C+w62bKaRv2hDv8e\n\tiwjDiCIwnzHD8wPI8Isji/yoRvoJG8jlRa6jftGpLwh6cANs8/7a+RzrAfUcadfAqYaz\n\tDBbTG9sLbtU21aeMYBIitJjEnjajzUaUJ/MM/UkylTJzPVg2cpQjLUADkkXdFucr7qXr\n\tlu5X/ABU4dgH5FuCg8+sFT18Ga8JKh5L2jaJzlhGkd4J9JgSHvZy5WkqIMk7ks9UXtqY\n\t096L7ttHbeXum6kLiKszm59J9UJyBAodqqUF/JAcTcwdkuM/00ZWuYN/iDA/cOAtu78K\n\trmXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=zTyHpBKKMQhW6FWA5+O+rDMVv1RF31eBDwlN6GppHpU=;\n\tb=gQxIGLK4DvjRKhV0QISt/0Krs6RhPdbAUoGbLOkO9HCtfU8+U/viudtwwFDoMobWTl\n\thy1MWDdaEw5y6115MeHj6sfBxpLDzEHoVqX9H0NxtMpGnUuAoxK68F1lBbqC0ZX0mgeq\n\t5USxiLbt0LB/iuhyJHuF2zvmB9ehtSN5XiI0Hm8z05xPyUbIfR9KzgioCcjyuESLIZ8D\n\torMCqQrSAW0l+OIySLsHDjqmtoJXPwO96kRYl7N2MAUpzkPzHBX+eD2d2DYrqoUvLUgq\n\tEghlSwmkiXqbbtXh2mUAgTQ6ria1SUQeaBcJChGhTl4ftyl9vDYEzL5z842zcyhWS4Fe\n\tS67A==","X-Gm-Message-State":"ANhLgQ3nQVp+q6JSiMrDFoSHYsIiKMhkQ6togZCDk47ZqeLTwdKArRf3\n\tjGiTrZM+Iof58X7FvhKd9C7SfRueDf8=","X-Google-Smtp-Source":"ADFU+vtpQKpr/LjvvGsqjYE2DqjzcbEtbu0U4+okBaeHOr2qnphA1P5KJTM4tNjCqbWMZTIpzKLzzQ==","X-Received":"by 2002:a05:651c:110b:: with SMTP id\n\td11mr329698ljo.52.1584476812280; \n\tTue, 17 Mar 2020 13:26:52 -0700 (PDT)","Date":"Tue, 17 Mar 2020 21:26:51 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200317202651.GA2753013@oden.dyn.berto.se>","References":"<20200317201925.6515-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200317201925.6515-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_subdevice: Don't use\n\tdoxygen \\ref needlessly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 17 Mar 2020 20:26:53 -0000"}}]