{"id":3145,"url":"https://patchwork.libcamera.org/api/patches/3145/?format=json","web_url":"https://patchwork.libcamera.org/patch/3145/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200317201925.6515-1-laurent.pinchart@ideasonboard.com>","date":"2020-03-17T20:19:25","name":"[libcamera-devel] libcamera: v4l2_subdevice: Don't use doxygen \\ref needlessly","commit_ref":"49a35da2ceaee33a296f9e30b1cf784a656e0224","pull_url":null,"state":"accepted","archived":false,"hash":"504cc1f9d601cb8f4e5ae6eba4ddd6b6633933a1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3145/mbox/","series":[{"id":728,"url":"https://patchwork.libcamera.org/api/series/728/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=728","date":"2020-03-17T20:19:25","name":"[libcamera-devel] libcamera: v4l2_subdevice: Don't use doxygen \\ref needlessly","version":1,"mbox":"https://patchwork.libcamera.org/series/728/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3145/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3145/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1983962923\n\tfor ;\n\tTue, 17 Mar 2020 21:19:39 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5C1CF9\n\tfor ;\n\tTue, 17 Mar 2020 21:19:38 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584476378;\n\tbh=ifp40vuAvHfBLQM4/w1AJ8G3bKmL2zsRoCueMUW2NUY=;\n\th=From:To:Subject:Date:From;\n\tb=EXUCihc3imu4t9xvJB3XtQp5uvsDEaBfCz6Fq+Pdb8nUr1cZYSiAchxd9n+zzSO6f\n\tOjsV9vRrIEYWoTnmFEqMDBRLGxzJhopcTv+DuxNQ0s1y2nlX4rBwSgrCTclLxhuwWk\n\t4lcbx0Vpc8aw0qtmE/546iad6hQeSsYFilpLWbog=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 17 Mar 2020 22:19:25 +0200","Message-Id":"<20200317201925.6515-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_subdevice: Don't use\n\tdoxygen \\ref needlessly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 17 Mar 2020 20:19:39 -0000"},"content":"The doxygen \\ref command is used to generate a reference to a function,\nwhile adding parentheses after the function name is enough. Simplify the\ndocumentation.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/v4l2_subdevice.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex e0985e05a8de..16b015595163 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -228,8 +228,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n * \"ActiveFormat\" or \\ref V4L2Subdevice::TryFormat \"TryFormat\"\n *\n * Apply the requested image format to the desired media pad and return the\n- * actually applied format parameters, as \\ref V4L2Subdevice::getFormat would\n- * do.\n+ * actually applied format parameters, as getFormat() would do.\n *\n * \\return 0 on success or a negative error code otherwise\n */\n","prefixes":["libcamera-devel"]}