{"id":3124,"url":"https://patchwork.libcamera.org/api/patches/3124/?format=json","web_url":"https://patchwork.libcamera.org/patch/3124/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200316214310.27665-8-laurent.pinchart@ideasonboard.com>","date":"2020-03-16T21:43:07","name":"[libcamera-devel,v2,07/10] libcamera: v4l2_videodevice: Map V4L2_PIX_FMT_GREY to DRM FourCC","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f8113d1a3b9c2f77ef985909ad9aef91772a2d6c","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3124/mbox/","series":[{"id":724,"url":"https://patchwork.libcamera.org/api/series/724/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=724","date":"2020-03-16T21:43:00","name":"Simple pipeline handler","version":2,"mbox":"https://patchwork.libcamera.org/series/724/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3124/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3124/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 876B262923\n\tfor ;\n\tMon, 16 Mar 2020 22:43:28 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9CFB7AD8;\n\tMon, 16 Mar 2020 22:43:27 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584395008;\n\tbh=6izEgDMmxR2rEEL5UKfYi0Sfs/I/Em6JXum7w1dTgBg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UyF6kUH9mvbpe/jLWtJqZ0g8alrs8uhikd30DGFF1uotdLYzQ8nvGq+Erb2cbpwC4\n\tast2xEAkyPwOmNHmd9zOrrqr0ll5FxoJFFQyqgNMWeAEoNJ7Lz0TsJkS6isMBfmPLX\n\tqbqXGcJgi8bBSJKLlwbk6xERPNY9M/e7etDiDRjY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Martijn Braam , Mickael GUENE , \n\tBenjamin GAIGNARD ,\n\tAndrey Konovalov ","Date":"Mon, 16 Mar 2020 23:43:07 +0200","Message-Id":"<20200316214310.27665-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200316214310.27665-1-laurent.pinchart@ideasonboard.com>","References":"<20200316214310.27665-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 07/10] libcamera: v4l2_videodevice: Map\n\tV4L2_PIX_FMT_GREY to DRM FourCC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 16 Mar 2020 21:43:28 -0000"},"content":"DRM has a format for 8-bit greyscale data, DRM_FORMAT_R8. Despite the\n'R' name, which comes from GL/Vulkan to mean single-channel data, the\nformat maps to greyscale for display. We can thus map it to\nV4L2_PIX_FMT_GREY.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/v4l2_videodevice.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 28de3d2fe5c6..8e56e934b04f 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1614,12 +1614,15 @@ PixelFormat V4L2VideoDevice::toPixelFormat(uint32_t v4l2Fourcc)\n \tcase V4L2_PIX_FMT_NV21M:\n \t\treturn DRM_FORMAT_NV21;\n \n+\t/* Greyscale formats. */\n+\tcase V4L2_PIX_FMT_GREY:\n+\t\treturn DRM_FORMAT_R8;\n+\n \t/* Compressed formats. */\n \tcase V4L2_PIX_FMT_MJPEG:\n \t\treturn DRM_FORMAT_MJPEG;\n \n \t/* V4L2 formats not yet supported by DRM. */\n-\tcase V4L2_PIX_FMT_GREY:\n \tdefault:\n \t\t/*\n \t\t * \\todo We can't use LOG() in a static method of a Loggable\n@@ -1698,6 +1701,10 @@ uint32_t V4L2VideoDevice::toV4L2Fourcc(PixelFormat pixelFormat, bool multiplanar\n \tcase DRM_FORMAT_NV21:\n \t\treturn V4L2_PIX_FMT_NV21;\n \n+\t/* Greyscale formats. */\n+\tcase DRM_FORMAT_R8:\n+\t\treturn V4L2_PIX_FMT_GREY;\n+\n \t/* Compressed formats. */\n \tcase DRM_FORMAT_MJPEG:\n \t\treturn V4L2_PIX_FMT_MJPEG;\n","prefixes":["libcamera-devel","v2","07/10"]}