[{"id":4024,"web_url":"https://patchwork.libcamera.org/comment/4024/","msgid":"<20200316132759.GL4732@pendragon.ideasonboard.com>","date":"2020-03-16T13:27:59","subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle: Add a ShellChecker","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Mar 16, 2020 at 01:21:21PM +0000, Kieran Bingham wrote:\n> Hook the utility 'shellcheck' into our checkstyle helper to\n> automatically verify shell script additions.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/checkstyle.py | 38 ++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 38 insertions(+)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 5ac14508bad5..0827a1e6ba0f 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -341,6 +341,44 @@ class Pep8Checker(StyleChecker):\n> return issues\n> \n> \n> +class ShellChecker(StyleChecker):\n> + patterns = ('*.sh',)\n> + results_line_regex = re.compile('In - line ([0-9]+):')\n> +\n> + def __init__(self, content):\n> + super().__init__()\n> + self.__content = content\n> +\n> + def check(self, line_numbers):\n> + issues = []\n> + data = ''.join(self.__content).encode('utf-8')\n> +\n> + try:\n> + ret = subprocess.run(['shellcheck', '-Cnever', '-'],\n> + input=data, stdout=subprocess.PIPE)\n> + except FileNotFoundError:\n> + issues.append(StyleIssue(0, None, \"Please install shellcheck to validate shell script additions\"))\n> + return issues\n> +\n> + results = ret.stdout.decode('utf-8').splitlines()\n> + for nr, item in enumerate(results):\n> + search = re.search(ShellChecker.results_line_regex, item)\n> + if search is None:\n> + continue\n> +\n> + line_number = int(search.group(1))\n> + line = results[nr + 1]\n> + msg = results[nr + 2]\n> +\n> + # Determined, but not yet used\n> + position = msg.find('^') + 1\n> +\n> + if line_number in line_numbers:\n> + issues.append(StyleIssue(line_number, line, msg))\n> +\n> + return issues\n> +\n> +\n> # ------------------------------------------------------------------------------\n> # Formatters\n> #","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC8AD6041A\n\tfor ;\n\tMon, 16 Mar 2020 14:28:04 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FD67A3B;\n\tMon, 16 Mar 2020 14:28:04 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584365284;\n\tbh=baUR6GnIljqgyFDbH9xzYWO0T7VkW2/rGwMSPf11+qU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XZNY/+X7Uq5I/FQ3RVp+sOHRc1Fed9vnGcdsQpUvaIot5Rd+qWFQPo/7mfU0Lb2Li\n\tbLaRCHGoml4L87KsIgvBlz9Nx9NJGn/PW8OOAHiqRojiHRw/6J6fDM64G9kqQeV6Ag\n\to46A8GrynkFfrbq7J6U73P9eD1SSzSGnP9fP22Vo=","Date":"Mon, 16 Mar 2020 15:27:59 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200316132759.GL4732@pendragon.ideasonboard.com>","References":"<20200316132121.23330-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200316132121.23330-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle: Add a ShellChecker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 16 Mar 2020 13:28:05 -0000"}},{"id":4026,"web_url":"https://patchwork.libcamera.org/comment/4026/","msgid":"<69b138c1-1aa7-c90c-35cb-5c29286652de@ideasonboard.com>","date":"2020-03-16T13:43:51","subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle: Add a ShellChecker","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent\n\nOn 16/03/2020 13:27, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Mon, Mar 16, 2020 at 01:21:21PM +0000, Kieran Bingham wrote:\n>> Hook the utility 'shellcheck' into our checkstyle helper to\n>> automatically verify shell script additions.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \n\n\nThanks, I meant to add here as a note:\n\nThis produces the following output:\n\n\nlibcamera/utils$ ./checkstyle.py HEAD^\n-----------------------------------------------------------------\n652973f905fdb2b642e7893d7d39c000432c0e03 DNI: Bad shell bad shell\n-----------------------------------------------------------------\n--- utils/gen-version.sh\n+++ utils/gen-version.sh\n#25: ^-- SC2039: In POSIX sh, [[ ]] is undefined.\n+if [[ -z \"$build_dir\" ]] || (echo \"$build_dir\" | grep -q \"$src_dir\")\n---\n1 potential style issue detected, please review\n\nThe only 'undesirable' issue is that in shellcheck, the message is\nprinted below the 'line', and thus the ' ^--' is aligned to the point\nof the issue, which it isn't here.\n\nThat's not currently possible in our checkstyle, and I haven't even\nfiltered out the '^--', but those can be future improvements, and are\npurely cosmetic really.\n\n--\nKieran\n\n\n\n> \n>> ---\n>> utils/checkstyle.py | 38 ++++++++++++++++++++++++++++++++++++++\n>> 1 file changed, 38 insertions(+)\n>>\n>> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n>> index 5ac14508bad5..0827a1e6ba0f 100755\n>> --- a/utils/checkstyle.py\n>> +++ b/utils/checkstyle.py\n>> @@ -341,6 +341,44 @@ class Pep8Checker(StyleChecker):\n>> return issues\n>> \n>> \n>> +class ShellChecker(StyleChecker):\n>> + patterns = ('*.sh',)\n>> + results_line_regex = re.compile('In - line ([0-9]+):')\n>> +\n>> + def __init__(self, content):\n>> + super().__init__()\n>> + self.__content = content\n>> +\n>> + def check(self, line_numbers):\n>> + issues = []\n>> + data = ''.join(self.__content).encode('utf-8')\n>> +\n>> + try:\n>> + ret = subprocess.run(['shellcheck', '-Cnever', '-'],\n>> + input=data, stdout=subprocess.PIPE)\n>> + except FileNotFoundError:\n>> + issues.append(StyleIssue(0, None, \"Please install shellcheck to validate shell script additions\"))\n>> + return issues\n>> +\n>> + results = ret.stdout.decode('utf-8').splitlines()\n>> + for nr, item in enumerate(results):\n>> + search = re.search(ShellChecker.results_line_regex, item)\n>> + if search is None:\n>> + continue\n>> +\n>> + line_number = int(search.group(1))\n>> + line = results[nr + 1]\n>> + msg = results[nr + 2]\n>> +\n>> + # Determined, but not yet used\n>> + position = msg.find('^') + 1\n>> +\n>> + if line_number in line_numbers:\n>> + issues.append(StyleIssue(line_number, line, msg))\n>> +\n>> + return issues\n>> +\n>> +\n>> # ------------------------------------------------------------------------------\n>> # Formatters\n>> #\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A28DD6041A\n\tfor ;\n\tMon, 16 Mar 2020 14:43:57 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC67DA3B;\n\tMon, 16 Mar 2020 14:43:56 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584366237;\n\tbh=IBqu+9A1KSrmDLL04TcejGM4DJcBzFYhS3BNdZg+MP0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=nGBHTvDw8M6ucKz9/qCBiX2mrTnFybbhOL2+aiHQtnlJzgeSJFEtBM/8W+5gm6Wfp\n\ttb8MeRHtQPvEtyMc8wRIrFWuSbgWSJoTUhSrJDNX1Ko3kCbuagN2Gj2f/TMODJNYM0\n\teTSs8R3L0QTvKvkDGUCptlGRi9HO3shFH/Uj6Wvs=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera devel ","References":"<20200316132121.23330-1-kieran.bingham@ideasonboard.com>\n\t<20200316132759.GL4732@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<69b138c1-1aa7-c90c-35cb-5c29286652de@ideasonboard.com>","Date":"Mon, 16 Mar 2020 13:43:51 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200316132759.GL4732@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle: Add a ShellChecker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 16 Mar 2020 13:43:57 -0000"}},{"id":4028,"web_url":"https://patchwork.libcamera.org/comment/4028/","msgid":"<20200316135020.GM4732@pendragon.ideasonboard.com>","date":"2020-03-16T13:50:20","subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle: Add a ShellChecker","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 16, 2020 at 01:43:51PM +0000, Kieran Bingham wrote:\n> On 16/03/2020 13:27, Laurent Pinchart wrote:\n> > On Mon, Mar 16, 2020 at 01:21:21PM +0000, Kieran Bingham wrote:\n> >> Hook the utility 'shellcheck' into our checkstyle helper to\n> >> automatically verify shell script additions.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> > \n> > Reviewed-by: Laurent Pinchart \n> \n> Thanks, I meant to add here as a note:\n> \n> This produces the following output:\n> \n> libcamera/utils$ ./checkstyle.py HEAD^\n> -----------------------------------------------------------------\n> 652973f905fdb2b642e7893d7d39c000432c0e03 DNI: Bad shell bad shell\n> -----------------------------------------------------------------\n> --- utils/gen-version.sh\n> +++ utils/gen-version.sh\n> #25: ^-- SC2039: In POSIX sh, [[ ]] is undefined.\n> +if [[ -z \"$build_dir\" ]] || (echo \"$build_dir\" | grep -q \"$src_dir\")\n> ---\n> 1 potential style issue detected, please review\n> \n> The only 'undesirable' issue is that in shellcheck, the message is\n> printed below the 'line', and thus the ' ^--' is aligned to the point\n> of the issue, which it isn't here.\n> \n> That's not currently possible in our checkstyle, and I haven't even\n> filtered out the '^--', but those can be future improvements, and are\n> purely cosmetic really.\n\nI was about to recommend dropping the ^-- marker, but it serves as a\nreminder that we need to fix this, and will hopefully nerd-snipe someone\n:-)\n\n> >> ---\n> >> utils/checkstyle.py | 38 ++++++++++++++++++++++++++++++++++++++\n> >> 1 file changed, 38 insertions(+)\n> >>\n> >> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> >> index 5ac14508bad5..0827a1e6ba0f 100755\n> >> --- a/utils/checkstyle.py\n> >> +++ b/utils/checkstyle.py\n> >> @@ -341,6 +341,44 @@ class Pep8Checker(StyleChecker):\n> >> return issues\n> >> \n> >> \n> >> +class ShellChecker(StyleChecker):\n> >> + patterns = ('*.sh',)\n> >> + results_line_regex = re.compile('In - line ([0-9]+):')\n> >> +\n> >> + def __init__(self, content):\n> >> + super().__init__()\n> >> + self.__content = content\n> >> +\n> >> + def check(self, line_numbers):\n> >> + issues = []\n> >> + data = ''.join(self.__content).encode('utf-8')\n> >> +\n> >> + try:\n> >> + ret = subprocess.run(['shellcheck', '-Cnever', '-'],\n> >> + input=data, stdout=subprocess.PIPE)\n> >> + except FileNotFoundError:\n> >> + issues.append(StyleIssue(0, None, \"Please install shellcheck to validate shell script additions\"))\n> >> + return issues\n> >> +\n> >> + results = ret.stdout.decode('utf-8').splitlines()\n> >> + for nr, item in enumerate(results):\n> >> + search = re.search(ShellChecker.results_line_regex, item)\n> >> + if search is None:\n> >> + continue\n> >> +\n> >> + line_number = int(search.group(1))\n> >> + line = results[nr + 1]\n> >> + msg = results[nr + 2]\n> >> +\n> >> + # Determined, but not yet used\n> >> + position = msg.find('^') + 1\n> >> +\n> >> + if line_number in line_numbers:\n> >> + issues.append(StyleIssue(line_number, line, msg))\n> >> +\n> >> + return issues\n> >> +\n> >> +\n> >> # ------------------------------------------------------------------------------\n> >> # Formatters\n> >> #","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03E356041A\n\tfor ;\n\tMon, 16 Mar 2020 14:50:27 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 825ECA3B;\n\tMon, 16 Mar 2020 14:50:26 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584366626;\n\tbh=4o59TuB3yoXxRSWh7WBBHXt9wN5ncxiAc3YsGDEBHLo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=novXME1G5L13FT2IwACOMrjIMEmHw0bL+R9OV/jgQghkkqznTcgAPoLaMgxntH0bf\n\tM5v4v25MYnKNUObVlWJbJNrxb63g6kdEo88zVuXusgK9PkRA3bQVqg50qrBwrz88CM\n\tlQplFK4oGJ7icEGvq0aaoWw/ZNeKRk/9XA1UFieg=","Date":"Mon, 16 Mar 2020 15:50:20 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200316135020.GM4732@pendragon.ideasonboard.com>","References":"<20200316132121.23330-1-kieran.bingham@ideasonboard.com>\n\t<20200316132759.GL4732@pendragon.ideasonboard.com>\n\t<69b138c1-1aa7-c90c-35cb-5c29286652de@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<69b138c1-1aa7-c90c-35cb-5c29286652de@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] utils: checkstyle: Add a ShellChecker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 16 Mar 2020 13:50:27 -0000"}}]