[{"id":4178,"web_url":"https://patchwork.libcamera.org/comment/4178/","msgid":"<20200323102651.GB4768@pendragon.ideasonboard.com>","date":"2020-03-23T10:26:51","subject":"Re: [libcamera-devel] [RFC 1/6] libcamera: stream: Add\n\tStillCaptureRaw role","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Mar 16, 2020 at 03:41:41AM +0100, Niklas Söderlund wrote:\n> Add role to be used for streams capturing frames in a raw format for\n> still capture in a low frame rate.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/stream.h | 1 +\n> src/libcamera/stream.cpp | 4 ++++\n> 2 files changed, 5 insertions(+)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index 29a8030dff71d58f..c4c0241ec9f34727 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -58,6 +58,7 @@ private:\n> \n> enum StreamRole {\n> \tStillCapture,\n> +\tStillCaptureRaw,\n> \tVideoRecording,\n> \tViewfinder,\n> };\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index f34ea08de03b744e..571bf41e072d00c1 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -363,6 +363,10 @@ std::string StreamConfiguration::toString() const\n> * \\var StillCapture\n> * The stream is intended to capture high-resolution, high-quality still images\n> * with low frame rate. The captured frames may be exposed with flash.\n> + * \\var StillCaptureRaw\n> + * The stream is intended to capture high-resolution, high-quality still images\n> + * with low frame rate in a raw format. The captured frames may be exposed with\n> + * flash.\n\nI would write \"high-resolution, raw still images with low frame rate.\"\n(or s/raw/RAW/) as the concept of quality probably doesn't apply the\nsame way to RAW. Not sure about the flash, especially given that we\ndon't support that yet, I think we could just drop that sentence.\n\nWe'll need to detail this more, but that's a comment that applies to all\nroles, so it's not blocking. With the above changes,\n\nReviewed-by: Laurent Pinchart \n\n> * \\var VideoRecording\n> * The stream is intended to capture video for the purpose of recording or\n> * streaming. The video stream may produce a high frame rate and may be","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9C7B60412\n\tfor ;\n\tMon, 23 Mar 2020 11:27:00 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D56A308;\n\tMon, 23 Mar 2020 11:27:00 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584959220;\n\tbh=89BXrdwhv+lu0f+z+GgOYjmeFR9P0gdGx/iHCYwYcII=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RZfcWhV5OpWEs6X7xoXEKYY1HWSKeGecPHeZgWBWdIHaKYx8K5QZZhEzpylVsCPaQ\n\tRnNyE2ZxIquC1TpVwj4jsae7ydkLexzzJ+Sai0/GBxYJGhIkSC1Z75mZip0su0FdMT\n\tsb4qjsNjN4QIZLo9LzFYxdbWDFcjhVcZItnRWCgk=","Date":"Mon, 23 Mar 2020 12:26:51 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200323102651.GB4768@pendragon.ideasonboard.com>","References":"<20200316024146.2474424-1-niklas.soderlund@ragnatech.se>\n\t<20200316024146.2474424-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200316024146.2474424-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC 1/6] libcamera: stream: Add\n\tStillCaptureRaw role","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 10:27:01 -0000"}},{"id":4277,"web_url":"https://patchwork.libcamera.org/comment/4277/","msgid":"<20200325105921.jptxg5oxyhegs3zd@uno.localdomain>","date":"2020-03-25T10:59:21","subject":"Re: [libcamera-devel] [RFC 1/6] libcamera: stream: Add\n\tStillCaptureRaw role","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Mon, Mar 23, 2020 at 12:26:51PM +0200, Laurent Pinchart wrote:\n> Hi Niklas,\n>\n> Thank you for the patch.\n>\n> On Mon, Mar 16, 2020 at 03:41:41AM +0100, Niklas Söderlund wrote:\n> > Add role to be used for streams capturing frames in a raw format for\n> > still capture in a low frame rate.\n\nnit:\n\nAdd a role for capturing high resolution, low frame rate, still images\nin RAW format.\n\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > include/libcamera/stream.h | 1 +\n> > src/libcamera/stream.cpp | 4 ++++\n> > 2 files changed, 5 insertions(+)\n> >\n> > diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> > index 29a8030dff71d58f..c4c0241ec9f34727 100644\n> > --- a/include/libcamera/stream.h\n> > +++ b/include/libcamera/stream.h\n> > @@ -58,6 +58,7 @@ private:\n> >\n> > enum StreamRole {\n> > \tStillCapture,\n> > +\tStillCaptureRaw,\n> > \tVideoRecording,\n> > \tViewfinder,\n> > };\n> > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > index f34ea08de03b744e..571bf41e072d00c1 100644\n> > --- a/src/libcamera/stream.cpp\n> > +++ b/src/libcamera/stream.cpp\n> > @@ -363,6 +363,10 @@ std::string StreamConfiguration::toString() const\n> > * \\var StillCapture\n> > * The stream is intended to capture high-resolution, high-quality still images\n> > * with low frame rate. The captured frames may be exposed with flash.\n> > + * \\var StillCaptureRaw\n> > + * The stream is intended to capture high-resolution, high-quality still images\n> > + * with low frame rate in a raw format. The captured frames may be exposed with\n> > + * flash.\n>\n> I would write \"high-resolution, raw still images with low frame rate.\"\n> (or s/raw/RAW/) as the concept of quality probably doesn't apply the\n> same way to RAW. Not sure about the flash, especially given that we\n> don't support that yet, I think we could just drop that sentence.\n\nAgred\n\nwith this\n\nReviewed-by: Jacopo Mondi \n\n>\n> We'll need to detail this more, but that's a comment that applies to all\n> roles, so it's not blocking. With the above changes,\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > * \\var VideoRecording\n> > * The stream is intended to capture video for the purpose of recording or\n> > * streaming. The video stream may produce a high frame rate and may be\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8A0160412\n\tfor ;\n\tWed, 25 Mar 2020 11:56:23 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0D98C40003;\n\tWed, 25 Mar 2020 10:56:22 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 25 Mar 2020 11:59:21 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200325105921.jptxg5oxyhegs3zd@uno.localdomain>","References":"<20200316024146.2474424-1-niklas.soderlund@ragnatech.se>\n\t<20200316024146.2474424-2-niklas.soderlund@ragnatech.se>\n\t<20200323102651.GB4768@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200323102651.GB4768@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC 1/6] libcamera: stream: Add\n\tStillCaptureRaw role","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 25 Mar 2020 10:56:24 -0000"}}]